Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 63gCey8JAfw0Q2D8vxCz9r0elzj68/6cKxaTnVFs8LRZwfyGMCPt/ZpBUwO3iRifNsIlewfx9D
 I2b9Sg/4LhZg==
IronPort-SDR: SX89+EBuBgxAxrixyu2cRCTTkInMh0breXbEkcZpPaEhyA49f6UaS3hr6X/MaTouw6dqetDT+B
 Pv4ZRVio/8Eg==
Date:   Fri, 12 Jun 2020 16:22:31 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        adrian.hunter@intel.com
Subject: Re: [PATCH v4 2/2] phy: intel: Add Keem Bay eMMC PHY support
Message-ID: <20200612132231.GH2428291@smile.fi.intel.com>
References: <20200612035359.14246-1-wan.ahmad.zainie.wan.mohamad@intel.com>
 <20200612035359.14246-3-wan.ahmad.zainie.wan.mohamad@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200612035359.14246-3-wan.ahmad.zainie.wan.mohamad@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 12, 2020 at 11:53:59AM +0800, Wan Ahmad Zainie wrote:
> Add support for eMMC PHY on Intel Keem Bay SoC.

Pretty much good, my comments below.

...

> +config PHY_KEEMBAY_EMMC
> +	tristate "Intel Keem Bay EMMC PHY Driver"

> +	depends on OF

No compile test?

> +	select GENERIC_PHY
> +	select REGMAP_MMIO
> +	help
> +	  Enable this to support the Keem Bay EMMC PHY.

Please, be more verbose here, do I, as a user, need this? What will be the module name?

-- 
With Best Regards,
Andy Shevchenko