Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp544152ybg; Fri, 12 Jun 2020 08:14:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaPxFYtQN/0qsWS3pJeWGDfjZcfxZzUzMJMxceSitsGEZwB+pv2YZSIdvA1zidQ9vswkx3 X-Received: by 2002:a17:906:2c10:: with SMTP id e16mr13142918ejh.189.1591974867848; Fri, 12 Jun 2020 08:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591974867; cv=none; d=google.com; s=arc-20160816; b=VniD56gtaA6JiL7QH9FGpyk0dk93Ou3ODzZArK5eAA93PDUpbQED9pZj1yNBD/PvS1 doMjrO0YxKUmHn2pgcGzDpmwWfEYQqgwYnklEKlr6FkRyeBYdjK9aYZCK23QvZ7eX+er nYoli8vB3IkvUb3ji3nOwtrzE3inDaiO3iw6UuS/FdyCw3OtdmmNYw2bdtoMaMJQyIrp Fu17x4RW2Ly4S1HvOgfF0aAFwzZ1CphfFxKZEzGme/fmrQoAJr5DsekfX/jTLnzdvvrA C3JN6V7lUnChYb3tA8UKHLSyBjCDqKMIlhTKFxQWaxX5alxaB7IPaF06VDcX/kFbdLpW Mpvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=zRtH5Tx4DTCn4Ps9c/wKc+Lqzl6Q/Syqcbllb2YPwXk=; b=kN0M9hnaQgTy+kAo0QV8Fe7poB3bGf+0dzAyr2Z48U4AIjRNSDDjDPM865UYUSqJ0I 29uVvQ2AA+qscf8ENloEQr6NJZdF50YOZ9xjmpsFn6/TVnGluH3ErJJ0JS9PU63QL/Y3 z+uXg7bHMDAAfKuCEEAsRqWQhmzBeZ+Hs2oujKqHl2hQZ+HdpmBw8DEh5H7wjAgQfZkR VUp/lGJxdTPkYSnut66jSvsw5pohW6Y66Bg50dQU+WYyW9yi9tUcVLoAHoQmn4uT5hfS Z16hX/57rdofVpzCHTEpa79er2Lv3+lYxbeKH0pOL4bXZbdWXzj2AEyrfpmstpaypPVP ThwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h26si3733524edj.196.2020.06.12.08.14.03; Fri, 12 Jun 2020 08:14:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbgFLPKu (ORCPT + 99 others); Fri, 12 Jun 2020 11:10:50 -0400 Received: from mga09.intel.com ([134.134.136.24]:16934 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726257AbgFLPKu (ORCPT ); Fri, 12 Jun 2020 11:10:50 -0400 IronPort-SDR: Bh87+QvBG22iqaFnyMb0n8l/G6Gat79QB7B61pkC4GcNpup2xy8m3QjaM5h/Ua5PDe0gA3k91k bSNXNC/VHM9g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 08:10:49 -0700 IronPort-SDR: 4JkrYmtVboNNLbg7cW9Y+q1f7vsTRdAMJ04hamINWV9k6cd5qkRCTTwAchhXdS1BfCUaJTaJy9 zmnTBKNCk9KA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,503,1583222400"; d="scan'208";a="315152617" Received: from rrhill-mobl1.amr.corp.intel.com (HELO [10.254.71.222]) ([10.254.71.222]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jun 2020 08:10:47 -0700 Subject: Re: [Sound-open-firmware] [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP To: Kai Vehmanen , Takashi Iwai Cc: alsa-devel@alsa-project.org, Bard Liao , Cezary Rojewski , Takashi Iwai , Keyon Jie , Liam Girdwood , Ranjani Sridharan , Mark Brown , Zhu Yingjiang , Jaroslav Kysela , Daniel Baluta , Brent Lu , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <1591959048-15813-1-git-send-email-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: <8530e0d0-de78-3f60-a849-99ef4f577ae0@linux.intel.com> Date: Fri, 12 Jun 2020 09:45:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/20 7:24 AM, Kai Vehmanen wrote: > Hey Brent, > > On Fri, 12 Jun 2020, Takashi Iwai wrote: > >> On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote: >>> >>> Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading >>> WP") from legacy HDA driver to fix the get response timeout issue. >>> Current SOF driver does not suffer from this issue because sync write >>> is enabled in hda_init. The issue will come back if the sync write is >>> disabled for some reason. >>> >>> Signed-off-by: Brent Lu >> >> Reviewed-by: Takashi Iwai > > thanks, looks good now: > > Reviewed-by: Kai Vehmanen CI results initiated by Kai don't show any regression and change looks good so: Reviewed-by: Pierre-Louis Bossart Thanks Brent!