Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp551791ybg; Fri, 12 Jun 2020 08:25:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxouxsx4Xuzxw7oAnXN5wC6lLMmKBj8xjHuxX/m9EaFHQE2EEmfpSFFqaHMtLKgjzN/3epm X-Received: by 2002:a17:906:e298:: with SMTP id gg24mr13418025ejb.120.1591975531129; Fri, 12 Jun 2020 08:25:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591975531; cv=none; d=google.com; s=arc-20160816; b=GmDJCHNccCvUWQBX2PHeFaRJfpBj1QGAe8bUOzEVpKXa5w+jsVnVomVJm0Ls3qihj6 rAcBp1MZAERCdrDP8i1p4CAnABPymjWiTnYrxwuBjM7AAQRCUjOZOJT6fG5AxqKqq+8i RSk97UzGcaqNYs9LDqXR3Tk2jiW42XvWf0z/kfmFtB3mtPeTWXNkh9RIQ76IX+iScSnK MSKyTpx9haBsi+btxoH73MfPau5N2fYIXm2T6elfG5iUqYro0uVcyI1RsH9PTAAYM+lI l3cFnhN/5xupbcKvu8+87uLlNJVkBe50lIzcbvyvLhIY2HmZmn46NrP0bovdJq/XqMgw 3mFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:subject:cc:to:from:dkim-signature; bh=eiN3ZFa8c3+DKP19UCWP8A2ovUYwqm/gcd5PK3KLrgk=; b=QvAiAb1gMya4He7FDJotrdurNarmlVJwjD8cs8bx0c/YSc9i+emakUbAMG6FMTexEs lvu6hF4C83HvLypcdsoezIOoQUW5psePgF4s+F/P2p4cqI2PGlgNa5iNQKzw76E45W/i hozcszlEt8wGJmxtgOi/6928DuP0Oyq5jDO8lqwyy9gPRkWdF1ckc3yxeB3D/vFkJJGZ /wllY3KA4I6ovDQiL/uXEkNjjV3tNxB0k33boCDZRY3c8OMyOHy0FKNBqDWWdt0lhH8q BvPGzHMx4IjDU6cWc/q5+o37QV+8LZLagvDZjwSH5oqZxr6hlIJzzqW7gmCYldePYXHd 3JDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BtAGtrLF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si4051307edf.333.2020.06.12.08.25.07; Fri, 12 Jun 2020 08:25:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BtAGtrLF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgFLPXN (ORCPT + 99 others); Fri, 12 Jun 2020 11:23:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:43030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgFLPXM (ORCPT ); Fri, 12 Jun 2020 11:23:12 -0400 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89098206A4; Fri, 12 Jun 2020 15:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591975392; bh=aZ5zbFgUlr+jWJ0e8ysaxSNTCOeYD7NUs6V0V1Bpp8c=; h=From:To:Cc:Subject:Date:From; b=BtAGtrLF01Hpw0qjYokpggMJh566Y3yNxB0TUBFVY1pWz9YVMWT9ABbWqGFyZy1JA sKNJ3iVlwnNLFNBV8pVAqPxxs9168/guKp2Y1cQkqXxBfyDWvAcDWLZaUcpdgy5siM 4gAjTe0Alq1i/w3IkEZFVqhSCR31Wqps68g27OkE= From: Masami Hiramatsu To: Steven Rostedt Cc: stable@vger.kernel.org, LKML Subject: [PATCH 0/4] bootconfig: Fix quote-character issue and return value Date: Sat, 13 Jun 2020 00:23:08 +0900 Message-Id: <159197538852.80267.10091816844311950396.stgit@devnote2> X-Mailer: git-send-email 2.25.1 User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, I found 2 bugs in /proc/bootconfig and tools/bootconfig. - They always use double-quote to quote values. For the values which includes double-quote, it should use single-quote instead. - tools/bootconfig always returns error code if it shows the bootconfig in initrd (executed without options) This series fixes those bugs and add testcases to ensure no regressions. Thank you, --- Masami Hiramatsu (4): proc/bootconfig: Fix to use correct quotes for value tools/bootconfig: Fix to use correct quotes for value tools/bootconfig: Fix to return 0 if succeeded to show the bootconfig tools/bootconfig: Add testcase for show-command and quotes test fs/proc/bootconfig.c | 13 +++++++++---- tools/bootconfig/main.c | 18 +++++++++++------- tools/bootconfig/test-bootconfig.sh | 10 ++++++++++ 3 files changed, 30 insertions(+), 11 deletions(-) -- Masami Hiramatsu (Linaro)