Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp624049ybg; Fri, 12 Jun 2020 10:09:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGd8FRUTUurosEYOqgXsw31HG5Bi9vqF6ZgF1NmL7Vx7VAP4cxnDSUILA9zXoHlRyc7xj4 X-Received: by 2002:a17:907:b03:: with SMTP id h3mr15099452ejl.367.1591981793349; Fri, 12 Jun 2020 10:09:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591981793; cv=none; d=google.com; s=arc-20160816; b=rLvdGosAPYdtzH8GdfPK6L3JhjA9CXVJdwyfOjKYFHjls6VZVm1Ins6J5VgRWiCmQZ ClKOaRK08MjnSKXrrMRsdwiz3ttwLkN+1VmCduQpBEJMT9VL9Okk/sC6GouTPNcMTFWC ZjLD6pFJUMNihUIZW8UTdVHuNnFkKFNq/CL8XGSdaDpTHWR/QiskAJvkcHuldi6tp9zW 031T2H9FPYbUl7h+NKwNiO2fsMDM6nyfo76n0tIcnA10qdtQZPd58/SxYtrnpkgCjdac fIquSwlJq59Y9MrLr23QDOWgqyp3tTdhnmfviMhS8PElPOype6Rf4medcCboubV1mBEW aKaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=xtTnwE6cHXO3dhZxqiTMuxZh84TFeLN2bcm3egTO8t4=; b=LXzyMeIPFsurIhpLe6muYhPKWffbZiXnpn39VoEuvP3IklYIdx37eMUUZJFejYzMd5 c84ySo4e+IIZIzQoBRBFEzv4h6XpX1si8Lb55WltP6omAWsZ15Hu4QvG8pXptVjAuZov 8rfVg9qI9Dn2GYJMLODQNgw5nNSZE5LqQn+sxDSlsG+59GFPYAgqrccVxPsqMkmOj94r QysdIYzjVrr7OlqI72fp7IM0/fjjSV6hn81F/7pbFX9QiVNaYt1dr5GtHW25XIlSgZNA 2ex62cEcDq9PyXnLVtffVEaikyi1Zia7MJIo1bMt0Z6wmLmPBPVpQXDitcxGQgAP/1SW TBng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=Bem2VpT4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si4224809ejb.653.2020.06.12.10.09.30; Fri, 12 Jun 2020 10:09:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=Bem2VpT4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbgFLREG (ORCPT + 99 others); Fri, 12 Jun 2020 13:04:06 -0400 Received: from mout.web.de ([212.227.17.12]:45997 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbgFLRED (ORCPT ); Fri, 12 Jun 2020 13:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591981431; bh=YSEcAwOr387X5HBmVwv6BhS4b5bKKB88hiXcZp0ZjIY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Bem2VpT4SAL8WPc7TCdBlS8RKB1muu1WhG0QO0x9xUpDHmQec+vtW73pGUdcYrd0N FtboUu/vN9Ptg4rX8dn2XhGW3DRs44hK7wDIla1jDJfCEoeazFpnBDWgkF8eZpZl/3 m34Ekqxy+oTj9P//Wjpy3YlmZOtldQ1zFuJqFOsg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.131.95.40]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MYNrh-1jNX6M0Cob-00VCW4; Fri, 12 Jun 2020 19:03:51 +0200 Subject: Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show() To: Matthew Wilcox , Kaitao Cheng , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Alexey Dobriyan , Colin Ian King , Muchun Song References: <20200612160946.21187-1-pilgrimtao@gmail.com> <7fdada40-370d-37b3-3aab-bfbedaa1804f@web.de> <20200612170033.GF8681@bombadil.infradead.org> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <98892099-4319-d442-5c6f-9f498d55e2c5@web.de> Date: Fri, 12 Jun 2020 19:03:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200612170033.GF8681@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9sFaHUXWouaJW1+LYeqwBmbvgak1ESoDaQM3tkYgPLf+p9oxaM+ usBuy1WdMMLBoCyUCN4wKjEMizqTXeHF2AychDAr6lbQIjUaoE02hvsLqHWZJk8X2T3uJ91 XpfHTRM9fBgi56tyauJ9DtRxVYbZFtPsOEaSu/2J/nwFa4mDAmAJzlSmP701HCp0WAmjyok umdWcKZY3vMr6wfwF34IQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:LuMuYuLr1/E=:+DxN5yWpLCcgZXKyA4GLHq Y0QHcenj0EbqMHmNgMvZi7dQ4E7S14yBJl7zLLkN9fp406I8njImDp1CM6d9Rn2CVNVir9Rg7 +/jiqs/gb20yrGEAnSWK2ivONyTKSFjZ+DoLIp6HVM8zJFQKkA5CcHIHp7S3CKIBcp5MQwCoi bBJvnGmuJVRg7kP534NvkkPBzg+sy7yjCYwKhLAFF1SzCJ/FIKjMceAy+zhjj1adpRQh7glAC e5keSIj0p3azZ7+l4SnQh1NBamYAQPu1U5w0YvUsrxDmgVwy94KZ69H2CPPE4E2wCTHV6mNuT wSLQTfbWSofw3NzGwH5ojHjSva4H9BW0oj/AUkQIHNiu8U4my99aFoVtCc6tONujDti1V5NVu kL85eoxv7z5cefWCnLffzn54shzNgijZoVbi+Fs1HRiDILL6TAgt1IeevWXudaXCLEziOgVsW yi5fQG907BUywH1QRQg3ltmKtMKb/yn/KMnTfWOMk5DQLrRQfAHH5OvW0JTfC5kszv4sQmZpM nghVOh/y5pTnwM71dVwMNMCsPoutwzNS+p67Uc/0G4iz1mSLG5bKhAnyuq0QjbFeKtsAPmrfY PEerE/t7jaSjjL3X43OjdToAIg4vLcuEo7j1xm1fPMq4j3UJKO0pVClvxOKLB1/waLBmyaiQz I//qylMEEt7vGZ8wxLj/mMN4mSNQ6nBC7rUd0Xbnio6l1klXdbb9ScBFcnNw+5V2rMy9X+WMn WKbZH8y0hwqFLwuR7shRXz48bcoIBLRIYPCqDs14BLCP/ELJr/WeFeDa1SisdF0QukO1/7E2R 6XGxLibjtiYBK4/GzydPlzXU77sDtISB9EuuxOPljv7orOqiH1JIFunCs5W/IN+75mTULoKQi TLh/tdGXkc6ndxI4ddS3BkQIy4Fd5Rw3fFozBadFhSyLNByF3z3B3duqL7/f5tIR5L/Rk3t0V U3qNmARq4r1j2N29aon2DQKzLbMxea0YE4EqHJSxJtHlznBWSgK2ZGpp7sHy7hdbXtsPj78Ri CQvDsCCR1JTJRJ8ZFU+w/TQKQl+dLvKb2wA0V2b9cqKGfJNJMoXYSO7KGAUlwk+UFu7O0ZzCo asMSuuhee/yPCWfXdtmjhE/4N5gDoMdCRgXZ3CnkMCrmqwMIMBk04AG+D9Ky4o3eAWsM9Nym6 H9uoBxNa34BuiPPiVat0Somy94CfKvD1R4wivpm2jFIAq38mN4MWHRJ2NqCYHSmaiS+8wR+fM 8OARsNIRDOHLS2mIh Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> 'files' will be immediately reassigned. 'f_flags' and 'file' will be >>> overwritten in the if{} or seq_show() directly exits with an error. >>> so we don't need to consume CPU resources to initialize them. >> >> I suggest to improve also this change description. >> >> * Should the mentioned identifiers refer to variables? >> >> * Will another imperative wording be preferred? >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr= ee/Documentation/process/submitting-patches.rst?id=3Db791d1bdf9212d944d749= a5c7ff6febdba241771#n151 >> >> * I propose to extend the patch a bit more. >> How do you think about to convert the initialisation for the variable= =E2=80=9Cret=E2=80=9D >> also into a later assignment? > > Please stop commenting on people's changelogs. You add no value. Would you like to clarify concrete software development ideas? Regards, Markus