Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp754038ybg; Fri, 12 Jun 2020 13:49:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSk2czMLsxXaaJTILVprR8BF39O/4ooY0WAGQh67xIrFrUD224Nc0Kj1qXMXZwd7WPS1jS X-Received: by 2002:a17:906:3e15:: with SMTP id k21mr15865311eji.525.1591994949937; Fri, 12 Jun 2020 13:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591994949; cv=none; d=google.com; s=arc-20160816; b=r6g58IVGuH7bDj9TzlejcaS9kWtKEUnkvMynsOtftYbI3bILgqF0aAD9m1klHrVpkM H/arkHiWJRfLGdRFKpfrlPtUhiboseoLxrVkiAnPyLLFN8Rn9+ORAzsx8LoyoJGWCpXH CR/SzQNWEnXYy5aQcbQMVJhriq2VERzozOpSTKDK5X29nL89I5YJRCkwRG6mAgcG4hT+ /8Y1e4xE1j8326HgzaL+asIOVyhu6m2puBQU4KtCo/MWLxOgRdw3ot8/7JVQkukHCEHa gFoU7Cx2nd4vbW+V0D0uK8rCm5JBJz215KfLaC1Xg3Lj7WDZ7yMD3GSwckpZCOk7CKUp cdKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ZazH0VjR8nOkVXg9FfAfk2+FFa/Z4E3sa+Jqh+oVdAM=; b=mtRjH48v4rxqD49KvYackuWhBNF9xqwscTYRPUItzvdMurytAH7uK9IgEPlfg5yBSE jrf6izkYr2G/xx1p8yoYLaqeUBLGl6vIpVPTQTNqpn3KHOPTFRROlUvqqRxR0S9WSFiu vDdCYSf0aE+tl1jFQgtI5m7vHcUuGqzdPHvZmuBz1xNwOKHGMwdetKamU9Ys8PNBMxdt iM2zjnfBw+rh0RQUgW1kL1vDKeu6bxWgZI2OZdQURpTGxhqrru0ETxSxDQf2X+VQnIvy e9/lWVLrJxPiKkUlwospXXuL8Zc7oI+NE1bSg+M0Ull9npvionKhhA7axfpbQV3ybjQT bHOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha26si4717078ejb.533.2020.06.12.13.48.46; Fri, 12 Jun 2020 13:49:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbgFLUrB (ORCPT + 99 others); Fri, 12 Jun 2020 16:47:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38758 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgFLUrB (ORCPT ); Fri, 12 Jun 2020 16:47:01 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jjqZM-000KbY-Gu; Fri, 12 Jun 2020 22:46:32 +0200 Date: Fri, 12 Jun 2020 22:46:32 +0200 From: Andrew Lunn To: Aditya Pakki Cc: kjlu@umn.edu, wu000273@umn.edu, "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Enrico Weigelt , Allison Randal , Thomas Gleixner , "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: Fix potential memory leak caused in error handling Message-ID: <20200612204632.GB69216@lunn.ch> References: <20200612200656.56019-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200612200656.56019-1-pakki001@umn.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2020 at 03:06:54PM -0500, Aditya Pakki wrote: > In ethoc_probe, a failure of mdiobus_register() does not release > the memory allocated by mdiobus_alloc. The patch fixes this issue. Hi Aditya Please improve the Subject: line to indicate which driver you are fixing. A Fixes: tag would also be nice. Andrew