Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp767257ybg; Fri, 12 Jun 2020 14:13:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzp74KI8FYAAGsFMa4wtxXu+LddoYhEiRYiVmhk0ceHqUUm9C7p6zIcprGJD8OQFC4UKPHw X-Received: by 2002:a17:906:4d0b:: with SMTP id r11mr14866062eju.59.1591996403764; Fri, 12 Jun 2020 14:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591996403; cv=none; d=google.com; s=arc-20160816; b=tOe/HHtupk16VXobsPSE556ch/oKJeUcnTjlCeCN8D6pu8+0pwc+gqpySxGa4PtBi9 EBdBgsnFzDTKKvcST0ycn+Lx31ITVa0SOYBHLr1x/rjsbX7jOjawAOlYMQCAQbU5KT0S wWj+681nIaUc+lfTMgs/4nUGA/SwGZ+fw93JhNSBKDTssxK/5mJRSFFA2JYT4RfW7Wl/ rmRyGUwgTRLEjYu5NyOiDgKZzwNDTwoiO3JWoB5ExWTqd6BoorNg5nInKm79f2FL8NLX hfr8ao50CpctojfsvKHYzi1BI/Y/XEkoMsB1LcviNF88jSQhYL5fxI5KjKzp19I/XSmG //EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=LdO+yABvrQyODTNWEnFCNLq5SRWaCDFSeyJReNxOrN4=; b=Y8OhdOs+L8nllP7XAnMtsvE1RbKTM0aNmS2NHWz0YAK3rjKI2sEyY3aEKcZfM3wv3B NJ+thLnF5kPwa6hEntMQbQ3Svu7ZZoCkyb2mo3rteq+2JtcvMe4w6Tgij6MwxDGnpik2 HCrTpHmatVy6SvnM50ZxZDHFEbIRm4MBi0kp8H4I7ustp6LgjNEjUAHrIYyeVSaQwK8m I6iyIC0VD9sou3mAOT7MPGCsOAA+hMnPUwMzz+B4wEnbFzZdpbtosUQMdH97dPoRBMq8 fvyx1MenxwfQaXkIZMiLk7wsqs9xdK3PHbEr87JRX1d3tgfUqAlBF3RuUq5g/J16gPvk bQ7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h25si4651724ejq.384.2020.06.12.14.12.59; Fri, 12 Jun 2020 14:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgFLVLF (ORCPT + 99 others); Fri, 12 Jun 2020 17:11:05 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:42480 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgFLVLF (ORCPT ); Fri, 12 Jun 2020 17:11:05 -0400 Received: by mail-io1-f67.google.com with SMTP id x189so2655331iof.9; Fri, 12 Jun 2020 14:11:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LdO+yABvrQyODTNWEnFCNLq5SRWaCDFSeyJReNxOrN4=; b=rvwlgD4CDjjxhRFq3GnZQuaaOWynCseOjX9XTo9tzIBXSOhAmSz3UyzW90JrGaUNgA 8l6XQTaJLbbAYinHsbyVqZwXnU1iGD0TVTxL7PK12EHY1B/hdJZ6yyPaIzah1ZSW4ixd wlZYMGu6nEhyDV6yxZklc+YHnRbVnTM/X6u/Kxugb6Xoooo1r2JNOig5X+R3kBZyBH7B gZr0MhgY7hh94dpkDNznckXaT0DYuxXBv+0/Dw5XB5KfkvswmqVgCwhGfk+rUODFshfa XD8EHjWo+gWCozzZfs7lWJxuaZGSzYit5jCcmoXeWvS54m/6p/HKFBXdZWb/vCRAWRff w6rg== X-Gm-Message-State: AOAM533McH6+m52BWG4lE2qXDMSeMO0VYlKFHHFQ6nWrsJ3EKNt3DiRo 037kzUbtuadW0f5sSilzGw== X-Received: by 2002:a05:6638:406:: with SMTP id q6mr10161463jap.125.1591996263990; Fri, 12 Jun 2020 14:11:03 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id d66sm3628624iof.27.2020.06.12.14.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 14:11:02 -0700 (PDT) Received: (nullmailer pid 3820221 invoked by uid 1000); Fri, 12 Jun 2020 21:11:01 -0000 Date: Fri, 12 Jun 2020 15:11:01 -0600 From: Rob Herring To: Adrian Ratiu Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Heiko Stuebner , Philippe CORNU , Yannick FERTRE , Jernej Skrabec , Andrzej Hajda , Jonas Karlman , linux-imx@nxp.com, kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com, Neil Armstrong , Fabio Estevam , Adrian Pop , Arnaud Ferraris , Sjoerd Simons , Martyn Welch Subject: Re: [PATCH v9 05/11] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Message-ID: <20200612211101.GA3808755@bogus> References: <20200609174959.955926-1-adrian.ratiu@collabora.com> <20200609174959.955926-6-adrian.ratiu@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609174959.955926-6-adrian.ratiu@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2020 at 08:49:53PM +0300, Adrian Ratiu wrote: > This provides an example DT binding for the MIPI DSI host controller It's not an example. It defines the exact binding for this peripheral. > present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. > > Cc: Rob Herring > Cc: Neil Armstrong > Cc: Fabio Estevam > Cc: Laurent Pinchart > Cc: devicetree@vger.kernel.org > Tested-by: Adrian Pop > Tested-by: Arnaud Ferraris > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch > Signed-off-by: Adrian Ratiu > --- > Changes since v8: > - Fixed small compatible string typo caught by checkpatch > - Added custom select for 'fsl,imx6-mipi-dsi' (Rob) > - Replaced additionalProperties -> unevaluatedProperties (Rob) > - Dropped all nodes not adding any new constraints apart from > the recently upstreamed snps,dw-mipi-dsi.yaml (Rob) > > Changes since v7: > - Clarified port@0,1 descriptions, marked them as required and > added missing port@0 in example (Laurent) > > Changes since v6: > - Added ref to the newly created snps,dw-mipi-dsi.yaml (Laurent) > - Moved *-cells properties outside patternProperties (Laurent) > - Removed the panel port documentation (Laurent) > - Wrapped lines at 80 chars, typo fixes, sort includes (Laurent) > > Changes since v5: > - Fixed missing reg warning (Fabio) > - Updated dt-schema and fixed warnings (Rob) > > Changes since v4: > - Fixed yaml binding to pass `make dt_binding_check dtbs_check` > and addressed received binding feedback (Rob) > > Changes since v3: > - Added commit message (Neil) > - Converted to yaml format (Neil) > - Minor dt node + driver fixes (Rob) > - Added small panel example to the host controller binding > > Changes since v2: > - Fixed commit tags (Emil) > --- > .../display/imx/fsl,mipi-dsi-imx6.yaml | 112 ++++++++++++++++++ > 1 file changed, 112 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > new file mode 100644 > index 0000000000000..86093729fd5f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,mipi-dsi-imx6.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 DW MIPI DSI Host Controller > + > +maintainers: > + - Adrian Ratiu > + > +description: | > + The i.MX6 DSI host controller is a Synopsys DesignWare MIPI DSI v1.01 > + IP block with a companion PHY IP. > + > + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in > + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with > + the following device-specific properties. > + > +allOf: > + - $ref: ../bridge/snps,dw-mipi-dsi.yaml# > + > +# Need a custom select here or 'snps,dw-mipi-dsi' will match lots of nodes > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6-mipi-dsi > + required: > + - compatible > + > +properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 These 2 are covered by dsi-controller.yaml, so you can drop them. Otherwise, Reviewed-by: Rob Herring