Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp6695ybt; Fri, 12 Jun 2020 17:44:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXVGWxxzXYY6xfgw7UvrA465Ra4aMZgDzMX2GLiPk/37scSNsX9cHZ9Dotj8qeRCdQ+PvL X-Received: by 2002:a17:906:1088:: with SMTP id u8mr16540235eju.428.1592009058466; Fri, 12 Jun 2020 17:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592009058; cv=none; d=google.com; s=arc-20160816; b=sUDMmRSQvPObcx02CzajKzLsDp/voJCiBWeMALHpOiR1B8/x2pCnSaNCkE+esNx2cC UqZA2RLcPNEuuz0FHJRz8NDGi7OLjlhiDIhNIy0T8mIMN7lQ+7tIdFUwAt13WMA+r+7i N2QkpZHeIgszgBs1UekvET/Zr3oQvqUU4eZxqK61BqabreScRy5fccjkc0RuvqiJz2pM CDUla/zida/mjmmj0FeHKEu9j27YHjqpjytahtBrovB9sdqt9SNUquJrTBQnuxw4G5Zf 91uxfda+a0wIZcZan69kfhqHMjb0BxXvHa2qDfjXEpOdqO5tzMVj1QvrP+TJC+gdEp4n XQOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=H+qeWkj6jF1dCVjjHvfwNeBqaDEmsa8WJpOki2499JE=; b=LrqFH3LNIjxQotQP/T+JgZq11QqIbbZPo8CAWRcysxeXNZKWAe61vsQ/lbmkHaLFEy +AfUL2e1bXGp5Mq4n3pl9Y5f7AQJe1/FvyCe3HxlfoG4Zckmr8dkKVhk2x/2AIMoKwCe mQgvhg75+EmBKfiQczXpfEfp1ZZkiKNiurKmUOveFTO8pZL46xpBfqyNUk5O5YXPqlcC OtGdFlblPtK2c5oa7GqA8sYMMCEbhssG6nayDHFD8xbLsDEtXUSSgLbjxpi3tjiGFHJ4 t9l3tNhqnM7qqqh6M0N1GvATMRhUn9KQgBZapYav5TRU+h8sVlH2m18WtZ7f9beEbd2p HDBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u2si4935036edx.353.2020.06.12.17.43.56; Fri, 12 Jun 2020 17:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726544AbgFMAmG (ORCPT + 99 others); Fri, 12 Jun 2020 20:42:06 -0400 Received: from mga12.intel.com ([192.55.52.136]:1255 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726468AbgFMAly (ORCPT ); Fri, 12 Jun 2020 20:41:54 -0400 IronPort-SDR: eGhtXnv6KIPjqZbJ188qAWBtovyRRHC5t0DR0QP7p5WxpY4CM2xagSkp0T7v3KwGBE7LlU2g6X j6Av+Wx2DCyA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 17:41:53 -0700 IronPort-SDR: fmiiY19X0mVPhAZTCXrrWpeLLJUOyorevwMoQve0wMIiAHWDFz2n3Eu+8jteSAJwCs62ov0p2h I9/9SJi9hUyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,505,1583222400"; d="scan'208";a="261011233" Received: from romley-ivt3.sc.intel.com ([172.25.110.60]) by orsmga007.jf.intel.com with ESMTP; 12 Jun 2020 17:41:53 -0700 From: Fenghua Yu To: "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "H Peter Anvin" , "David Woodhouse" , "Lu Baolu" , "Frederic Barrat" , "Andrew Donnellan" , "Felix Kuehling" , "Joerg Roedel" , "Dave Hansen" , "Tony Luck" , "Ashok Raj" , "Jacob Jun Pan" , "Dave Jiang" , "Yu-cheng Yu" , "Sohil Mehta" , "Ravi V Shankar" Cc: "linux-kernel" , "x86" , iommu@lists.linux-foundation.org, "amd-gfx" , "linuxppc-dev" , Fenghua Yu Subject: [PATCH v2 10/12] x86/process: Clear PASID state for a newly forked/cloned thread Date: Fri, 12 Jun 2020 17:41:31 -0700 Message-Id: <1592008893-9388-11-git-send-email-fenghua.yu@intel.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1592008893-9388-1-git-send-email-fenghua.yu@intel.com> References: <1592008893-9388-1-git-send-email-fenghua.yu@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PASID state has to be cleared on forks, since the child has a different address space. The PASID is also cleared for thread clone. While it would be correct to inherit the PASID in this case, it is unknown whether the new task will use ENQCMD. Giving it the PASID "just in case" would have the downside of increased context switch overhead to setting the PASID MSR. Since #GP faults have to be handled on any threads that were created before the PASID was assigned to the mm of the process, newly created threads might as well be treated in a consistent way. Suggested-by: Thomas Gleixner Signed-off-by: Fenghua Yu Reviewed-by: Tony Luck --- v2: - Modify init_task_pasid(). arch/x86/kernel/process.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index f362ce0d5ac0..1b1492e337a6 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -121,6 +121,21 @@ static int set_new_tls(struct task_struct *p, unsigned long tls) return do_set_thread_area_64(p, ARCH_SET_FS, tls); } +/* Initialize the PASID state for the forked/cloned thread. */ +static void init_task_pasid(struct task_struct *task) +{ + struct ia32_pasid_state *ppasid; + + /* + * Initialize the PASID state so that the PASID MSR will be + * initialized to its initial state (0) by XRSTORS when the task is + * scheduled for the first time. + */ + ppasid = get_xsave_addr(&task->thread.fpu.state.xsave, XFEATURE_PASID); + if (ppasid) + ppasid->pasid = INIT_PASID; +} + int copy_thread_tls(unsigned long clone_flags, unsigned long sp, unsigned long arg, struct task_struct *p, unsigned long tls) { @@ -174,6 +189,9 @@ int copy_thread_tls(unsigned long clone_flags, unsigned long sp, task_user_gs(p) = get_user_gs(current_pt_regs()); #endif + if (static_cpu_has(X86_FEATURE_ENQCMD)) + init_task_pasid(p); + /* Set a new TLS for the child thread? */ if (clone_flags & CLONE_SETTLS) ret = set_new_tls(p, tls); -- 2.19.1