Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp303816ybt; Sat, 13 Jun 2020 05:09:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkX03xiWHsx6RB8DXrluk6SpdzG40mlYr2uOvbl36+PUBhzOOQ5UrgqRY9xiR4EvDA9/H5 X-Received: by 2002:a05:6402:699:: with SMTP id f25mr15959737edy.281.1592050178727; Sat, 13 Jun 2020 05:09:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592050178; cv=none; d=google.com; s=arc-20160816; b=wfUJwVphETY0uEP4XFmUv0Sosy4JmigwqLEr6WSFCLOm3R5Q4Kb606RzWyiIqcVgVf 6kuDsJsOHQaQmKxDFFNiVieKGjJ29Bk0ScCyQZg3a/a/kHC8bJHpxB/TOLrtzwaCs6ED dTM3PR8GTdVcsqz9Z5YONVLLIxXU4xd/zcbXrsplqW6WJm7yUwBfNvbTn3JO8/Yzr2IG tk8Tk3N+9eTvxel/79SShivvm/vI/UtuKoecORIcWvOGXc9pgleFYycHB24aegDbNNSN fXWsoARv8I6il5+AMwEMFokiX0Es/opsBMT6QVN60J67y+Q71HjFyJfhxIuOPNEcal2n bD0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=neCcG1dk3gHcTR94EupwHe3jWPWKcFSQgRt8l5SAAfw=; b=z52rRPV2E15AJko+n1Cs559y12nyWuoQF3J7UL5x3o7jdMvipCWETiTkR58HHrSX0i jGe42FrTdg4U1dzvwDvJkRPRZwBz5ZyqB7y3jTGzqz0ZSgZeVJhEjJaUiEsDbWXdCsZ/ 7I5DbwQ4EbkSemNkKvkkZ7DPNVeEDy4T6zZHmCnmL7HxvtxhQc8djnoFffLMap2KtdsQ 9JmRdRzKz447YCMiifI+qlsP5XcDxc6P3yYpN42xL2eU/KHVHYYGgz5GzYD874QVExg4 s7DVS+y3JhmSW8yOLnANgQxtcEh5Zav8ukEiat5IXfMkhdBwFBLJdBn+v3F5TLtqApA1 evwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=W+Gc4oBh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u27si5665399eje.558.2020.06.13.05.08.42; Sat, 13 Jun 2020 05:09:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=W+Gc4oBh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbgFMLzJ (ORCPT + 99 others); Sat, 13 Jun 2020 07:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgFMLzJ (ORCPT ); Sat, 13 Jun 2020 07:55:09 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE92C03E96F; Sat, 13 Jun 2020 04:55:08 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id h185so5583905pfg.2; Sat, 13 Jun 2020 04:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=neCcG1dk3gHcTR94EupwHe3jWPWKcFSQgRt8l5SAAfw=; b=W+Gc4oBh+/wch7Ht8yeb+NznsMjrv0+yvhqeFNVv8zQYreozgTPMCqo51zNBZ8R9Sl YqD/wB60lKQ2iQW0uh4i8c2x/hd5R/JchCMgmw0TuCWGOQTiZFxenqstub2gbOSDWnmD LayCE1D/qMnsh31F9H+EnD02dHbomn2HtSZ32Sf2SoP3vcTUFPO14o85PZ/mWt1S5Fcc Y2PQlxPClH0tDWEQiMz9ZxogLxNivSvS0M9kHq9XS6NZcNtX1q740/kiPODDd6xx6CpA AEvLk7mqtC5T/t4oKtVMBX0VjcUGRD/oDdOY3lYMzU7SFxgZmtj574kuGqxF0n6zzNmh JPNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=neCcG1dk3gHcTR94EupwHe3jWPWKcFSQgRt8l5SAAfw=; b=RX3eSdZ8T4Lu1Auv8rHqintGU7S6p75oQ/U+MMKNsPK/c+HetNfjMENrZqApaHGU7j V+JjCxO4s4ZuwsIXc8y4ip47Ip7uKru+UEH1glTtnscdjLED3emcp8VxZdGkQZTvj+Vp 3wMkNqi39taUgilYFARpfirZsOauB4AZfVW8J6VRKUQuM9KOdljfluYky/von1NqAzm3 Fn8nS+nXLog3wuu0NgqGWIg660KVwTHCut0/zaBLNVbvXI9UM+shlnfsUp76ZzWbhD+V JdND8F/kaBVUeTy7zoVirufBKmlTm+TjTeLLNzXrFfdLLXrliopNFYXWxK1yBkoZDiP7 1xPA== X-Gm-Message-State: AOAM533TBMUhqgzyfsXfRT/rofWosgKpJlik3nQlNu74lx7KS4+PoeWv 1RJlUNt5nCyBcFuf+1vNAVP44FS3ATVX41dBYpA= X-Received: by 2002:a63:ff52:: with SMTP id s18mr14923524pgk.203.1592049308294; Sat, 13 Jun 2020 04:55:08 -0700 (PDT) MIME-Version: 1.0 References: <20200612124844.19422-1-wsa+renesas@sang-engineering.com> <20200613113924.GA5578@kunai> In-Reply-To: <20200613113924.GA5578@kunai> From: Andy Shevchenko Date: Sat, 13 Jun 2020 14:54:51 +0300 Message-ID: Subject: Re: [PATCH] lib: update DEBUG_SHIRQ docs to match reality To: Wolfram Sang Cc: Linux Kernel Mailing List , Linux-Renesas , Krzysztof Kozlowski , Oleksij Rempel , Marc Kleine-Budde , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2020 at 2:39 PM Wolfram Sang wrote: > > > > > There is no extra interrupt when registering a shared interrupt handler > > > since 2011. Update the Kconfig text to make it clear and to avoid wrong > > > assumptions when debugging issues found by it. > > > > > > > I'm not sure. > > I have recently fixed a bug in the IIO sensor during ->probe() due to > > an issued test interrupt exactly as soon as the handler is registered. > > $ git grep DEBUG_SHIRQ_FIXME > kernel/irq/manage.c:#ifdef CONFIG_DEBUG_SHIRQ_FIXME > > There is no place to enable this code. > > Maybe your case was like Krzysztof's case where the issue turned out to > be the extra interrupt on deregistering after a deferred probe? He > thought it was the initial interrupt but it wasn't. Commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/iio/pressure/bmp280-core.c?id=97b31a6f5fb95b1ec6575b78a7240baddba34384 The relevant IRQ core code https://elixir.bootlin.com/linux/latest/source/kernel/irq/manage.c#L1774 It runs it at deregistering, right. -- With Best Regards, Andy Shevchenko