Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp338724ybt; Sat, 13 Jun 2020 06:11:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjCJen1Y4ka2/8qDGOkcGniwDEJ9sKwuHmbpnPCh/gFbx7yaRvz3Z/JVup9vnoXAMH4+Rb X-Received: by 2002:a17:906:7693:: with SMTP id o19mr16746572ejm.295.1592053904411; Sat, 13 Jun 2020 06:11:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592053904; cv=none; d=google.com; s=arc-20160816; b=R1ho7ZQCW9TvqaVXdraocfGvktkz8JiLWGnjb8TSOhKBxMzkZDXDRa1YOwxEarjyuW YnCIJfQ6XtjXs7tF5Lr6GiPJZpmEaULkysC9eRBS5kR0KIJf7U6WhU3fHtboc0RUl3IR +O9Y7vDsp5/0IB8OZAZ5Yh8TBpjoCRuno1lzRSy6AkMQiZKxM0o9l97zpOKBxY1oTRyx EPqPnmhDcOfJ6XLjpOAn753iFJ13+8EYFhIVNZNA5SH+XKIkewH2j/a43LQHQILMsVNf ljlF+rAXAqpULEhHQQjwAtY9JvtMA/jmci1M98DxPmh7dpJIQPQi36PnddA8r1AFjALc mS2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:cc:ironport-sdr:ironport-sdr; bh=qh975fn8ZBEHhafBSWH7xERh6Mmx2Ea4oweS84kMcro=; b=m/WQbfRCAC/XoZvR0GHR+tRie+jfHtvtXQdrBMwR/6LDuBq3BrqbzZ71M/yFEDmplA gRFcLJtTyykB8SOTm2Kuy78mawV5CDHzkkLCoJ5jZiFNsf17+g/hMjElaJklU7N+Ftm1 1grtHj05YFLPq2licbbeQmzPS66D82DAlYOOyq7MUNRoFK8Gq/jH8dt0TjI8f8BKrFMV jPqrbImZBfzJi5/pRBrNb8KW+9to0qtMtfdDW3727nR0UhsjBnacvpxM0qRU1mH2Soea pkazurBbfMbEyr0YeKpgdg7VNBhWtjr3DQBN0jr/PAZxQVOf0qho4BTOrjl/P/CRkBdh IjMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si5391715ejg.316.2020.06.13.06.11.22; Sat, 13 Jun 2020 06:11:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbgFMNHc (ORCPT + 99 others); Sat, 13 Jun 2020 09:07:32 -0400 Received: from mga07.intel.com ([134.134.136.100]:45005 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgFMNHb (ORCPT ); Sat, 13 Jun 2020 09:07:31 -0400 IronPort-SDR: 4FLJeaxhI6DOMIWt/eGE6XNu4Dy49lHP4yFNy5yCEojSAghNdK7ZWbHenK1aLBzHVC1iPqlOW+ /x5TRbCOPlUw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2020 06:07:31 -0700 IronPort-SDR: vHst0eXicXHqYEf+pQk0FSDzcIS8JhPFi+JBqhLFRJPdt7Y4MLGJDj+ei71bhsRntiGwHJ+HBH NIehc6CkMHjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,507,1583222400"; d="scan'208";a="419815734" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.255.28.93]) ([10.255.28.93]) by orsmga004.jf.intel.com with ESMTP; 13 Jun 2020 06:07:25 -0700 Cc: baolu.lu@linux.intel.com, linux-kernel , x86 , iommu@lists.linux-foundation.org, amd-gfx , linuxppc-dev Subject: Re: [PATCH v2 11/12] x86/mmu: Allocate/free PASID To: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , David Woodhouse , Frederic Barrat , Andrew Donnellan , Felix Kuehling , Joerg Roedel , Dave Hansen , Tony Luck , Ashok Raj , Jacob Jun Pan , Dave Jiang , Yu-cheng Yu , Sohil Mehta , Ravi V Shankar References: <1592008893-9388-1-git-send-email-fenghua.yu@intel.com> <1592008893-9388-12-git-send-email-fenghua.yu@intel.com> From: Lu Baolu Message-ID: <59971fe5-31ec-defb-ead6-3e733aa371f7@linux.intel.com> Date: Sat, 13 Jun 2020 21:07:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <1592008893-9388-12-git-send-email-fenghua.yu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fenghua, On 2020/6/13 8:41, Fenghua Yu wrote: > A PASID is allocated for an "mm" the first time any thread attaches > to an SVM capable device. Later device attachments (whether to the same > device or another SVM device) will re-use the same PASID. > > The PASID is freed when the process exits (so no need to keep > reference counts on how many SVM devices are sharing the PASID). FYI. Jean-Philippe Brucker has a patch for mm->pasid management in the vendor agnostic manner. https://www.spinics.net/lists/iommu/msg44459.html Best regards, baolu > > Signed-off-by: Fenghua Yu > Reviewed-by: Tony Luck > --- > v2: > - Define a helper free_bind() to simplify error exit code in bind_mm() > (Thomas) > - Fix a ret error code in bind_mm() (Thomas) > - Change pasid's type from "int" to "unsigned int" to have consistent > pasid type in iommu (Thomas) > - Simplify alloc_pasid() a bit. > > arch/x86/include/asm/iommu.h | 2 + > arch/x86/include/asm/mmu_context.h | 14 ++++ > drivers/iommu/intel/svm.c | 101 +++++++++++++++++++++++++---- > 3 files changed, 105 insertions(+), 12 deletions(-) > > diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h > index bf1ed2ddc74b..ed41259fe7ac 100644 > --- a/arch/x86/include/asm/iommu.h > +++ b/arch/x86/include/asm/iommu.h > @@ -26,4 +26,6 @@ arch_rmrr_sanity_check(struct acpi_dmar_reserved_memory *rmrr) > return -EINVAL; > } > > +void __free_pasid(struct mm_struct *mm); > + > #endif /* _ASM_X86_IOMMU_H */ > diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h > index 47562147e70b..f8c91ce8c451 100644 > --- a/arch/x86/include/asm/mmu_context.h > +++ b/arch/x86/include/asm/mmu_context.h > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > extern atomic64_t last_mm_ctx_id; > > @@ -117,9 +118,22 @@ static inline int init_new_context(struct task_struct *tsk, > init_new_context_ldt(mm); > return 0; > } > + > +static inline void free_pasid(struct mm_struct *mm) > +{ > + if (!IS_ENABLED(CONFIG_INTEL_IOMMU_SVM)) > + return; > + > + if (!cpu_feature_enabled(X86_FEATURE_ENQCMD)) > + return; > + > + __free_pasid(mm); > +} > + > static inline void destroy_context(struct mm_struct *mm) > { > destroy_context_ldt(mm); > + free_pasid(mm); > } > > extern void switch_mm(struct mm_struct *prev, struct mm_struct *next, > diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c > index 4e775e12ae52..27dc866b8461 100644 > --- a/drivers/iommu/intel/svm.c > +++ b/drivers/iommu/intel/svm.c > @@ -425,6 +425,53 @@ int intel_svm_unbind_gpasid(struct device *dev, unsigned int pasid) > return ret; > } > > +static void free_bind(struct intel_svm *svm, struct intel_svm_dev *sdev, > + bool new_pasid) > +{ > + if (new_pasid) > + ioasid_free(svm->pasid); > + kfree(svm); > + kfree(sdev); > +} > + > +/* > + * If this mm already has a PASID, use it. Otherwise allocate a new one. > + * Let the caller know if a new PASID is allocated via 'new_pasid'. > + */ > +static int alloc_pasid(struct intel_svm *svm, struct mm_struct *mm, > + unsigned int pasid_max, bool *new_pasid, > + unsigned int flags) > +{ > + unsigned int pasid; > + > + *new_pasid = false; > + > + /* > + * Reuse the PASID if the mm already has a PASID and not a private > + * PASID is requested. > + */ > + if (mm && mm->pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > + /* > + * Once a PASID is allocated for this mm, the PASID > + * stays with the mm until the mm is dropped. Reuse > + * the PASID which has been already allocated for the > + * mm instead of allocating a new one. > + */ > + ioasid_set_data(mm->pasid, svm); > + > + return mm->pasid; > + } > + > + /* Allocate a new pasid. Do not use PASID 0, reserved for init PASID. */ > + pasid = ioasid_alloc(NULL, PASID_MIN, pasid_max - 1, svm); > + if (pasid != INVALID_IOASID) { > + /* A new pasid is allocated. */ > + *new_pasid = true; > + } > + > + return pasid; > +} > + > /* Caller must hold pasid_mutex, mm reference */ > static int > intel_svm_bind_mm(struct device *dev, unsigned int flags, > @@ -518,6 +565,8 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, > init_rcu_head(&sdev->rcu); > > if (!svm) { > + bool new_pasid; > + > svm = kzalloc(sizeof(*svm), GFP_KERNEL); > if (!svm) { > ret = -ENOMEM; > @@ -529,12 +578,9 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, > if (pasid_max > intel_pasid_max_id) > pasid_max = intel_pasid_max_id; > > - /* Do not use PASID 0, reserved for RID to PASID */ > - svm->pasid = ioasid_alloc(NULL, PASID_MIN, > - pasid_max - 1, svm); > + svm->pasid = alloc_pasid(svm, mm, pasid_max, &new_pasid, flags); > if (svm->pasid == INVALID_IOASID) { > - kfree(svm); > - kfree(sdev); > + free_bind(svm, sdev, new_pasid); > ret = -ENOSPC; > goto out; > } > @@ -547,9 +593,7 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, > if (mm) { > ret = mmu_notifier_register(&svm->notifier, mm); > if (ret) { > - ioasid_free(svm->pasid); > - kfree(svm); > - kfree(sdev); > + free_bind(svm, sdev, new_pasid); > goto out; > } > } > @@ -565,12 +609,18 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, > if (ret) { > if (mm) > mmu_notifier_unregister(&svm->notifier, mm); > - ioasid_free(svm->pasid); > - kfree(svm); > - kfree(sdev); > + free_bind(svm, sdev, new_pasid); > goto out; > } > > + if (mm && new_pasid && !(flags & SVM_FLAG_PRIVATE_PASID)) { > + /* > + * Track the new pasid in the mm. The pasid will be > + * freed at process exit. Don't track requested > + * private PASID in the mm. > + */ > + mm->pasid = svm->pasid; > + } > list_add_tail(&svm->list, &global_svm_list); > } else { > /* > @@ -640,7 +690,8 @@ static int intel_svm_unbind_mm(struct device *dev, unsigned int pasid) > kfree_rcu(sdev, rcu); > > if (list_empty(&svm->devs)) { > - ioasid_free(svm->pasid); > + /* Clear data in the pasid. */ > + ioasid_set_data(pasid, NULL); > if (svm->mm) > mmu_notifier_unregister(&svm->notifier, svm->mm); > list_del(&svm->list); > @@ -1001,3 +1052,29 @@ unsigned int intel_svm_get_pasid(struct iommu_sva *sva) > > return pasid; > } > + > +/* > + * An invalid pasid is either 0 (init PASID value) or bigger than max PASID > + * (PASID_MAX - 1). > + */ > +static bool invalid_pasid(unsigned int pasid) > +{ > + return (pasid == INIT_PASID) || (pasid >= PASID_MAX); > +} > + > +/* On process exit free the PASID (if one was allocated). */ > +void __free_pasid(struct mm_struct *mm) > +{ > + unsigned int pasid = mm->pasid; > + > + /* No need to free invalid pasid. */ > + if (invalid_pasid(pasid)) > + return; > + > + /* > + * Since the pasid is not bound to any svm by now, there is no race > + * here with binding/unbinding and no need to protect the free > + * operation by pasid_mutex. > + */ > + ioasid_free(pasid); > +} >