Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp614360ybt; Sat, 13 Jun 2020 15:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNGavbSHZk8Yx/pNac0x8mq6P74LbOGRlf1bO4gYWpH9j5ROPDZv3mwcZvWuUUX7mO6OYw X-Received: by 2002:a17:906:35cf:: with SMTP id p15mr19680838ejb.520.1592087948923; Sat, 13 Jun 2020 15:39:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592087948; cv=none; d=google.com; s=arc-20160816; b=l2suNDvA9peu8Id9tVUoJN6T2GX/dxrhV4nY7McOFVS5J5o1oeydb1Gmgm9pHdFK5D NPB3V7GuynQasPr0eaP0yL00tPBVOawfwzobRAI1clAtnhMqf7WZOoHKgOlvoRJntCx4 nZ+4O4l6Ifc30ugU4Xtqo03s1OoikAbf6QnToNuZGrR0I5Ss50xA5BkwGp5d3MF7JwLG S7C1inhnbmmah0cU+fYctDdDj+Emhl47eumABsIYbfW5ZFsbwBxELIj8/orhpWJW9IrK rWTqHdD2TcJvVwiy/o3r8L4njFvLAk82FrD7JzAEk1dN3ViME6NlFLiPcCPOfNVj6tcX 0ftg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=MsxSNSWu5WD8jMh67/fRBqZEczfqOOR6ef+YVsRr9WY=; b=ZaLxYa3X3K0ZbuBmZjq71WgQ7Sty1pSDNb2gfNfuEl7CoefAz7oJNRr+ndppwS8nYR Rsqef7cIu09zGeywh0Tek3kCK3t7N85xXe35z0ZsGIu2yIuodCD3ZD9mqZK3LSqU9Pv2 JiTCcJgHFbuAYcsv6vysBJAJgtjn9y+EF0ZAAkJWu94oaZ3UknuPRNLQFSkDFKBDo2OO SS6fwItu/tHhE/8grkYejb0OyuXxx6CPgbJW8FkHUm9rSSsqnElk6zJjmTM8/1Pg5mrL aP98FusmvucHh6pLlBfiybD99UMVp2WWlD+ChVdfOpOx2S9u+bsGLkzeFmJGaJr4UQXw OeSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (no key) header.i=@uniroma2.it header.s=ed201904; dkim=fail header.i=@uniroma2.it header.s=rsa201904 header.b=ean5dyqR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=uniroma2.it Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k18si6689041edk.48.2020.06.13.15.38.46; Sat, 13 Jun 2020 15:39:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=neutral (no key) header.i=@uniroma2.it header.s=ed201904; dkim=fail header.i=@uniroma2.it header.s=rsa201904 header.b=ean5dyqR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=uniroma2.it Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbgFMWgR (ORCPT + 99 others); Sat, 13 Jun 2020 18:36:17 -0400 Received: from smtp.uniroma2.it ([160.80.6.16]:41795 "EHLO smtp.uniroma2.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgFMWgQ (ORCPT ); Sat, 13 Jun 2020 18:36:16 -0400 Received: from smtpauth-2019-1.uniroma2.it (smtpauth.uniroma2.it [160.80.5.46]) by smtp-2015.uniroma2.it (8.14.4/8.14.4/Debian-8) with ESMTP id 05DMZxuG019259; Sun, 14 Jun 2020 00:36:04 +0200 Received: from lubuntu-18.04 (unknown [160.80.103.126]) by smtpauth-2019-1.uniroma2.it (Postfix) with ESMTPSA id 7B69212093E; Sun, 14 Jun 2020 00:35:54 +0200 (CEST) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=uniroma2.it; s=ed201904; t=1592087755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MsxSNSWu5WD8jMh67/fRBqZEczfqOOR6ef+YVsRr9WY=; b=VPAcboqRmMNleJACcpdM1QYqhnF4kvR/lSDmChodPo4fFw3MR0kWNgM7z1Bu/rOPJG8y7c dUwiVb7ALY7aE+DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniroma2.it; s=rsa201904; t=1592087755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MsxSNSWu5WD8jMh67/fRBqZEczfqOOR6ef+YVsRr9WY=; b=ean5dyqRTvryl0C/DnYRYjcPoqJodQHoy2hlrjz7bwF/ymZa3W9SVBQPG5LRTOQMNuInPe lzD6eqH+JSh9rObufD3lr0mEwivDUupUzkKEkRBWkE+kuOB0uY6xSVM7ntgXAs6Ng4yQmi QltbM95WeAnT2AHhK/yi3w1TtPSXY2I7HpkL1IVnWIjgBV12I9CUbfKDuJKf/RpqWLRa8o 7xl7MOxwyMxOFzUNKibFffD16Fa435/RgVT8x3aESR/k6EApD1k/2F19Z8Yf9EsylleYwB bQXElNccPltGiCPtLVhOu91asE8hRSgPBi402xKqtIJhGc+t/vFjB+84Bp5B6w== Date: Sun, 14 Jun 2020 00:35:54 +0200 From: Andrea Mayer To: Jakub Kicinski Cc: Andrea Mayer , David Ahern , "David S. Miller" , Shrijeet Mukherjee , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Donald Sharp , Roopa Prabhu , Dinesh Dutt , Stefano Salsano , Paolo Lungaroni , Ahmed Abdelsalam Subject: Re: [RFC,net-next, 1/5] l3mdev: add infrastructure for table to VRF mapping Message-Id: <20200614003554.4bfed8a61a5741bfd2660d30@uniroma2.it> In-Reply-To: <20200612105148.1b977dc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20200612164937.5468-1-andrea.mayer@uniroma2.it> <20200612164937.5468-2-andrea.mayer@uniroma2.it> <20200612105148.1b977dc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.100.0 at smtp-2015 X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2020 10:51:48 -0700 Jakub Kicinski wrote: > net/l3mdev/l3mdev.c:12:1: warning: symbol 'l3mdev_lock' was not declared. Should it be static? > > Please make sure it doesn't add errors with W=1 C=1 :) Hi Jakub, thanks for your feedback. sorry, I did not want to add more warnings! I will declare the l3mdev_lock static! I will be more careful while checking with W=1 and C=1 next time. Thanks, Andrea