Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp629510ybt; Sat, 13 Jun 2020 16:18:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYWyGTrHfZNOXkSxZ5lSYjYE+2iariwHJABSOEqrH980qM2NLC8dVWo9Hbr+kFPixowz9s X-Received: by 2002:a50:bf4c:: with SMTP id g12mr703111edk.203.1592090288970; Sat, 13 Jun 2020 16:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592090288; cv=none; d=google.com; s=arc-20160816; b=xW/2lr8ktxTOF63bP9cnaGsTwC/urCZbNFhvy6F0C7rhVB2KFSBxu25THg8DgXXnrV XteAPsh+nC81y4yRzHi4k4b3bpk2bbDPVnRME8iKQoElsQdIdM3eqUB5OBiY7oq7oTRk 03QXCnXL2Tm6M9JA8o++3jwKUEZBJhw2dMdbXJ2CdaSQcvJJbTEXCyWUwxK4SD/J7Xzr Ck1Ym4fBgYUuaVqbg19gi4qysUa3W4OtQBvJYDZj2TNZ+VYSUwPoXmLKv8oZDr2ALKI0 mthMNhgbyDxY+HGTsDlHptZjHb60pP5LRDHbA7gUJr1118EE6RJpgvkJ4mhwgnzrfWzJ UmYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:dmarc-filter; bh=Lp/57Kv3gzuXj/K9oQ77nASFzku70Zj4jK0Z7RozDsE=; b=pxM1GbD1oe44/Ii4MC0PftMMqthV5AMwNlkoeV39FSAmK17YtkwGXvaT/2RIL+yOXr K4YOdS87TsJNttDGejdGCuMhByLzE6jL78bapaMPtQ27fuUnpVnyAyOZv6eEb6GwOgKb JXvr71juXGRH8pz32TqcvDkoBMKqn3n9N1uxY4aEkeop6s3xH4tjyhry0wMaYRVf9PbN 4pCY5t57PEOW2t/C97c0hyND6VTvSz/335Dvm8cvcYtwnFfpv4mc/i0eMJPgKAd/zoZj Xmwgz5ltl1aEgtIGlBbZjeuKpKzCzQp/4G6BqYk8V+ejcprH75n/EXykhPGZIdtu66Cd 4UDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=lfurDX56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp20si6609862ejb.307.2020.06.13.16.17.44; Sat, 13 Jun 2020 16:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=lfurDX56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbgFMXN7 (ORCPT + 99 others); Sat, 13 Jun 2020 19:13:59 -0400 Received: from mta-p7.oit.umn.edu ([134.84.196.207]:55544 "EHLO mta-p7.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgFMXN6 (ORCPT ); Sat, 13 Jun 2020 19:13:58 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 49kth51FM4z9vYdP for ; Sat, 13 Jun 2020 23:13:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MYrtAo2FeTNp for ; Sat, 13 Jun 2020 18:13:57 -0500 (CDT) Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 49kth46gTSz9vYdM for ; Sat, 13 Jun 2020 18:13:56 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p7.oit.umn.edu 49kth46gTSz9vYdM DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p7.oit.umn.edu 49kth46gTSz9vYdM Received: by mail-il1-f197.google.com with SMTP id q24so9258652ili.12 for ; Sat, 13 Jun 2020 16:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=Lp/57Kv3gzuXj/K9oQ77nASFzku70Zj4jK0Z7RozDsE=; b=lfurDX56hYBZrhdFYqEBnv2irvi2WRAzXzjIzOMzTNHuv42xHT5JVvBul2r6yRZfSr Cedk/u4yLdw8aRqEc/y4ItmczY/Wy46YSJdJrRMiyu6axMe091p2oVRathwkVLAjctph O1ryAN6KCqcJBCUYQiS5rpomqGicoXiT0GBMpThSYx8h/WfcepNjKEwEdueyxHsiT/QC QuMW8qQhASGbepJxBMeb2/E+/u9MHhAnP4kSZh7r1eGnqZTnwEm5ywzhNHk5NVpJQ75p aeacfU6DR3UAp/DccV5MCqEE1fH4GmLxOcOkkO/DPszNBMyGWO8UrRz2Jk+okWcCDdSo lqPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Lp/57Kv3gzuXj/K9oQ77nASFzku70Zj4jK0Z7RozDsE=; b=ZFSA/+Qf4wegxmFwM/+bvJv/x312Z4UJY0DctpqucdTr32OBiRINPtodk8N1it1j6u DhZQzc+TeMgE62HNqGvIUhNjtiNN4YXveFvss80RFZv24CXD0gB8LRbGZWkriwzBbOxt H4NW4NFAMFjoAJd+pOlksd00aj6vs6jKNDQBJcK6wInGi+VBnJ5Uxbc8gTV7aIxQ+ky8 13dGQFY7q2cFd/RfkfITXEb87DU86yupBuf4S6E05ntmgLxjX0BsasWHAruen6Q2PZsP pzEyaLLaGt46TayQ7UjCxZQUAN+TOXcmJAmKlwGzHlT2ukRIpBzXtFP577F79xqH+umI Xt9w== X-Gm-Message-State: AOAM530n6PqKVgxMMG40p2T03+f10+NZhwC4UPyOtsUbZAXYUd/HV18J QS2jZVLQHXWNQUikRgM6adkXmYPIcB2xDrwN1l2l8iqDeU+lq59S5mef7j3M4JhI8CBISbsQM12 BgjNXs+zwkFdYXmjEryCGZ9bgj9ga X-Received: by 2002:a05:6e02:ef2:: with SMTP id j18mr19983908ilk.69.1592090036463; Sat, 13 Jun 2020 16:13:56 -0700 (PDT) X-Received: by 2002:a05:6e02:ef2:: with SMTP id j18mr19983882ilk.69.1592090036227; Sat, 13 Jun 2020 16:13:56 -0700 (PDT) Received: from qiushi.cs.umn.edu ([2607:ea00:101:3c74:4874:45:bcb4:df60]) by smtp.gmail.com with ESMTPSA id b8sm5368985ior.35.2020.06.13.16.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 16:13:55 -0700 (PDT) From: wu000273@umn.edu To: kjlu@umn.edu Cc: wu000273@umn.edu, Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: rockchip/rga: Fix a reference count leak. Date: Sat, 13 Jun 2020 18:13:49 -0500 Message-Id: <20200613231350.15504-1-wu000273@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support") Signed-off-by: Qiushi Wu --- drivers/media/platform/rockchip/rga/rga-buf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/rockchip/rga/rga-buf.c b/drivers/media/platform/rockchip/rga/rga-buf.c index 36b821ccc1db..bf9a75b75083 100644 --- a/drivers/media/platform/rockchip/rga/rga-buf.c +++ b/drivers/media/platform/rockchip/rga/rga-buf.c @@ -81,6 +81,7 @@ static int rga_buf_start_streaming(struct vb2_queue *q, unsigned int count) ret = pm_runtime_get_sync(rga->dev); if (ret < 0) { + pm_runtime_put_noidle(rga->dev); rga_buf_return_buffers(q, VB2_BUF_STATE_QUEUED); return ret; } -- 2.17.1