Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp725784ybt; Sat, 13 Jun 2020 20:29:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysXbaoqVTd67lhbOJSEvjkJZIHzHaTjLyAsEvg782CqORVRuSy96F5o9jSodS82MX+Klk8 X-Received: by 2002:a50:e08c:: with SMTP id f12mr18302987edl.233.1592105383126; Sat, 13 Jun 2020 20:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592105383; cv=none; d=google.com; s=arc-20160816; b=esFLF/aM+oHjBgp67hABkHsiancjTAs50OKVQW2Btgog9rG2KtALE1ZDM9Lg/kidaK noggQnQJGl9G+2IsTNsC57FRAGDAj1K0JTbHoDznDW3Wv41+DegdDlJy7dETXQQznWGQ 20OFtx2JEe+LhhzhoX+LSoRAUsOXEmsBbe9HzXu5UhJMzz3sxkpNLIvKjReOb2Q+0PQH Lxng83PYWUXbA1PDlzQJJz2ziOFeIg8Kh9+ARGQc4Ptg20NIylCvtzqj43iHPhJ+oS8f W2sovKvQXpSStGcFm0126oGQR4ERl3Rw3AmopiDwLI94hf2mI/VBndEOkP8aLR4kw6gg TlIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter :dmarc-filter; bh=trMCJ61FldcoujsZIY8Wf46yXCeSnen3DQpQ/YLOJjY=; b=yGlFGIBiAUlfFMdj1sYKaPxNVSyIc/vjM1VxWZQDFLrhYStRXee4INQvn+jYU7GVgM xuMFH7xrbe3Qol6YmW5fSwkTlVV/VbLF+OPhUVQd2sqHRLetcYwkKKR8NEjI1P7fG27b xCEBT8rLRg1Ky9A6N19Lj+7wY/wMZbPQnnge5XB30IPe1Bx0KmTbm01kGI+nKv0vxkzq yCVE9kxbA9uiztmEBWxTQfNQi32auVS4rronL1T2B8Xi8Gf8dV8BxLPr6kXB8RLFT5rV na41MGf5xnkkmzf0dtxklubtozdf94K4r9+6r7L8y5LNRl3DLMB+aOgjOE9r/Eg4m7j7 1hxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=PMV4p27q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m23si6035664eds.530.2020.06.13.20.29.21; Sat, 13 Jun 2020 20:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=PMV4p27q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbgFND1K (ORCPT + 99 others); Sat, 13 Jun 2020 23:27:10 -0400 Received: from mta-p7.oit.umn.edu ([134.84.196.207]:41530 "EHLO mta-p7.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgFND1I (ORCPT ); Sat, 13 Jun 2020 23:27:08 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 49l0JC3YHLz9vYlD for ; Sun, 14 Jun 2020 03:27:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6BeRyIp4uFe7 for ; Sat, 13 Jun 2020 22:27:07 -0500 (CDT) Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 49l0JC1g9Xz9vYl6 for ; Sat, 13 Jun 2020 22:27:07 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p7.oit.umn.edu 49l0JC1g9Xz9vYl6 DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p7.oit.umn.edu 49l0JC1g9Xz9vYl6 Received: by mail-il1-f198.google.com with SMTP id k13so9454106ilh.23 for ; Sat, 13 Jun 2020 20:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=trMCJ61FldcoujsZIY8Wf46yXCeSnen3DQpQ/YLOJjY=; b=PMV4p27qe+K63USGyKIQ9bcGu/GsoDsDqegA8UwSQZw0sv3KC59At/WZujXLw9ZsUb HcJryey5zYLoFYxvzv4U5dFXYsiMRj8Nc9C/6SQYiSSLClcKkFn1PKXhXGRYHnEIODSq mQ3OxdnirTx75iKHaZJVJ+YacjtCKIFqgzDeMNR6OKmKA/Y+Jw1RJ4ojB7w61h/4hY+y tePrA21qSLdtdIx48AicGEfPBBjCnN9KwLMgJ7xX+IoTH2Tt1Xc/CodBuA/aA4mFH4Mh JTAkSVUIsBNAw4wjUMhfSJjlaBNDJS5phngaN5khm8wawlumTEWTRUvwOv0yAoXWeQ62 /smA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=trMCJ61FldcoujsZIY8Wf46yXCeSnen3DQpQ/YLOJjY=; b=VAOcy9XVc3rEIbWvd4gzYE4WSbYEyFKMMjHLJDRfAlSn/Y/a9m9hgkA5DbR9cJ6Mx6 YTizXT8KsAnezr/bygDUXrt1zfDZEI+eTGlnIIW7EzyKkL3wqy0bNHgdZTUOD+viFPbE DhghyKVvn9PRqD9868NRIH+pGWRT8IDz0Y0++eOv4+AA9BkkEtrvXNNckUnd7dY71c6o h41bBeHCn9J51nBKDOE5Ag9/RhDG2QiRJ0YNioxPHxoyDeye11460/Tx8r+TaDDjLG5n N696MILz/clWxC3MdbcszQuLFqpl2J4DZ6CJuzBksd/c0tjpYOveqo5g3cWhgYI3AQTw 8ygg== X-Gm-Message-State: AOAM532+1gVF5huL2mFMAUwyvwZSEbNJ33Q3u2ogRbpT+ZI3S1NVg/dL Ef31SvXSmYJBuB2WI50CohJXwzfGvAHYTMNBWvM7j+YdSUrjljw4lwKC4kJRTWzAqYyRwzXaowL 9fpFMDO1zOnI7oLPjHjgpzUFs3dwI X-Received: by 2002:a92:aa85:: with SMTP id p5mr21225371ill.19.1592105226915; Sat, 13 Jun 2020 20:27:06 -0700 (PDT) X-Received: by 2002:a92:aa85:: with SMTP id p5mr21225364ill.19.1592105226772; Sat, 13 Jun 2020 20:27:06 -0700 (PDT) Received: from syssec1.cs.umn.edu ([2607:ea00:101:3c74:49fa:9c47:e40b:9c40]) by smtp.gmail.com with ESMTPSA id b13sm5654007ilq.20.2020.06.13.20.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 20:27:06 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, wu000273@umn.edu, Bin Liu , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: musb: fix reference count leak in musb_irq_work Date: Sat, 13 Jun 2020 22:27:04 -0500 Message-Id: <20200614032704.129010-1-pakki001@umn.edu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org musb_irq_work() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Signed-off-by: Aditya Pakki --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 384a8039a7fd..fd36a026bef0 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -2070,6 +2070,7 @@ static void musb_irq_work(struct work_struct *data) error = pm_runtime_get_sync(musb->controller); if (error < 0) { dev_err(musb->controller, "Could not enable: %i\n", error); + pm_runtime_put_autosuspend(musb->controller); return; } -- 2.25.1