Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp729814ybt; Sat, 13 Jun 2020 20:41:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0XI0PQ1MKTLfv0vJXfDpyX3dsBqQz899rtFsEow1ZwfYRGh6ocn93UYsIeWQSwio5pNVi X-Received: by 2002:a50:fd19:: with SMTP id i25mr18221154eds.248.1592106061623; Sat, 13 Jun 2020 20:41:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592106061; cv=none; d=google.com; s=arc-20160816; b=uFoy+4glkuVeIhL2w7rojA4wpfXZCTXCI6z72x4BMGil7/2Q0Yv5imQ5zyB54Xak2w 6KZVNSjOkhuZkG/klYC0oHss4pqxY6p/b5CLI0u40XtT+vgtW6Kb2wccX6SBtyQ389xG m91S5GrGQZsRvBdsnUUTb5eXupihS008s1BhEQn7fpzQGIy4SqfmleYkBjBBpSlDGeG6 tTLX1Dzrc6L6RB+80SWq2S0iarEsI28DGDz0ucg84lCdV86vpAyO+MpM6OqekrJEalI9 j+ldMdt0Sc3NPMCWJyzhfMb9RK3I/+umxSUQV+9AkgY9gSijFTnrn1+xGzo9c2FCbGIk QWkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter :dmarc-filter; bh=91lGP7Wm5pq1CQ7Bg1oytLRkqvicw3GL0Dm9LTiHqDc=; b=eYSRse6ZHs105cLnFMSiLjErILgeEIufdmN5I6mCn3XwHuO9SMoKZLI2D6mymLZyJM udw//tmz7mqG2sHAcawUrzOE8XlCsTV33Dha7zLGDJr2nZ6RA1tkMLTC3yKOZjLXwugI co8iNCiDZX6bpTWIrxu6xXZ+oDcTgC4qqQl37r21jcAkdhvyCSFGRsUP3Wjg/2oQaJX5 1KxtPv07+PDCu54CfTpy6ry4U/3G4J5FX56pM3PC6ITmNTzg/dExgw9Cd8sU3fMFeUBE tawLKqaS4j7wiqnRdOqCYLca+5E138Qf6wWrJkSiyDoM6zPfx79IayHmBtdmBqmbOfed KNDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=ct5nHHcd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a20si6832833ejs.229.2020.06.13.20.40.38; Sat, 13 Jun 2020 20:41:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=ct5nHHcd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbgFNDiH (ORCPT + 99 others); Sat, 13 Jun 2020 23:38:07 -0400 Received: from mta-p5.oit.umn.edu ([134.84.196.205]:44228 "EHLO mta-p5.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbgFNDiG (ORCPT ); Sat, 13 Jun 2020 23:38:06 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 49l0Xs5Y9zz9vHdR for ; Sun, 14 Jun 2020 03:38:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AbV1UIEpWM-p for ; Sat, 13 Jun 2020 22:38:05 -0500 (CDT) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id 49l0Xs3rP7z9v90G for ; Sat, 13 Jun 2020 22:38:05 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p5.oit.umn.edu 49l0Xs3rP7z9v90G DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p5.oit.umn.edu 49l0Xs3rP7z9v90G Received: by mail-io1-f72.google.com with SMTP id l204so9027589ioa.4 for ; Sat, 13 Jun 2020 20:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=91lGP7Wm5pq1CQ7Bg1oytLRkqvicw3GL0Dm9LTiHqDc=; b=ct5nHHcdYMCKCiWoBbUARbNzAur3vf0CYMr+Rvpk0MrDZYxJXqT1Owpf18E0yET9Gl zkiV7FxQUV0AP1NEvResL1EywEJvMnUnfkx7f6EvX3i4d4D7VdDmtL+7N1eHH1AntDJ2 taWgC94IiGcHWkydgK4S+S1gNzCV6oUWz80INIJnPil4cYWu3E4m8ae4w+Ky1B/o03v9 2dSoMjp11+Qx6JpbSG1fDyhgxwoG9D+FIeI7XCNqMUeEQi2MuPqn2+psmrZRxxHtGa7T LPF6jzXGQpAiFl5/HS1DJOiNX/szqIeIOwuZeGsbMc/5xico7D21HEjY45325Okz7gk2 MhJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=91lGP7Wm5pq1CQ7Bg1oytLRkqvicw3GL0Dm9LTiHqDc=; b=B/9UHuqoSGr8o7MWPrV4E8ZRsXeDU6mi0l6ca5/82HCK+pJcm0IK2dTm3HeoEE3zCK 1yZFuuU3OoVyj1mq0yUP0lomqc8v914hfTQBKs2sBe2vbI2ZNDJZGkYhCVFNEUHfOZsN o69UXUK4D2omuNoGq6GzZ96anPt1ZqkAlBcuLglOh6wklASmu7SVMewTAHJTXuvGfxrZ XWBMEAgqNqikc0NL13k1N8etcU3SATREY8IQ4CO347eO1gUlCKnadcndi0Q9u4kP4Dhh iPkbMpvLKQ/+xpGX8rCRyv1qkBhxEzuygkn3F7ThQ89ny0TeOsY00xZgYrH/OpwwLoJ1 RO2A== X-Gm-Message-State: AOAM5302cvLrnzwsr/fa0HavYJ87W2COKcNIX3T1R+b2NU0riPMfZdOf IPIO5rYTupnJLPsdOVjbF/HncJLKxaAYCgoa0HVmhuF1Ijx7Ay0mkz3iqt3HYMpNtq0xCruNRBU ViJqbM9eQjJnIsWs+2AkCPxtktjAq X-Received: by 2002:a92:a1d1:: with SMTP id b78mr20450142ill.164.1592105884955; Sat, 13 Jun 2020 20:38:04 -0700 (PDT) X-Received: by 2002:a92:a1d1:: with SMTP id b78mr20450136ill.164.1592105884813; Sat, 13 Jun 2020 20:38:04 -0700 (PDT) Received: from syssec1.cs.umn.edu ([2607:ea00:101:3c74:49fa:9c47:e40b:9c40]) by smtp.gmail.com with ESMTPSA id k185sm5862775ilk.16.2020.06.13.20.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 20:38:04 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, wu000273@umn.edu, Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: (ina3221) Fix reference count leak in ina3221_write_enable Date: Sat, 13 Jun 2020 22:38:03 -0500 Message-Id: <20200614033803.129922-1-pakki001@umn.edu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ina3221_write_enable() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Signed-off-by: Aditya Pakki --- drivers/hwmon/ina3221.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c index f335d0cb0c77..9a3b46160de1 100644 --- a/drivers/hwmon/ina3221.c +++ b/drivers/hwmon/ina3221.c @@ -492,6 +492,7 @@ static int ina3221_write_enable(struct device *dev, int channel, bool enable) ret = pm_runtime_get_sync(ina->pm_dev); if (ret < 0) { dev_err(dev, "Failed to get PM runtime\n"); + pm_runtime_put_sync(ina->pm_dev); return ret; } } -- 2.25.1