Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp736697ybt; Sat, 13 Jun 2020 21:00:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza5DD8QIo5F3G81RWviRV4ZboKjPZ6otoquOzflsxF+6bGAUovBHiLEeyaIay248KCZ0ld X-Received: by 2002:a17:906:eb0c:: with SMTP id mb12mr19568084ejb.378.1592107258954; Sat, 13 Jun 2020 21:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592107258; cv=none; d=google.com; s=arc-20160816; b=SzWHfLq3GPqkqWwVYGOW3EX80+xvceUp+z6mcwpb2iBjMY5Mp/CCE0H86+JZZvagpo +hZIvWeuRyJIKKvujmi05pr3oP70t7hhgIJwelZu1/Rc3Te+CM8LAzv3lvtn2KX5lbr9 kXEm7Sajjw+wTvvjkdxB6L8nhLGKyAq2foyUjAGi2eGf7R4TZ1HajGYnp7wzeIekOIaT TUIjlxSLMo8sr9viONEB0M1Xb0tgCdVyr+aLaQIx2DkHdDZgh82L0iA4NGAZg1L2tv/Q yAuW0a3I1S/0R6XqiauEaYZM5EqVkfDOHWZykwHqd+FZpEsk6ZVLpPU/Q9NFJMHM/lR+ cM9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter :dmarc-filter; bh=hhIKBGmqbJZD2/EwCInV9JueuS4QBg/TzIdZhuT04so=; b=vo+XNfNPvsMsxrnAg87riznkQh/+CwG9IKzGcRjjiV9WhRveTJK//jT7BLYGBS3IeR YwOBO0Bolo7xw4rQi6X7ffwvvebThPiCaMC4SJlQq8myT996wAiOr5koG5Q5bvexcu5P FgAg4cJj9i6estg6gZz7nOhkmbVpzRmchbZgUOpzl0NAZB7Q8pj/h/NN9AZfjyf42yo0 HQdkvHHuZOr67bX8Z5dgQ3ZdSYyaxUi2O7H9bUryr4T7B99/nBSyEJ2LtwUrfRCVJAK9 TkXjsMUedM6LztydHvN9jfzXr//nmAudswEjuZXMxpV9OxwjgW+4/K2aEXuFjMThb2k1 5TMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=V82Y7IxY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lb19si6392261ejb.295.2020.06.13.21.00.34; Sat, 13 Jun 2020 21:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=V82Y7IxY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbgFND6q (ORCPT + 99 others); Sat, 13 Jun 2020 23:58:46 -0400 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:60842 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgFND6q (ORCPT ); Sat, 13 Jun 2020 23:58:46 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 49l10j2Syxz9vFJ5 for ; Sun, 14 Jun 2020 03:58:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16zizOvEtIlc for ; Sat, 13 Jun 2020 22:58:45 -0500 (CDT) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 49l10j0jSWz9vFHw for ; Sat, 13 Jun 2020 22:58:45 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p6.oit.umn.edu 49l10j0jSWz9vFHw DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p6.oit.umn.edu 49l10j0jSWz9vFHw Received: by mail-io1-f72.google.com with SMTP id c5so8963518iok.18 for ; Sat, 13 Jun 2020 20:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hhIKBGmqbJZD2/EwCInV9JueuS4QBg/TzIdZhuT04so=; b=V82Y7IxYt5myDvWrWYU85kEaDVnykoiHnRjZw7XLB8ovpaG/UkQxDZeiDmtdvpGZ8E vT+HtI+Hjd53me5vLAJC11ZZc7vcS9N0F5n6YQbWAAWDMYAmVp5u+8taNSGuhrLhw8NH FcPiV7tpfC8w0B2RJlwmZR5uFwiQ0qHpOKa1VWb/Rbr0YeXyL8piFVFOhuv6KpRf99gn XHo0liTiY7FexoqmECUELjTguzUxwH5fOQ47eDdlRYf/RdGlY3QK+P/CmLOIuov0W2FK aD+NZO/qfuV5XxPnURmpcT0Iw9xSZ4vhMpT8koIzvyM7E5Y2kyXwf0Wc9fwJRJWZ5DQ1 tj5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hhIKBGmqbJZD2/EwCInV9JueuS4QBg/TzIdZhuT04so=; b=Kozxt78UqKdqsWj0IkCOk1TpsleiSd29xHSmxLHGC9QOZ9izNzCMvEc3Njjcqd85Ku pAyFN5Hz0hy/72NDOvN1L8Q+Kflb19w9aHLPXbBiQevLMeHtCjMbXActVqeUk4ejWUKv MWAy6nHvSKIQMSXblwJb84ju83PCEBDBGlS96vWDBQ+nVnv7nYLr7L1grcVAh8LlLMNY Pti3HAIq1RQt/H6WajqtU7HgkMGFgth/r9qMpSP754wDI4quyAnFQkMW1RjaqGAYHU86 Nkx9oUxoogXnkTdXK55m+Sq4wwSNiANqASrwFhKoar0bgWn5dI+slHPznPnw6Nb0KNr2 aI3A== X-Gm-Message-State: AOAM530XXsh8N6ptbqcRWDiDErRlM4Bh01104lBwoc2PERt5Jd0VZ4yb Hwq9mEpU4A2/MYG+w0CU+3JlTwuPijoeW/YPwHoKuTTBYidNqP3IrMaCXzJzflSktOHv6us/nb9 zT9YyUKFMMizCKrJnbi2yMkukvDTR X-Received: by 2002:a05:6602:2cd1:: with SMTP id j17mr21245439iow.69.1592107124753; Sat, 13 Jun 2020 20:58:44 -0700 (PDT) X-Received: by 2002:a05:6602:2cd1:: with SMTP id j17mr21245432iow.69.1592107124542; Sat, 13 Jun 2020 20:58:44 -0700 (PDT) Received: from syssec1.cs.umn.edu ([2607:ea00:101:3c74:49fa:9c47:e40b:9c40]) by smtp.gmail.com with ESMTPSA id i10sm5656112ilp.28.2020.06.13.20.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 20:58:44 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, wu000273@umn.edu, Hugues Fruchet , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: st-delta: Fix reference count leak in delta_run_work Date: Sat, 13 Jun 2020 22:58:41 -0500 Message-Id: <20200614035842.131456-1-pakki001@umn.edu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org delta_run_work() calls delta_get_sync() that increments the reference counter. In case of failure, decrement the reference count by calling delta_put_autosuspend(). Signed-off-by: Aditya Pakki --- drivers/media/platform/sti/delta/delta-v4l2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta/delta-v4l2.c index 2503224eeee5..c691b3d81549 100644 --- a/drivers/media/platform/sti/delta/delta-v4l2.c +++ b/drivers/media/platform/sti/delta/delta-v4l2.c @@ -954,8 +954,10 @@ static void delta_run_work(struct work_struct *work) /* enable the hardware */ if (!dec->pm) { ret = delta_get_sync(ctx); - if (ret) + if (ret) { + delta_put_autosuspend(ctx); goto err; + } } /* decode this access unit */ -- 2.25.1