Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp782898ybt; Sat, 13 Jun 2020 23:06:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwY5Qi05Jh/grAHzwC6X31NwPHIh/hmrDO/AX1YNkitd+0cN2OARbHE9UFbuWY4/mSiglcT X-Received: by 2002:a17:906:e298:: with SMTP id gg24mr19900002ejb.120.1592114772091; Sat, 13 Jun 2020 23:06:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592114772; cv=none; d=google.com; s=arc-20160816; b=JTA0rTEZyf4jmbmrLjVH35fkE3gzm35Cd1k05oAqOExc4346p7p5ZDKztr15IofxLd NtseaMIt8bSopzA6rK/iCRGtzuRnrVJ2f2C48774Y1g1Jq5fdp80wXctsCfznBXq1VLF btumyhrBIF5QqZ0s8yNStKRfyfj2sR8rTMVxkXY7dFfTxFVUPXOzKe75pAhk9WoRtWUM RVWcyQtbNPJgKR3ppZD9n2v4/2Bbb+KeI3JAu1vlEqZgg35qcg+AlKbyWc4M/1gM/gij xaMZFr+vKG6arL1VWuK6wjRMOhecZHKEOz17CRmCu0olMfWZxQ9WPkATaW8AuddNQxac Wocg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ye7JsqJTDgMj8bR7y6mPzZYq5L0M3OzoWaqqcC7wuP4=; b=vEi8zyXn0fVbardET5hVxwjJ0IHPepd2CL/heCmsuNhk5yDNxy/2QBwUA4TTMmrCn8 V/2eJm4T5blq2SD2fBT7wEswrh8rj+UyZrzHubNv52Y93PFBaauJwEY3Mn2OAQc7xmE/ nzENnE5Fk3zYu0SKcHjHROUlsInBy67pryMCtkwsg/E+Pvq+e8pbkeQj9Yolkm9ldyuj jdXe8pkE0MMOJWEzTEJ6Q3bI6kvtlgKZVar5qbIoGHjUidTaPLuJ+09WW/gVr20eCSrv JqHb2bkS9K8j4XGrYydhWwXSxqYGsepJ9dN0PNvAg7RbjJOiIghSd5v/ZaRcv7S///xJ XoJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="g/WYkX3O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bn18si7262698ejb.82.2020.06.13.23.05.48; Sat, 13 Jun 2020 23:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="g/WYkX3O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725822AbgFNGEG (ORCPT + 99 others); Sun, 14 Jun 2020 02:04:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:38124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725265AbgFNGEG (ORCPT ); Sun, 14 Jun 2020 02:04:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DCFD2068E; Sun, 14 Jun 2020 06:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592114646; bh=gjtaa0VNN3qmgf1nzWIgFU7LxaP664Sux0mY1hwad9U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g/WYkX3OKj70Bo1wYRWeIfvijunID8FYXL962nn9JUwQO4GcsVykMV6BRcTWuYLIK +HFcuHsMMiCN7oYg9PwLIk9zuHUQkcO4zT4S8/4idvaK4Ger5FD6IfYInHbumF5P0e bIHRVzAsduxwX+JAS8VsNwM1mFr/3W5fKSwbM0RY= Date: Sun, 14 Jun 2020 08:04:01 +0200 From: Greg KH To: Jim Cromie Cc: jbaron@akamai.com, linux-kernel@vger.kernel.org, akpm@linuxfoundation.org, linux@rasmusvillemoes.dk, Jonathan Corbet , Will Deacon , Andrew Morton , Orson Zhai , Petr Mladek , linux-doc@vger.kernel.org Subject: Re: [PATCH v2 01/24] dyndbg-docs: eschew file /full/path query in docs Message-ID: <20200614060401.GA2608744@kroah.com> References: <20200613155738.2249399-1-jim.cromie@gmail.com> <20200613155738.2249399-2-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200613155738.2249399-2-jim.cromie@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2020 at 09:57:15AM -0600, Jim Cromie wrote: > Regarding: > commit 2b6783191da7 ("dynamic_debug: add trim_prefix() to provide source-root relative paths") > commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a relative path") > > 2nd commit broke dynamic-debug's "file $fullpath" query form, but > nobody noticed because 1st commit had trimmed prefixes from > control-file output, so the click-copy-pasting of fullpaths into new > queries had ceased; that query form became unused. > > Removing the function is cleanest, but it could be useful in > old-compiler corner cases, where __FILE__ still has /full/path, > and it safely does nothing otherwize. > > So instead, quietly deprecate "file /full/path" query form, by > removing all /full/paths examples in the docs. I skipped adding a > back-compat note. > --- > .../admin-guide/dynamic-debug-howto.rst | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) None of your patches have a signed-off-by line so they can't be applied anywhere :(