Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp803450ybt; Sun, 14 Jun 2020 00:00:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuFG+pX6BvfyCEl/IJOyGv4zTQZ4teNCjjv/eAhNPvq6bQwya7bd943TxiT/q8bMbhNMKr X-Received: by 2002:aa7:d28d:: with SMTP id w13mr19073224edq.336.1592118023483; Sun, 14 Jun 2020 00:00:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592118023; cv=none; d=google.com; s=arc-20160816; b=yGa6s7oX1flu0EjVmx0C+HjYcmybXXhJQdOmlEWcx8W52OC2Ewbr+6C1D2lhBjZwZM WW5mjJfMrSsTzzTgiL2q/ghn2bn8M3sPuHKrGhwv6NGF1sd1uuYNX6IN9qQfCUHi68Wc tnkjuITG1eML0vVJYBe2Z1iUR7WGa7njJoQIS1sSRArVDS/nRc4WpPiX2tEh0UV4v/K1 gO1tU74xJ3IRHN9oz/9M9N4X57Jw/xXfiUaGvCCsMO/355M4KiojjeDFKh8xouJyhmKe E9gTs0RBs/xQyQm53ZZft+Lh5IcGUquoWZyV1MOG1W9rXvRjx7JwIz3LipocNYnz3/Xd UqWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=TpliVuQU/7sLPsVM57NGaPTp0yUaPg8e9YE17AlDXcs=; b=IEts3fl9u+OPFXlbAiwvyTgt4tMTfongDrmxyuYZmZQZIPl+yjnoBVEElfXNFzfky2 5Tckq4eIg6cqlOeBZXv+43iVbXDH6lj5g8WTbACydfpoXp8wZngKNpDzuLrym2twac6D tf+rR20CllghCYzj/Yi0EBoy5/LEkMsPvV9k5MVCyTlpn+fF8lF8STF2lNa+gJ1I7p9X JTsFOZGajjUdAvnl0RGDJTyrmgKXJi5Gj7DUiaUAmc10U2dDjKBnEdEqePbvr0lVp1I0 7Nnij8ZMMxoPIMd9o0VjROcTZFfkUdZSMDL15y0hdzerqGt7yitx7PFKQsYAb3/K18sP SynA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ruCs9b9Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fi13si7181641ejb.436.2020.06.14.00.00.01; Sun, 14 Jun 2020 00:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ruCs9b9Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725822AbgFNG4U (ORCPT + 99 others); Sun, 14 Jun 2020 02:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgFNG4T (ORCPT ); Sun, 14 Jun 2020 02:56:19 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0F53C03E96F for ; Sat, 13 Jun 2020 23:56:19 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id c75so12456224ila.8 for ; Sat, 13 Jun 2020 23:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=TpliVuQU/7sLPsVM57NGaPTp0yUaPg8e9YE17AlDXcs=; b=ruCs9b9YlQlECerNcDTwY4ZAksDlHdq9kuYVhDkV1NCpUcGPSMcisPqw3OyZY3+xSC NLssw50CcD5BMG8oXmMvOPUqfMBZLjAKU0hslN8gofADZ7S9K2U0cq9taQRBjgKNYxIb D8NpUHWPP45WH/HDRaGr2larfLEPRyJ+ymOBgAMFwztfX5iDrwrV9YZkBAaAgDwBHyPB A1klb/6XOXwF84xLfHqjWEvTFKKP6nRAp/eIowms/lN31Wi6bdyMH2nBbz2OvbCtGJw4 TExRz7f+x1Co/KwqSzmIMSa1ruWhttvhNsmXAGBoLh/QA70RNUuAFpo4+1QzBt0sOg4Q OtDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TpliVuQU/7sLPsVM57NGaPTp0yUaPg8e9YE17AlDXcs=; b=DBoiVEhpPatEt9TeZGCL1s2mg/f50JOhEw4ZN5xS15DunSGsczagxzXKg+rZgRYpz6 XTpdlrZ3vfNNMQYTUIxUox+W6tRsZBgBypdho9I0XxG4L3SvnAD6V8j1XbA9CyN9Dm2z N0QbJes3vo3k9l07srn1ZTts3xH+cQaIVnWX8g6vegX1JhKCDX7HIE5bKvNPKAoeFIbv 8zFYiQ93DM7HAQzvV2vIomltrU8rfypsZYgmmXC+CDnosAz6Jh3Z87oR1a9oIhEwidet QA2v8PpvA2WtuPdI91uhZQy1dYlz6P+9goxTdedkR0R1TFNpxtNUTT7L0dfZRATTO2ha n2pQ== X-Gm-Message-State: AOAM533voDfhLDS0ZDC+YAsLua2jD9stNezGSS8mflHPsOmwLaGUhzCI r8bZBIEQqED5gM3h68WCa/GN1yGfzhM= X-Received: by 2002:a92:8b0a:: with SMTP id i10mr19990532ild.245.1592117778866; Sat, 13 Jun 2020 23:56:18 -0700 (PDT) Received: from cs-u-kase.dtc.umn.edu (cs-u-kase.cs.umn.edu. [160.94.64.2]) by smtp.googlemail.com with ESMTPSA id c20sm5823570iot.33.2020.06.13.23.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 23:56:18 -0700 (PDT) From: Navid Emamdoost To: Eric Anholt , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu, Navid Emamdoost Subject: [PATCH] drm/vc4: fix ref count leak in vc4_v3d_pm_get Date: Sun, 14 Jun 2020 01:56:11 -0500 Message-Id: <20200614065611.69502-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org in vc4_v3d_pm_get, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index cea77a21b205..bb03c1d1bb4d 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -135,6 +135,7 @@ vc4_v3d_pm_get(struct vc4_dev *vc4) if (ret < 0) { vc4->power_refcount--; + pm_runtime_put(&vc4->v3d->pdev->dev); mutex_unlock(&vc4->power_lock); return ret; } -- 2.17.1