Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] usb: musb: fix reference count leak in musb_irq_work
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, wu000273@umn.edu, Bin Liu <b-liu@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200614032704.129010-1-pakki001@umn.edu>
From:   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <40e47a62-5359-4396-7f52-fb1a3cfa9d76@cogentembedded.com>
Date:   Sun, 14 Jun 2020 11:51:23 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200614032704.129010-1-pakki001@umn.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14.06.2020 6:27, Aditya Pakki wrote:

> musb_irq_work() calls pm_runtime_get_sync() that increments
> the reference counter. In case of failure, decrement the reference
> count and return the error.

    Again, *void* function, so no error returned.

> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
>   drivers/usb/musb/musb_core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 384a8039a7fd..fd36a026bef0 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2070,6 +2070,7 @@ static void musb_irq_work(struct work_struct *data)
>   	error = pm_runtime_get_sync(musb->controller);
>   	if (error < 0) {
>   		dev_err(musb->controller, "Could not enable: %i\n", error);
> +		pm_runtime_put_autosuspend(musb->controller);
>   
>   		return;
>   	}

MBR, Sergei