Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp857793ybt; Sun, 14 Jun 2020 02:10:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqlGgA+Wz3cQ9W45Xvo/iPlRmiCoJ/TjN/NNunVY9p1IIj5w0RGaT/M1M8byidwe969TLu X-Received: by 2002:aa7:d74c:: with SMTP id a12mr19291138eds.369.1592125819988; Sun, 14 Jun 2020 02:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592125819; cv=none; d=google.com; s=arc-20160816; b=wgknJTP0t/5glkH4LEhou+nmLZYfJ4zonSEOkw4eUqzMrOp79gHT7rUZ+0sLzNEVBB KRSxYsGeH/lxX0W1JyCCKzbw4HZldvQ841zqZDH25kYhYwrxrE15+Vq8Ms4qtErWWjXi AXicjZLS63RJ7XMoO3yCG+HvnMZhTq41YgqzWQl0wyoWh4jc9dvV/CmhU1AW0Ey2vb3w FAURPvRbTYEpENstMTZbDLSwmtBM9NICELJEE3PqLR/UldC6I9u5RBT4f4a339qQ7kHL rTWr9b7kySsNzV0iLeeM3OLgCanSeoLcQ3LR51dSI69WjRuwV+VhGDJZKAim3n0K737z rzyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=cz6Ax7GhVzAI0ZDYRAKoQ3wi2wpcb/9HWiQ/INFVpGI=; b=ltVSuhWgJU6+pRgETRQc1SezlhJl2VePmXxdi1GAiYAYjIvunpx4sUqUsvrMC9s9OR HL4bCXvawNHcF2ti6PL4RELASDOyCcWNx/GFYyVEozz0BS08HdV0KpS8/qyGQbQSQPPa Q7+umB72X3pdPzP6fX0Ra5n4HHtKQBVVwt0MGzEzhlsI8SCq9obYumdfN6Lqb3vE9TMD 6GMGOIm3J54Di8J/1zNgEPUeyAisqpD7MiLwIoxL/Aqwjc+f9Oz9xV5LotAhT0RAP/ac akAIHCk56AhDaxVP3rVF0JEgxtiMAP5KY3Lfut4jf8FEybfwJXanUZaVq1fhB+2kzjTq BWGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MwzA4lWm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm22si8701505ejc.535.2020.06.14.02.09.56; Sun, 14 Jun 2020 02:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MwzA4lWm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbgFNJIO (ORCPT + 99 others); Sun, 14 Jun 2020 05:08:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:40390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725265AbgFNJIO (ORCPT ); Sun, 14 Jun 2020 05:08:14 -0400 Received: from localhost (p5486c990.dip0.t-ipconnect.de [84.134.201.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 683BF206B7; Sun, 14 Jun 2020 09:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592125693; bh=n3wKxNIkrL79MBfu8VNibHzqLBHsYDEtzNsdn1+bG30=; h=Date:From:To:Cc:Subject:From; b=MwzA4lWmdKlzDuvDp/rQWKyGX/B5LpuRztl0h03Bnuv2BFvNQccvI8zDaVX6PhVYP OqSYTbStdNJpcix67C2skZ9kGELNieh9zTqtxXtrbgpTeY0G4HlA1xtEgrB2ctPH8j V30F3m4bHOiVpz7kxrx/CKUjmDdbAcoMK+Zy8wWo= Date: Sun, 14 Jun 2020 11:07:51 +0200 From: Wolfram Sang To: linux-pm@vger.kernel.org, "Rafael J. Wysocki" Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: RFC: a failing pm_runtime_get increases the refcnt? Message-ID: <20200614090751.GA2878@kunai> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Linux-PM, both in the I2C subsystem and also for Renesas drivers I maintain, I am starting to get boilerplate patches doing some pm_runtime_put_* variant because a failing pm_runtime_get is supposed to increase the ref counters? Really? This feels wrong and unintuitive to me. I expect there has been a discussion around it but I couldn't find it. I wonder why we don't fix the code where the incremented refcount is expected for some reason. Can I have some pointers please? Thanks, Wolfram --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7l6OEACgkQFA3kzBSg KbZYyA/+PkFktu53VSUsaXjSYl3UQhAp3f9gxaeCTcak82twshL7bPkzKzW7mzPu EMkPt07vTWMlwl3kTclqzf0X3CB3nmTxxbsIkSUO1pUk2uFMSYew2zUpqGIKy7/J RTGiLarBS+uQ6IlFVQn5/CgOJFhW3NzEeZ6ArtyD4rdOWI4Zyp9Xeh+W2g/ElQnb BmDUv6rES6CpNNJitt9ZbcbgOKyDLFWwxIVFuAQCoqrsylsh13/A7+AfNfGP/biy X2mRo1L/ZfbDJrRdSUel/9eUm5KvFNabPZCKP7xiIlJwaQ2RbeDuowC+lO5Nj9Hf Vvd8LXdLOk1EDQ+kzGIXdJDThY+8ySBGvR06o5AJFYYTaocFKU6tEmsk/RVp+DXF J7EZkpYBTyxg5C7iV6C9EkD8+TicENFYpJupkYC2ggZPrgK4qDo1EhUvT55hCgbV C3yUcFqviNK9gsMPbJHfhoTW/XGSR62nBSdnZJYBzM36eXwNk01f1qO3eW60XO1m vetWZfFBbPNPrNL8hGHwl5+5SOeuCKDIxz0deo4ff00cfkGhx35qJGDrvEoVv6lr ptOzytwAjL+ZGaPbKHcQgGSDvY/7Zimsy2kuCn3KzV6p6KmIB8zscKENmVCPibSS AeW3s7q2kuALMdLjlfDTUDZtFKsvfyvLkMo7OJuyixaSwNYRhso= =CpY1 -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--