Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Jun 2020 11:09:50 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     wu000273@umn.edu
Cc:     kjlu@umn.edu, Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh@kernel.org>,
        Shubhrajyoti Datta <shubhraj@xilinx.com>,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: xiic: Fix reference count leaks.
Message-ID: <20200614090950.GB2878@kunai>
References: <20200613215923.2611-1-wu000273@umn.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rS8CxjVDS/+yyDmU"
Content-Disposition: inline
In-Reply-To: <20200613215923.2611-1-wu000273@umn.edu>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--rS8CxjVDS/+yyDmU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 13, 2020 at 04:59:23PM -0500, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>=20
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus call pm_runtime_put_noidle()
> if pm_runtime_get_sync() fails.

Can you point me to a discussion where it was decided that this is a
proper fix? I'd think we rather should fix pm_runtime_get_sync() but
maybe there are technical reasons against it.


--rS8CxjVDS/+yyDmU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7l6V4ACgkQFA3kzBSg
KbacZw/8CozQWe7U1m+g1iWgjOxVuE65mf+56wzqLkcKyULNknbdqa6A3cLA/BXE
MjpMsuLzwrfVw/KI4eMRvFaYdUE1hYx3UIiwQJNTW06ZvafZ+nmhijnB8xTMQ6VV
ZAR1biiz1Wd9xpaU4Q2s543Hn2Z0a/l4Fip4lZYuvmT09IRKJrrT6zAvNbeXla53
7YKsf0OmFLYUQEzjES7jVf/t9v0z6g9Iy5lTRQqki1VjZT1RspIlu+M2GFiIsT53
y+wbn2QNGCGHh23OrUMByPw2Ni8apZluLR/kKYv3n//+PCVDhuMT999VMuh/aJ9Y
w4dsxEyZdfwTpUgAZGGm8gLaxFYX0AIkJaqC3M+gy+sDc7ZkKNRtnc7DvBR5r7ax
wtbjONMGUsb0uu5q247hjFZsyTWqkl+5oJbkL8a77XODZ/2ppqSHjlzsay0mFwoA
1MsaFdxOnTTwZQSqSwLXTQ0sBsLuS//mAwVt1v4cykRydP1mIeAXiKSc0ezvWlo0
sOC6xh3snVbEH16jMy1j2+NzALqjyiOVNz81cttL9CyTjcpr+7jAzTYLoEKYAHcN
HDYROLWOg6z5RJ9kdpv2iPEF3XOvnkPT4xNkgkI1bl70K8gg4/B3iLtvF88kj7cd
32XVac17Ca6kejsX6PDCUw3bjWG6oVh7NeTWmESC/bv1lgot6xo=
=mHF9
-----END PGP SIGNATURE-----

--rS8CxjVDS/+yyDmU--