Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp871481ybt; Sun, 14 Jun 2020 02:40:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz41FAS/IkfkL260hr8vfPkaOOB+tIMlONrkzLz823qgpXZTut27CAqqU0Z4JvwYjkbmdHO X-Received: by 2002:a17:906:d791:: with SMTP id pj17mr20424210ejb.352.1592127641767; Sun, 14 Jun 2020 02:40:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592127641; cv=none; d=google.com; s=arc-20160816; b=h4s9SWcEIjN890Ox3ub987Wl3x3iGpOfNyIc9DMKtiMFw3PfMJx9jTfD1FwF2WImkv QM95w8H0c+ds/jEihrLZoVaQOXY7HcEjFpMPqEcmuyjIAGhL2cvTyD0clBguIwCDozyq iM+ROv8U9lpFwiBFalEDa2feJ1+qbJZ4tzWjhA4zZlfJFRpkEbtvqDeErWRdVQe9rW9Y Fv7jASFYvatZUjxEVAPbZhTfx2AaGKrj/AkKl0qHKTF18UDa7KtRwxaJu749r6hpQjLx xoii+oFtFPRgQ1f3fy7jqDjle5QdlZoP33qJcMU3jG/4E10waOQGpnhq8752Qz5esiwM /sRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=8tXQc/WVDFHU1D6BMNd3A7UnPzBYr0rqXTeXw+s9Gh8=; b=aIfIxju/xIA4rjhVZRK4n18V52y6c/n4Fr3qxi/JWQ2YGHXCs2Rbfp3J3by/FmDvsx iUKHah35BeqoK4zOJj6eOgfcUhBL2A8GK+QQ3PYLnOAnEYd5yqzYf34UP87/2OHcTW4+ SYa0POzilxu+iphEJqsakB438nGGfC39prk/4GLpaLDXvyoZRhxX+qEFjVho+7QSk44y XZ+Caqy4Yce7ZvlKOv7wMeh+htvNcaH9WVlZM1LmP84Ay/TpmOM5AI1oUiuGrAunIiIO 28N/hW9bTNHi9rdOTFfHDViHa5ieEtHTA2d3ChOuX+MrpN8smu81Tnb9yzJ/qShftMr9 PkmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jUYzgBq5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si6115982edr.201.2020.06.14.02.40.18; Sun, 14 Jun 2020 02:40:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jUYzgBq5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbgFNJiZ (ORCPT + 99 others); Sun, 14 Jun 2020 05:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725265AbgFNJiZ (ORCPT ); Sun, 14 Jun 2020 05:38:25 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079EAC03E969; Sun, 14 Jun 2020 02:38:25 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id e18so6270834pgn.7; Sun, 14 Jun 2020 02:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8tXQc/WVDFHU1D6BMNd3A7UnPzBYr0rqXTeXw+s9Gh8=; b=jUYzgBq5yjJ9sml2lhf7He/Kkm5ndcx1FwzrL/94mH4Xbj3ESBqN7UDcEAjLSvKdLl 2R9mBKF/yI5xznVVujwnBINtJylZPHcPoPGGq9/28L2JAElQ0NuELJTjdlUSzZAFPJk/ 9sCzv5pGcQjoVZjPWc0mv+0J81y6JeXWK3E70o9HfqCHXSjwdZeXq6LuPuowiAuj03KZ TOwbavHUB/IgfLPqXxEcJgPQinhM/dfGCm4nsV0ehkSNQqRuNkzoWbkTTdfU9Z0NIO6J HYA8zC6HeWqErL5VFCXNPPO4udOGaOFjLJuqB9NVsARBwrZfC+y6RFmvrbo8w5UOQGat VNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8tXQc/WVDFHU1D6BMNd3A7UnPzBYr0rqXTeXw+s9Gh8=; b=F83ASZRvq0v4d4KigvL/axh+wHZ3iGkXLdZfWoK894vWINWoGyXhPVUc13WsggglQh th4oPI0ceaLw4X9CeZPdr1jWUIu5amSd0KK/ayPF+a//vxUq3fubjQ44+GOXJVxO01/K GzcOqQ8b+dXdiSzn/3FbRs46s+non2/Xf0xPiT82kH81CdOfB2pKPzytX4G+Q2I/6AVd f+V+Y1XqKURPyGNx16ZnUY4eU8+a9vs+oPe0qsSAYbrQe5h3d17ub6PfQJW5Isr3WlzD wmjfNzGGoY+KgUQnX3Y361YE++uu1lSW3mrxHrBHGB4E3+8YlV+W4qyGadhFbB1cQY0D rl8w== X-Gm-Message-State: AOAM5303CY/Wnz2iwxJN4EOUCAIX/T/Y8G/Sm+dYCTshzXPX7ICnX5lN IQ1bT4G9Slfn1K4UEBYBjzlZ/ZFO X-Received: by 2002:a05:6a00:50:: with SMTP id i16mr18232231pfk.25.1592127504155; Sun, 14 Jun 2020 02:38:24 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id z140sm11313968pfc.135.2020.06.14.02.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2020 02:38:23 -0700 (PDT) Subject: Re: [PATCH] hwmon: (ina3221) Fix reference count leak in ina3221_write_enable To: Aditya Pakki Cc: kjlu@umn.edu, wu000273@umn.edu, Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200614033803.129922-1-pakki001@umn.edu> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <17c31866-475a-513d-8147-c56a268226db@roeck-us.net> Date: Sun, 14 Jun 2020 02:38:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200614033803.129922-1-pakki001@umn.edu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/13/20 8:38 PM, Aditya Pakki wrote: > ina3221_write_enable() calls pm_runtime_get_sync() that increments > the reference counter. In case of failure, decrement the reference > count and return the error. > > Signed-off-by: Aditya Pakki > --- > drivers/hwmon/ina3221.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c > index f335d0cb0c77..9a3b46160de1 100644 > --- a/drivers/hwmon/ina3221.c > +++ b/drivers/hwmon/ina3221.c > @@ -492,6 +492,7 @@ static int ina3221_write_enable(struct device *dev, int channel, bool enable) > ret = pm_runtime_get_sync(ina->pm_dev); > if (ret < 0) { > dev_err(dev, "Failed to get PM runtime\n"); > + pm_runtime_put_sync(ina->pm_dev); > return ret; > } > } > Looking into other code handling this error, a call to pm_runtime_put_noidle() may be more appropriate in this situation. Guenter