Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Jun 2020 16:05:31 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Ricardo Ferreira <rikajff@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        devel@driverdev.osuosl.org,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        linux-kernel@vger.kernel.org,
        Nishka Dasgupta <nishkadg.linux@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] Staging: rtl8712: Addressed checkpatch.pl issues related
 to macro parameter wrapping in parentheses.
Message-ID: <20200614140531.GA2661398@kroah.com>
References: <20200614135125.19502-1-rikajff@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200614135125.19502-1-rikajff@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 14, 2020 at 02:51:25PM +0100, Ricardo Ferreira wrote:
>  #define init_h2fwcmd_w_parm_no_rsp(pcmd, pparm, code) \
>  do {\
> -	INIT_LIST_HEAD(&pcmd->list);\
> -	pcmd->cmdcode = code;\
> -	pcmd->parmbuf = (u8 *)(pparm);\
> -	pcmd->cmdsz = sizeof(*pparm);\
> -	pcmd->rsp = NULL;\
> -	pcmd->rspsz = 0;\
> +	INIT_LIST_HEAD(&(pcmd)->list);\
> +	(pcmd)->cmdcode = code;\
> +	(pcmd)->parmbuf = (u8 *)((pparm));\
> +	(pcmd)->cmdsz = sizeof(*(pparm));\
> +	(pcmd)->rsp = NULL;\
> +	(pcmd)->rspsz = 0;\
>  } while (0)

Does that change really make any sense?  checkpatch is a nice hint,
sometimes it is not correct...