Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Jun 2020 17:40:21 +0200
Message-ID: <s5hr1uhac62.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Cc:     alsa-devel@alsa-project.org, bp@alien8.de, hch@infradead.org,
        Christoph Hellwig <hch@lst.de>, hpa@zytor.com,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        Pavel Machek <pavel@ucw.cz>, perex@perex.cz,
        rientjes@google.com, tglx@linutronix.de, tiwai@suse.com,
        x86@kernel.org
Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash
In-Reply-To: <1592135950.lcpn6p9fh0.none@localhost>
References: <20200520111136.GA3802@amd>
        <1591545088.74ii116nf2.none@localhost>
        <20200608061950.GA17476@lst.de>
        <1591624340.z01ejtod28.none@localhost>
        <20200609114733.GA1621@lst.de>
        <s5hr1uogtna.wl-tiwai@suse.de>
        <s5h8sgtede5.wl-tiwai@suse.de>
        <1592065395.r5zwoblr15.none@localhost>
        <s5hv9ju9dmd.wl-tiwai@suse.de>
        <1592135950.lcpn6p9fh0.none@localhost>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 14 Jun 2020 14:07:48 +0200,
Alex Xu (Hello71) wrote:
> 
> Excerpts from Takashi Iwai's message of June 14, 2020 5:54 am:
> > On Sat, 13 Jun 2020 18:25:22 +0200,
> > Alex Xu (Hello71) wrote:
> >> 
> >> Excerpts from Takashi Iwai's message of June 11, 2020 1:11 pm:
> >> > Thanks, so something still missing in the mmap handling, I guess.
> >> > 
> >> > I've worked on two different branches for potential fixes of your
> >> > problems.  Could you test topic/dma-fix and topic/dma-fix2 branches?
> >> >   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> >> > Just pull one of them onto Linus' git HEAD.
> >> > 
> >> > I guess we'll go with David's new patch, but still it's interesting
> >> > whether my changes do anything good actually.
> >> > 
> >> > 
> >> > Takashi
> >> > 
> >> 
> >> On torvalds 623f6dc593, topic/dma-fix causes sound to be output as 
> >> alternating half-second bursts of noise and a few seconds of silence. 
> >> topic/dma-fix2 appears to work properly.
> > 
> > OK, thanks for the feedback!  Just to make sure, you're using
> > PulseAudio, right?
> > If so, it was still something wrong about mmap, and the secondary
> > method (the fallback to the continuous page) looks like a safer
> > approach in the end.
> > 
> > I suppose that David's fix will be merged sooner or later.  Meanwhile
> > I'll work on the change in the sound driver side to make things a bit
> > more robust.  They don't conflict and both good applicable.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> 
> Ah, no, I think that wasn't clear. I use ALSA directly with mostly 
> default configuration, except an asym sets separate default playback and 
> record devices.
> 
> asound.conf:
> 
> defaults.pcm.card 1
> defaults.ctl.card 1
> 
> pcm.!default {
>     type asym
>     playback.pcm
>     {
>         type plug
>         slave.pcm "dmix"
>     }
>     capture.pcm
>     {
>         type plug
>         slave.pcm {
>             type dsnoop
>             ipc_key 6793
>             slave.pcm "hw:U0x46d0x81d"
>         }
>     }
> }
> 
> I think I wasn't able to set defaults.pcm.dmix.card and 
> defaults.pcm.dsnoop.card for some reason, not sure why. I can try that, 
> but I don't think it will affect this mmap issue.

The dmix is an implementation exclusively with mmap, so yes, it's
still about the mmap.  This also shows the same problem.


thanks,

Takashi