Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1126334ybt; Sun, 14 Jun 2020 11:17:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxD7jEP8fQAxzMqehCo7zWGe1wCz/6Zd+xl3enpf7y7xDWtJRTVEtLNe/QOSKLunqCWyc0p X-Received: by 2002:a17:906:95c2:: with SMTP id n2mr21356041ejy.339.1592158654562; Sun, 14 Jun 2020 11:17:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592158654; cv=none; d=google.com; s=arc-20160816; b=AdtszipUet/29tNIgERYLnS0aSCmnRkQUvbo3f5zFBjMbrStIJ2SzHTSdI+6rX/ut1 8YahT7YV+kRqMbFxtbE3TsKLSf1t0P9js2KrGzAnD+xeeN7Bqt/RHREq3j8e07PR1Fgo LJRrLZwHIhYmrFZvF7iyv1ZqACDku+sOFbbd97mPXJEh4OnQ6Wn2cE5FN3ZTCeiSWzNn +EibkV3BNTF0wpVWLskOjsCN9V7FgIzbSPtp82O3rK9aZmmsr3q0w12UMDy/vOBrP83K Dd77rMJLmfOeO2e4KJrOMys8SWlJY9J9DcZzd81RUR8qLSqqcyM8TtUUXuF3CYQi5Kef +N8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=I/OxNFBNI4Z0/4pbK+Rclrhkip1ykrGdgqyLL3oDo3g=; b=Z597gZ3DqtXVjfjQ+mMFzymjM8Vtsm5EIKFBTPZn26y3TGBQ7w2PZyi/BLDgnV4V+d kj6mfyX0M/z1w6KwtuUkiTS4dk+5s+uOBCv70pUnIwMvQd4wZeg7nT0cIVlVsRYlxlYY O6XK5yxu+XClg1WIe5Wl5CmyYOjXF09/lRvjG1eUrz4gvybEQn02w88wX59gRG2R6OxR JjGMs1tevfv6SsWC/KH3RwsY4V75DBy3KPftY/XWzpGtVMrUvD1jzkkqYR5Q70jOe+8y VJhjZeUTDJsodxmzSc+Fdg3+mPPuOGuXscyBDUzb+nUF/E9+yJSjb3szWWfKbA6lh8ug cJ4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QFIQTNYQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hb8si7582476ejb.207.2020.06.14.11.17.11; Sun, 14 Jun 2020 11:17:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QFIQTNYQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbgFNSP1 (ORCPT + 99 others); Sun, 14 Jun 2020 14:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbgFNSP1 (ORCPT ); Sun, 14 Jun 2020 14:15:27 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D19CFC05BD43 for ; Sun, 14 Jun 2020 11:15:26 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id c12so13650991qkk.13 for ; Sun, 14 Jun 2020 11:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=I/OxNFBNI4Z0/4pbK+Rclrhkip1ykrGdgqyLL3oDo3g=; b=QFIQTNYQbYKGKFgSTGTt3NMd0JlIjvHA/7qautJQsZnXsWryTU7lXcIQGAme1PTJXH 4ECYhxzqoeKJQ2BFKEi57iI+pEMiwUKZHsv1AU7TWd5j7g03V32OMKLa0POmV27r7Nns gIstIhwvXqAFNNnCWWehhe8GdcRqRyGLRZh4vksXNHu2jJKpSZ4vnDJ4oc6L/O5lIehx ZlbDFCQMPgxDallkE58IjFlAyet7zPO89nKcWYDlsue3VoCkKcT2LyzNuegRRzDczc4T LdqKkBxUivZnBpFNsyo/PxSFeDRt44KpKrp961x6SpDP9CfKqs+eMJUtoe8H3L+N8NLR parw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=I/OxNFBNI4Z0/4pbK+Rclrhkip1ykrGdgqyLL3oDo3g=; b=i9oq3VO27zi1Fu9qAkeB9F1qWUAW81y7gHtA3P3HH5fA+E3MGV3JDOrdCBM/aCv5dL bx6n3RFaOxRWDhg5BXUcjW1B4kSubcsLRbS40Gw8zT5xrJ2oo6HbccU1eEoXC5OrWD3k 0gnnV+SOIUKDQr+uT4o/PbilwdDZzYr7TdvY330syuds6yVhzixBTefhVm2mgeYyZOur E2nE505AN4SV9Uva7Mp1mZadHKKEKkR0kzpTGSYmB7bwMYNLtKBWYJVqHr6s4CICGsvs WVqKEXYY54ugRE9XCrc8YwNo4pkcZVndYSwXus/AXbO/MPlIhyxYaA+FhtENpl+c9qqp wGvA== X-Gm-Message-State: AOAM531eRqS8WU1UbG+PjdxKNu0zZpKPysW2Hox5pN0ccYktPep4Ug4C vipTWgbgPd5ICyCNub7yxhjKrgsOsej2CQ== X-Received: by 2002:a37:ecc:: with SMTP id 195mr11285440qko.469.1592158525987; Sun, 14 Jun 2020 11:15:25 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:b556:165b:f409:9052]) by smtp.googlemail.com with ESMTPSA id c2sm9044733qkl.58.2020.06.14.11.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2020 11:15:25 -0700 (PDT) From: Gaurav Singh To: gaurav1086@gmail.com, Arnaldo Carvalho de Melo , "Steven Rostedt (VMware)" , Tzvetomir Stoyanov , Konstantin Khlebnikov , Sakari Ailus , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] [traceevent] add_new_comm(): Fix memory leak Date: Sun, 14 Jun 2020 14:14:53 -0400 Message-Id: <20200614181517.30187-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pointer cmdlines need to be explicity freed in case the realloc() fails. Fix it by adding a free() if realloc() returns a NULL pointer. Signed-off-by: Gaurav Singh --- tools/lib/traceevent/event-parse.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index e1bd2a93c6db..7f0133420931 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -284,12 +284,13 @@ static int add_new_comm(struct tep_handle *tep, return 0; } - cmdlines = realloc(cmdlines, sizeof(*cmdlines) * (tep->cmdline_count + 1)); - if (!cmdlines) { + struct tep_cmdline *new_cmdlines = realloc(cmdlines, sizeof(*cmdlines) * (tep->cmdline_count + 1)); + if (!new_cmdlines) { + free(cmdlines); errno = ENOMEM; return -1; } - tep->cmdlines = cmdlines; + tep->cmdlines = new_cmdlines; key.comm = strdup(comm); if (!key.comm) { -- 2.17.1