Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1257958ybt; Sun, 14 Jun 2020 16:26:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEyKxVaPiMhOugGxJTOaMSsIkii9yKX6Ig73e1sR2AUXrmDf87kriTtUFSLCm/vM8M7Svi X-Received: by 2002:a50:ee18:: with SMTP id g24mr21785908eds.370.1592177200658; Sun, 14 Jun 2020 16:26:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592177200; cv=none; d=google.com; s=arc-20160816; b=arfk2qrboUCsx3L5S+spPzgilMj0nL0hJCVLdbdHIvREpNnWUFSDykMRyFA90RQMan UhjzBIi+yDJPXH/h00lTa2NDW7IB17e70lswQd557J4u/7gL35NQ2f4VRfZ1msoB+JPy VCwCvjUeEgMThyKExnXEEDNcXiebU2sd8iCDqKJWuAWm3SbObs1+BSuRlaU5Qs2GUI5g LxtQjl2/PFa/0d9dMz2xswWKImzl9Y4BfV4F7tqTDPwNY4KoWCYjBBf5/1fWVAFuRQ5E hJ6ydw3ngUuD9QqhbCed5mc89B875l6vVTaLSrmLaMnPpPgs+cUvQwlVnxB4WnrEsKuE z4eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=SOGSMjP33qpL7ktNpZlBjEhRk3kAp4OIE+OmxCw5kOM=; b=p/3Vu06AnA0LG1vSsFtWusm+JTAo2o8Nwm1o6yIc23gk3FpHY4mZZvTNUdOTIjCKO2 0Go109E2p7HAD1uKtbcoVn3cYbUoLjEAFCfF5RgDLbfGepzMmLhDoDpIyNdMOobA3opx CYKrTEMOxkdguv6OeTvwTVMqTsv4GkQTVYsiLzOhtU01pgQrREfVHdv8ddpueydbbAsG nXq6SsJJ0eTQnpqsHQdRXRBxpAvwnfMKpN8WqhrkzVLmIenTazBv27PTACd05VCBGPRm vT1r1NB1LONG/EdNIEioaQq2hH2yJ59bgqH/0BXXuft0jcgXVKKoZJwBLsqZ4MmwzlWm xIhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=mnHKcxVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si7786078edq.265.2020.06.14.16.26.05; Sun, 14 Jun 2020 16:26:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=mnHKcxVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727971AbgFNXXd (ORCPT + 99 others); Sun, 14 Jun 2020 19:23:33 -0400 Received: from m12-15.163.com ([220.181.12.15]:51623 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbgFNXXd (ORCPT ); Sun, 14 Jun 2020 19:23:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=SOGSMjP33qpL7ktNpZ lBjEhRk3kAp4OIE+OmxCw5kOM=; b=mnHKcxVeVzwxurr41nI19pY9PG8iqDcOa3 ZY1WReuIr0YbNRQKvxkX7rx/9z9jbEbVgBKPROzjBeruIk5kr13EtnnWViphk20l kUc4F/BpsDzbq2md+zXZnTr0sYZD2dIRSi4KDc3d4O8aGPN17tZJBHmRTno5f/ih ddlA9kHkk= Received: from localhost.localdomain (unknown [111.202.190.28]) by smtp11 (Coremail) with SMTP id D8CowAAXH4s6seZeGdtvGw--.51482S2; Mon, 15 Jun 2020 07:22:34 +0800 (CST) From: zzuedu2000@163.com To: James.Bottomley@HansenPartnership.com Cc: tj@kernel.org, lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, songmuchun@bytedance.com, buddy.zhang@aliyun.com Subject: Re: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set() Date: Mon, 15 Jun 2020 07:22:24 +0800 Message-Id: <20200614232224.1804-1-zzuedu2000@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <1592158208.5303.27.camel@HansenPartnership.com> References: <1592158208.5303.27.camel@HansenPartnership.com> X-CM-TRANSID: D8CowAAXH4s6seZeGdtvGw--.51482S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxU8Xo2DUUUU X-Originating-IP: [111.202.190.28] X-CM-SenderInfo: p22xvvbxsqiii6rwjhhfrp/1tbioxpDQlUMSsfoJQAAsh Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-06-14 at 18:10 +0800, James.Bottomley@xxxxxxx wrote: > it's arguable that having two statements instead of one makes the code > marginally more readable. Above the function there is a similar line of code: l = it->tcset_pos->next; One line of code makes the code style consistent and more readable Regards, Wei Fenghai