Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t
To:     Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>
CC:     David Windsor <dwindsor@gmail.com>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        Elena Reshetova <elena.reshetova@intel.com>,
        "Paul Moore" <paul@paul-moore.com>, <edumazet@google.com>,
        <paulmck@kernel.org>, David Howells <dhowells@redhat.com>,
        <shakeelb@google.com>, James Morris <jamorris@linux.microsoft.com>,
        <alex.huangjianhui@huawei.com>, <dylix.dailei@huawei.com>,
        <chenzefeng2@huawei.com>, <linux-kernel@vger.kernel.org>
References: <20200612183450.4189588-1-keescook@chromium.org>
From:   Xiaoming Ni <nixiaoming@huawei.com>
Message-ID: <7be4d56b-0406-099b-e505-02e074c5173e@huawei.com>
Date:   Mon, 15 Jun 2020 10:10:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20200612183450.4189588-1-keescook@chromium.org>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/6/13 2:34, Kees Cook wrote:
> This series was never applied[1], and was recently pointed out as
> missing[2]. If someone has a tree for this, please take it. Otherwise,
> please Ack and I'll send it to Linus.
> 
> Thanks!
> 
> -Kees
> 
> [1] https://lore.kernel.org/lkml/20190306110549.7628-1-elena.reshetova@intel.com/
> [2] https://lore.kernel.org/lkml/1591957695-118312-1-git-send-email-nixiaoming@huawei.com/
> 
> Elena Reshetova (3):
>    nsproxy: convert nsproxy.count to refcount_t
>    groups: convert group_info.usage to refcount_t
>    creds: convert cred.usage to refcount_t
> 
>   include/linux/cred.h    | 15 +++++++-------
>   include/linux/nsproxy.h |  7 +++----
>   kernel/cred.c           | 44 ++++++++++++++++++++---------------------
>   kernel/groups.c         |  2 +-
>   kernel/nsproxy.c        |  6 +++---
>   net/sunrpc/auth.c       |  2 +-
>   6 files changed, 38 insertions(+), 38 deletions(-)
> 

Should mm->mm_users also be replaced by refcount_t?

In addition, is it better to change all variables that use 
atomic_dec_and_test to control the release process to refconut_t?

Thanks
Xiaoming Ni