Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: AxCI4PtEvaiycsC0zNn9K/DcIc8NFaVIz9DcsPQGFel8hgSnKb5XfF/KJ/H0oVHuu8Ka0WcKbY
 tAZudzWGxE1g==
IronPort-SDR: tjL4Phx3B6mSrPeEU7YUADxc+Y2AH+SC5itT3EmJbCyBtDRSrsQWek5MGOIrf0M5HJ1HnlozsK
 gGKiLmEN1kWg==
From:   "Reshetova, Elena" <elena.reshetova@intel.com>
To:     Kees Cook <keescook@chromium.org>,
        Xiaoming Ni <nixiaoming@huawei.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        David Windsor <dwindsor@gmail.com>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        Paul Moore <paul@paul-moore.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        David Howells <dhowells@redhat.com>,
        "shakeelb@google.com" <shakeelb@google.com>,
        James Morris <jamorris@linux.microsoft.com>,
        "alex.huangjianhui@huawei.com" <alex.huangjianhui@huawei.com>,
        "dylix.dailei@huawei.com" <dylix.dailei@huawei.com>,
        "chenzefeng2@huawei.com" <chenzefeng2@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t
Thread-Topic: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t
Thread-Index: AQHWQOg7pvDM2vjI7kmUTaz/F8Qw8ajY8l4AgAAdh4CAABsdYA==
Date:   Mon, 15 Jun 2020 05:35:58 +0000
Message-ID: <CY4PR1101MB23261B27ACF9D7FBC3969318E79C0@CY4PR1101MB2326.namprd11.prod.outlook.com>
References: <20200612183450.4189588-1-keescook@chromium.org>
 <7be4d56b-0406-099b-e505-02e074c5173e@huawei.com>
 <202006142054.C00B3E9C9@keescook>
In-Reply-To: <202006142054.C00B3E9C9@keescook>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d3bff23a-b160-42ac-a730-08d810edfb85
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2020 05:35:58.4399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N0fycMOrheA11Pg4ow0/aaES9ZH6dpxJfDG9ZFLEpxVkHmlJl9fn2UwLh9qY4+tN+5+z7zVb9esIGHJEsT/fAitA5dBGQmJoqkpmHcD9eXc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1367
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Mon, Jun 15, 2020 at 10:10:08AM +0800, Xiaoming Ni wrote:
> > On 2020/6/13 2:34, Kees Cook wrote:
> > > This series was never applied[1], and was recently pointed out as
> > > missing[2]. If someone has a tree for this, please take it. Otherwise=
,
> > > please Ack and I'll send it to Linus.
> > >
> > > Thanks!
> > >
> > > -Kees
> > >
> > > [1] https://lore.kernel.org/lkml/20190306110549.7628-1-
> elena.reshetova@intel.com/
> > > [2] https://lore.kernel.org/lkml/1591957695-118312-1-git-send-email-
> nixiaoming@huawei.com/
> > >
> > > Elena Reshetova (3):
> > >    nsproxy: convert nsproxy.count to refcount_t
> > >    groups: convert group_info.usage to refcount_t
> > >    creds: convert cred.usage to refcount_t
> > >
> > >   include/linux/cred.h    | 15 +++++++-------
> > >   include/linux/nsproxy.h |  7 +++----
> > >   kernel/cred.c           | 44 ++++++++++++++++++++------------------=
---
> > >   kernel/groups.c         |  2 +-
> > >   kernel/nsproxy.c        |  6 +++---
> > >   net/sunrpc/auth.c       |  2 +-
> > >   6 files changed, 38 insertions(+), 38 deletions(-)
> > >
> >
> > Should mm->mm_users also be replaced by refcount_t?
>=20
> I'll say "yes". :)
> https://lore.kernel.org/lkml/1487671124-11188-1-git-send-email-
> elena.reshetova@intel.com/
>=20
> > In addition, is it better to change all variables that use
> > atomic_dec_and_test to control the release process to refconut_t?
>=20
> For the most part, yes. The following may find a lot of them:
> scripts/coccinelle/api/atomic_as_refcounter.cocci
>=20
> If you can go through that and double check for prior series from Elena,
> we can get through all the rest of them.

I have these ones also here in case anyone is interested:
https://github.com/ereshetova/linux-stable/commits/refcount_t_fs
https://github.com/ereshetova/linux-stable/commits/refcount_t_block

They haven't been rebased for a while, but if there is an interest,=20
I can certainly do it.

Best Regards,
Elena.