Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CGME20200614062349epcas1p1e285479c1e6483708b62f93e70a453a4@epcas1p1.samsung.com>
 <20200614062339.87374-1-navid.emamdoost@gmail.com> <027d9eb5-a1c1-c329-72c3-a555b71f8677@samsung.com>
In-Reply-To: <027d9eb5-a1c1-c329-72c3-a555b71f8677@samsung.com>
From:   Navid Emamdoost <navid.emamdoost@gmail.com>
Date:   Mon, 15 Jun 2020 00:50:24 -0500
Message-ID: <CAEkB2ESuG7omgvdEnfQ+hV_uWa1mhK=22VnN++TaFqOycaTc_A@mail.gmail.com>
Subject: Re: [PATCH] drm/exynos: fix ref count leak in mic_pre_enable
To:     Inki Dae <inki.dae@samsung.com>
Cc:     Joonyoung Shim <jy0922.shim@samsung.com>,
        Seung-Woo Kim <sw0312.kim@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Navid Emamdoost <emamd001@umn.edu>,
        Qiushi Wu <wu000273@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
        Stephen McCamant <smccaman@umn.edu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 14, 2020 at 7:47 PM Inki Dae <inki.dae@samsung.com> wrote:
>
> Hi,
>
> 20. 6. 14. =EC=98=A4=ED=9B=84 3:23=EC=97=90 Navid Emamdoost =EC=9D=B4(=EA=
=B0=80) =EC=93=B4 =EA=B8=80:
> > in mic_pre_enable, pm_runtime_get_sync is called which
> > increments the counter even in case of failure, leading to incorrect
> > ref count. In case of failure, decrement the ref count before returning=
.
> >
> > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/=
exynos/exynos_drm_mic.c
> > index a86abc173605..69ff74c2ceb5 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -270,7 +270,7 @@ static void mic_pre_enable(struct drm_bridge *bridg=
e)
> >
> >       ret =3D pm_runtime_get_sync(mic->dev);
> >       if (ret < 0)
> > -             goto unlock;
> > +             goto turn_off;
>
> How about just calling pm_runtime_put_noidle()?
>
> if (ret < 0) {
>         pm_runtime_put_noidle(mic->dev);
>         goto unlock;
> }
>
v2 was sent.

> Thanks,
> Inki Dae
>
> >
> >       mic_set_path(mic, 1);
> >
> >


--=20
Navid.