Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1432371ybt; Sun, 14 Jun 2020 23:18:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNe74A9kanb4qulbd2XiO4sPGQnR8yEIQxnbiso6owUqmDHsMQ4DFPL99CinRDsbt0VTG2 X-Received: by 2002:a50:9ead:: with SMTP id a42mr21657288edf.129.1592201907166; Sun, 14 Jun 2020 23:18:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592201907; cv=none; d=google.com; s=arc-20160816; b=PbrCvvs7ibdt6Jk412lGaubq3x2ZJvU+o7IHYcXZaY3QYx28elzKsux/LzbZ7EwDVe JBCcbVHdXHbTZr/t7nYFzPGHZ33u1xq/gG0ydIk8BUGPQr2he9iVhHU7u1Hh+7HDaGRy o0xJ/XiwOIKU0rBDh8PX0oy6SebspMZg9nlmK4CnH444aH9PlmA8OvU1lfcIqsCpFuFy NEJr+KykS/2BoTvJ/QFMY53ln0pOlYHP5ayNJSURaQO2qhzWLIM/cWOmOVMZfaC2MYOj fEhGpGj2yraT3AWYdEhlTYU4Vjnp1cLGULwvc60PgQwYz47jgHALygdWzzDTLLM//HJe R60w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Pq8wSoIwYToPYyYMgXetLZRme7ou0tgoOwDcqdnlKHE=; b=qNnLkBH/Uob5UF/vGe/0HdDSHK8mfw87/7ubNgWtS7HM2wXWZcNsP/GmNScUM23TWT F7ALAyEy0WJ36fo88JDyW/QJSZU+XafAzL/MDkEr52GN4e9Yd3l2YxgDHzVlM6/a8/0o UdFLXc8nMLJFsrLP/z7jSsymw/4CMCYql+nu+cC6G3R28sEVfEKezeXzgLbCYP4HghTi nfb48rjjgktTI0KpBUby7/J1zkrkdxACfNuOGZsqmMyaYp59pz3TENJhvWqSnwsPJ/CY UVxPW8DQ3RQCfTp79h6NJWU48XjRCLCob/2bD9zjAvqnzR6cYyhMBi4ss4/04AGC40zd N2+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YhYAievL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si7982464edt.7.2020.06.14.23.18.05; Sun, 14 Jun 2020 23:18:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YhYAievL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728318AbgFOGPl (ORCPT + 99 others); Mon, 15 Jun 2020 02:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728268AbgFOGPk (ORCPT ); Mon, 15 Jun 2020 02:15:40 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39740C061A0E for ; Sun, 14 Jun 2020 23:15:40 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id q8so14683838qkm.12 for ; Sun, 14 Jun 2020 23:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pq8wSoIwYToPYyYMgXetLZRme7ou0tgoOwDcqdnlKHE=; b=YhYAievLTb+s1aYwoEae3p1JzZ8ET8WqfcyarhCMhIGjmFW2VuSv56qtK0iTXYAOJK FxW7ggnTNvKInUW/vfv9UtPmG7tFHvy2paKRofuftyaDFLjAyrCMSJ3Occs4TzSmNiL1 +PLfC8COBKhE03g2EZeGMzANYHNxIgo4U3/pYEDsusGE3TZzIb9S+/N/euRHah/dUSoD NkXs3wEDD/qErfLaT1UUhe6OyD/uUVWe6U0GBAunp9czEivTVXw0CTOxd/JDr1k5fQyC 1OQUVn+/VpGR8XOY4P6eiKzicVZ2zF5UM7xL/lHifQegmlu0ThYcdOsWYeqsjxQk3GJU UPXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pq8wSoIwYToPYyYMgXetLZRme7ou0tgoOwDcqdnlKHE=; b=WA7rCiFRxRhtoIWZUl/PfVlF4PN+N3qg756OAIyAGnZA2WY+ycl8/B0p2PjUFoaC7P CnlGOOM2L6NEpuhqffxLs+nJ2D+RcI6rfBQ1ZREXRmXPIQUoNC4+yG8cMIDktVFfaCRM LG9YXAh8m1JU5+ar44QHDpk1doW7IkiYN1Mh9SYcMlsgfjsynvh/kL+74HKJt5dfJZPL V/zfGbZZS4bk32KL3GhurSkblDs2UZGUkesLTc1TUCgLlcbew0xcuth9L6JgLK0B3ddj iOESXib9751Oh8gfyM8DsNL46iHyN42izDv9wJfm3BnY9eo6Nbpp8XaVLPA6xBDuCTQL dE+A== X-Gm-Message-State: AOAM530T3MSKc789+eiY9omfsQR3F6LbuSXPehG7g8x4bvImhrFBt0+Z qiylYcBSHx8KcrqUIoqrUL9DfekptbJb0ceFuIk= X-Received: by 2002:a05:620a:a4a:: with SMTP id j10mr13337550qka.272.1592201739302; Sun, 14 Jun 2020 23:15:39 -0700 (PDT) MIME-Version: 1.0 References: <20200614123923.99189-1-songmuchun@bytedance.com> <20200614123923.99189-3-songmuchun@bytedance.com> In-Reply-To: <20200614123923.99189-3-songmuchun@bytedance.com> From: Joonsoo Kim Date: Mon, 15 Jun 2020 15:15:28 +0900 Message-ID: Subject: Re: [PATCH 2/3] mm/slub: Use node_nr_slabs() instead of slabs_node() To: Muchun Song Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2020=EB=85=84 6=EC=9B=94 14=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 9:39, M= uchun Song =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > In the some code, we already get the kmem_cache_node, so we can > use node_nr_slabs() directly instead of slabs_node(). Check the > condition of n->nr_partial can also be removed because we can get > the correct result via node_nr_slabs(). > > Signed-off-by: Muchun Song If appying this patch, there is no reference to slabs_node(). Please remove= it. Thanks.