Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1454361ybt; Mon, 15 Jun 2020 00:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJ+V7wVYq65O0CCUnHjUABNcGcAg2SNF2uMQIlrU8BElLBkdDP0ObNLyd5bejDp727OnfS X-Received: by 2002:a05:6402:b21:: with SMTP id bo1mr21616764edb.169.1592204913739; Mon, 15 Jun 2020 00:08:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592204913; cv=none; d=google.com; s=arc-20160816; b=FQ25MAdS20RyNyQlykXZR2r5dWKz0HvlYMQXuTIf7W7r084h1Xd1/dwxIiEl43ktF/ 0YTKQnwc11JpyDluQ4YIZoxT3bvz9QDHkvgnz/WGragD6Ul1i86NajfKI7iwUoesoElQ cBf47RB99yqc52vDD0ZDUtV5bUwuGnJDmW4O4XmICKnkiiMbTUHTsIghT80s5Ub0RouI owpmU4w63I1m+XN9JF4qmX5SyPCkMdT7omB2nM9yvOvxxgBodxTr48VVK2S47UCU8PYs Q4zDdZ0Qc0j5zg7/5Yf36SQN6l5SHuvyYDeoLtnZ2OQwBuujKdZAiuEAqIbHT8zL/eBD KHfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=fUQNCAAb6DjGomvNl4eNFS4GZ/iZOIWKfiriaaglQf4=; b=Cl4WlD1lFXKIv7rhJpR2Q31woPwlEjlJ0NP0NRugT8oV1fiyPVnfzpRxC+IFX33b1u ItWfE13/bGL+n+0gJkBOR+0h5KW6fiLUIutmrCchJKWHiweyRZsNiA+1d4Tf1bM/ETtU jXMOXce8SkhTamkp5q6zLEyaZhl+zApOdOdrrn/F8/ja5KCf2LkEvjsRYE6gPB5A4l1Z qKAzWtclvYRbxKDw4thc0OQMAMGz904/BBimt19ZRv3Y6rgEQUsL35pA8CMtrW6G1ejH YsnRBlQEi5P6FfHKOMq61SAlrXBiZhQ4kOgPhZ5L491wVtECD9slbzGKiRkNXif4gDVR jzcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NGt9H7nP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n11si8285216ejh.543.2020.06.15.00.08.09; Mon, 15 Jun 2020 00:08:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NGt9H7nP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728312AbgFOHGV (ORCPT + 99 others); Mon, 15 Jun 2020 03:06:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728180AbgFOHGV (ORCPT ); Mon, 15 Jun 2020 03:06:21 -0400 Received: from localhost (p54b333b6.dip0.t-ipconnect.de [84.179.51.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0060C206D7; Mon, 15 Jun 2020 07:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592204780; bh=fUQNCAAb6DjGomvNl4eNFS4GZ/iZOIWKfiriaaglQf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NGt9H7nPgvZ32vSDoQGNlVzCidRta/sIu4S/AmYHx+omviqGOlI7rqBOrBomhSabw odKfQDbf/MwUe5m2rlbgggpyE7/rDmDwe2IGiw+N6nfMmlxjKDzT8UnkOvCjmA9xi4 3HP1Lh/ZIcwsuvpACy6Cczd7m27IFY44y/ETSLR8= Date: Mon, 15 Jun 2020 09:06:13 +0200 From: Wolfram Sang To: Aisheng Dong Cc: Dinghao Liu , "linux-pm@vger.kernel.org" , Ulf Hansson , "Rafael J . Wysocki" , "kjlu@umn.edu" , Markus Elfring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Andy Duan , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Message-ID: <20200615070613.GA1497@kunai> References: <20200601061640.27632-1-dinghao.liu@zju.edu.cn> <20200614091203.GC2878@kunai> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2020 at 06:33:40AM +0000, Aisheng Dong wrote: > > From: Wolfram Sang > > Sent: Sunday, June 14, 2020 5:12 PM > >=20 > > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote: > > > pm_runtime_get_sync() increments the runtime PM usage counter even the > > > call returns an error code. Thus a corresponding decrement is needed > > > on the error handling path to keep the counter balanced. > >=20 > > Can you point me to a discussion where it was decided that this is a pr= oper fix? > > I'd think we rather should fix pm_runtime_get_sync() but maybe there are > > technical reasons against it. >=20 > I had the same feeling. > Copy pm guys to comments. I started a seperate thread: https://lkml.org/lkml/2020/6/14/76 Still, on-going discussion if the proper fix is to remove the error check. --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7nHeEACgkQFA3kzBSg KbbAbA/9FTQMd1gpGi6tiS2NPZ+sd1kxs7t0vnUK9MLKKpgEC0Do/6JBFttvRoN6 So/PITa5zgqjUYeNzRtrbMjXmQVSbCanAhMOBGX2/8w6aMUJnGPbm6sDT26oQkSP T0jzir2gR3Mw9bh07kXbszx4vJGOFJDOlH31BjxvN/9lZZRCILiEpfoTxGNAOXyV 73BiU6Ez6AMB01363BL8vMC/l4W82YeitG6xrxvz+Fzw5/OQ7qFlOrDfEFbP10tU wlbk5gUjyWEzhzh0qqGPuRVDeuBxGDgrDQDpFGScJBfZ1oH7lqSyg7fjdOIG3fNH RPSgvvoPkJkY1WL9wbt3lOpt+F/rBJYy7iDMwY9CgYnaF4bP+peLtUzazK83Wzhb F4N5A7AP550rmEYEZV1sJqNHacQFqcXXdremSzKjMEp1XVp4CqncjIGrC9qy+BAQ VZi3L8ExCY36TWYPi5lBqJ76vv3nB2q+GhYkU9CaBok/rQ12LmgGS4Z27X9YjdS4 3CwpsXCrl+/4tsbxFxbWqRvvCMYQwtbIJ3EWGG6ga277+OtYDSSnn3QLFt4GUQ3F xnWTt0+xvPRHfI/b2ffkQBYINd9kqEy5c7H6OSN67NtdREktPmtbS8OHhEoTx1gy 2Ly8984MP9JzxermLmvQ0mvvtJFrr1TA80UCmQev6XsMoQ/xCUg= =g8OW -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--