Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Jun 2020 10:14:31 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Diego Rondini <diego.rondini@kynetics.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/2] ARM: dts: orange-pi-zero-plus2: add leds
 configuration
Message-ID: <20200615081431.sbqezly4jcryvxk6@gilmour.lan>
References: <20200528204712.552964-1-diego.rondini@kynetics.com>
 <20200528204712.552964-2-diego.rondini@kynetics.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ldpz5qc3s34puj3m"
Content-Disposition: inline
In-Reply-To: <20200528204712.552964-2-diego.rondini@kynetics.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ldpz5qc3s34puj3m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 28, 2020 at 10:47:12PM +0200, Diego Rondini wrote:
> Add pwr and status leds configuration and turn on pwr led by default for =
Orange
> Pi Zero Plus 2 (both H3 and H5 variants).
>=20
> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> ---
>  .../boot/dts/sun8i-h3-orangepi-zero-plus2.dts    | 16 ++++++++++++++++
>  .../allwinner/sun50i-h5-orangepi-zero-plus2.dts  | 16 ++++++++++++++++
>  2 files changed, 32 insertions(+)
>=20
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts b/arch/ar=
m/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> index 4376767699a47..4cd0ac706bd2c 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> @@ -82,6 +82,22 @@ wifi_pwrseq: wifi_pwrseq {
>  		reset-gpios =3D <&pio 0 9 GPIO_ACTIVE_LOW>; /* PA9 */
>  		post-power-on-delay-ms =3D <200>;
>  	};
> +
> +	leds {
> +		compatible =3D "gpio-leds";
> +
> +		pwr_led {
> +			label =3D "orangepi:green:pwr";
> +			gpios =3D <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> +			default-state =3D "on";
> +		};
> +
> +		status_led {

Having an underscore in the node name will trigger a DTC warning. What
about using pwr and status as nodenames?

> +			label =3D "orangepi:red:status";
> +			gpios =3D <&pio 0 17 GPIO_ACTIVE_HIGH>;
> +		};
> +

There's an extra line here that you should remove

Maxime

--ldpz5qc3s34puj3m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXuct5wAKCRDj7w1vZxhR
xUjaAQDkFMomehsDqclVzdruO2gQslavfdE5Z5Nk9MBu53/X4AEAuy/0NEbxdB4m
iIgPxGIxqLa5k/nFdCS+8z/ksmbEdgw=
=N70a
-----END PGP SIGNATURE-----

--ldpz5qc3s34puj3m--