Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
To:     Drew Fustini <drew@beagleboard.org>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>,
        Linux-OMAP <linux-omap@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Jason Kridner <jkridner@beagleboard.org>,
        Robert Nelson <robertcnelson@gmail.com>,
        Vinod Koul <vkoul@kernel.org>
References: <20200611220951.GA3355634@x1>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <10637da2-8751-3c6f-cf1e-f0a53cca292d@ti.com>
Date:   Mon, 15 Jun 2020 12:34:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200611220951.GA3355634@x1>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 12/06/2020 01:09, Drew Fustini wrote:
> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
> RGMII mode") the networking is broken on the BeagleBone AI which has
> the AR8035 PHY for Gigabit Ethernet [0].  The fix is to switch from
> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
> 
> Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for
> other AM5729 boards.

commit ref is incorrect
> 
> [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf
> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode")

Pls change fixed tag to
520557d4854b ARM: dts: am5729: beaglebone-ai: adding device tree
as this board DTB was merged only in 5.8.

> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
>   arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
> index 9877d7709d41..4c51c6b05e64 100644
> --- a/arch/arm/boot/dts/am5729-beagleboneai.dts
> +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
> @@ -505,7 +505,7 @@ &mac {
>   
>   &cpsw_emac0 {
>   	phy-handle = <&phy0>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-rxid";
>   };
>   
>   &ocp {
> 

Thanks, pls fix above and you can add my
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii