Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media: ov2740: add NVMEM interface to read customized OTP
 data
To:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        tfiga@chromium.org, bingbu.cao@linux.intel.com
References: <1591954922-14006-1-git-send-email-bingbu.cao@intel.com>
 <20200615092923.GT16711@paasikivi.fi.intel.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <f4204020-3b84-c138-6648-1e22e194138e@linaro.org>
Date:   Mon, 15 Jun 2020 10:46:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200615092923.GT16711@paasikivi.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 15/06/2020 10:29, Sakari Ailus wrote:
>> +	ret = ov2740_register_nvmem(client);
>> +	if (ret)
>> +		dev_err(&client->dev, "register nvmem failed, ret %d\n", ret);
>> +
>>   	/*
>>   	 * Device is already turned on by i2c-core with ACPI domain PM.
>>   	 * Enable runtime PM and turn off the device.
> Could you add #ifdefs for CONFIG_NVMEM so this compiles when it's disabled?

NVMEM already has dummy functions. IMO its better to report an error to 
user as the current code does. This will atleast alert the users of 
existing nvmem provider that has been disabled!

However with ifdef users have to really look into code to be able to 
understand that there is nvmem provider as part of this driver.


Unless you have tight memory restrictions I see no great advantage of 
adding #ifdefs

--srini
> It's bool so a simple #ifdef will do. I think ov2740_register_nvmem() could
> have a dummy implementation so this wouldn't litter the probe function.
> 
> Thanks.