Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1564424ybt; Mon, 15 Jun 2020 03:44:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0naUiDUvI8xXm3PeBp/W2zpunhIYFaNJ8AR2TI8gLeQf6QYzTQK8VBdf0rZCLBupcxmLf X-Received: by 2002:a17:907:42d5:: with SMTP id ng5mr25316636ejb.164.1592217886458; Mon, 15 Jun 2020 03:44:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592217886; cv=none; d=google.com; s=arc-20160816; b=uVpkHQ9s3VxSb9cZ2wb7O2u1qmuqUBASx4u2gyo6d2Ft2sRRO13zl6F73Mx82smJTI zNdookD5pC6OlJ9VTGX96VL+t9fWt1AT/MOgUz/x/IH+SLkgKV9946729YymiU2ZQM1c pT6Cmiic7qXy1I+UwC/bH+I2OvLThUz9yQqAsA1Rk0Gk/vjEMWWEjxG3N7ZLEKpWIuDt F2zMzyD988Xjg52mBwLsTggsNga+UFPUoi+AAXg/n/mfF2NgN4N/tD1LGn2f0ZRbp6l+ up14PulCqSo6uSAlyHJCT21WzT2FBfb3pjrl9Exlvh9RbMhHnOTfxZgl8/moAan+snc5 GN4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jPHbnpsP7nJsHwqhoLDcDNp33N50coO4YGuyYQ7o3xw=; b=IET0VFzZ9DTfIxpzfkElpDrt3EhBWWQVzDtG9NuZ/YblDAe04HcvxcArUV1YrDjPHN 0LHRpVRQuKnuBdWZR5MWRS+EqivmYHncrHJjkuLqCPzpazSF1YUACGXjhr7ZJzUuSeEY O36OLAZzexjRQeb58cN4N0BT7/zG9WZxUoAxMXSPXS01DYGha3Z2eT/amY+/3yusllke Yz/WW21mAIZDT+BDSIrmgSxvIDU1v41gQHIPBlgkMz1SQz5qC52lzjFg1kYpGnhqDL0f 0jDRTpxjCa678kh5T9+GaDVi0m4Spp3f6a3T7Mm5r1Nd4+uweRrKgjPhZZW9kJkutVge WnjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=esgDsx5j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si8292725edf.467.2020.06.15.03.44.23; Mon, 15 Jun 2020 03:44:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=esgDsx5j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729354AbgFOKme (ORCPT + 99 others); Mon, 15 Jun 2020 06:42:34 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:57701 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728860AbgFOKme (ORCPT ); Mon, 15 Jun 2020 06:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592217753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jPHbnpsP7nJsHwqhoLDcDNp33N50coO4YGuyYQ7o3xw=; b=esgDsx5j9qnPbmgrQUogsCB8lEMdTuWVL3M7D/74EW6K8qpCOrC6JPkCzTdLDf1NmSDA8r DnEIP7RlITarAP7clo4oV6t52dSCzY6sXyM/TzHAMYVGJAllePWP2cAt0XGFeet9yugxVS CSylEsBlgjsmYQz0f2XYukaWPSgLk0Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-T5eMHHQzOJucP76Svdhvjg-1; Mon, 15 Jun 2020 06:42:31 -0400 X-MC-Unique: T5eMHHQzOJucP76Svdhvjg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B46C106B242; Mon, 15 Jun 2020 10:42:30 +0000 (UTC) Received: from T590 (ovpn-12-247.pek2.redhat.com [10.72.12.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9264F768DC; Mon, 15 Jun 2020 10:42:24 +0000 (UTC) Date: Mon, 15 Jun 2020 18:42:18 +0800 From: Ming Lei To: Baolin Wang Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: Remove redundant 'return' statement Message-ID: <20200615104218.GB19764@T590> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 05:12:23PM +0800, Baolin Wang wrote: > The blk_mq_all_tag_iter() is a void function, thus remove > the redundant 'return' statement in this function. > > Signed-off-by: Baolin Wang > --- > block/blk-mq-tag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c > index 44f3d09..ae722f8 100644 > --- a/block/blk-mq-tag.c > +++ b/block/blk-mq-tag.c > @@ -376,7 +376,7 @@ static void __blk_mq_all_tag_iter(struct blk_mq_tags *tags, > void blk_mq_all_tag_iter(struct blk_mq_tags *tags, busy_tag_iter_fn *fn, > void *priv) > { > - return __blk_mq_all_tag_iter(tags, fn, priv, BT_TAG_ITER_STATIC_RQS); > + __blk_mq_all_tag_iter(tags, fn, priv, BT_TAG_ITER_STATIC_RQS); > } Reviewed-by: Ming Lei -- Ming