Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1633898ybt; Mon, 15 Jun 2020 05:41:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCTMpke6YXIvDFa2hz0sw/79GWjm7tfWhDue75gQz699U9cjWjQaui9fAuKaLeEyi62f35 X-Received: by 2002:a05:6402:6c6:: with SMTP id n6mr22777053edy.277.1592224911933; Mon, 15 Jun 2020 05:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592224911; cv=none; d=google.com; s=arc-20160816; b=dNPLJSGVUuRPvEtYF/7pk8jaJDnvLkDujsJNj7QG9DtVtYwvPI0IPKQ8xRoZ0rQYN2 h0sCcMT9rJ/TnZ7xeyJx0IjpAlRyDdV118bjmOV62oBMwIXmpERkhPMC5Q2xhPKSkjyk CfHuFxnSaM2t+vBhX6hTD4o85jaRc3/F6pPDcnjsr+/FrtCfIFA46/7mvh2PUHYRum8x J7F+q+Jqxfoy5XLfe2Tz/bSwPV7M8QfwGCobhcirAuO/LJ2wLBmASblQT0lZUweZIGl8 WxQ4h7gyZ2bjF8DcJTWMF6HpHsyTlCtMghnqW7ibSNVxW4y7Zag3TlOhcODlFlkVtuzy LJNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RrInYR4OpahVJZJ2Bv8BGsWLBHnDsqIbKWPk2bOaqKQ=; b=JgXVuTrsPcJTD2my3lmnEwmpOlBMLMZDgREoc2tlxpHyFYasDhkEZS3aNI9Al71IIg zZQbb6GoPX1XQmLBty4krnn1UorEllGD9i/h8vc66WXCEGuy5lSPpY9tGnJVPmsxsU6F AUmz0nq1ziDuEJWin3+EWnXqMt9799ITFFIy54bNVjKIEFknx91pH9t/9cazlIbwYGq7 z7gGeuNWnNJTC49lsN4VRzxLFhLCdOXF7KwlVJO4jHGKj8q1Me48Y839RPOem2X+SroW mVcUlvkJgqGUeykbD1UxQJivmK6+YzA5/PILdVLVGWVSaqBGEteJoIaA+t0Utr01XHD5 Najg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="f5wM4r/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si8386312eja.608.2020.06.15.05.41.29; Mon, 15 Jun 2020 05:41:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="f5wM4r/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbgFOMgx (ORCPT + 99 others); Mon, 15 Jun 2020 08:36:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:52634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728326AbgFOMgw (ORCPT ); Mon, 15 Jun 2020 08:36:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E323B206D7; Mon, 15 Jun 2020 12:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592224612; bh=MLaz9Lh1fa6o0lqJXRQNSErh5KCNk+V5uBZbIEvmyBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f5wM4r/qTZh2Gd/MrVZAAxieeBAcKNrUg01uSmxjMC3u5RYWnyavygGbZTl2XKqaA e1/gA37Wvyg0cZw1jS5WU7VPSXJaVsvVe65KEHAyGQSs9Xk1CNBM5PBNL6wO/fcT2Y XP5kUxvdiMdB0Iqkmm5M5/BRDNTGHrz5i2N4kJwo= Date: Mon, 15 Jun 2020 14:36:39 +0200 From: Greg Kroah-Hartman To: Ricardo Ferreira Cc: Larry Finger , devel@driverdev.osuosl.org, Florian Schilhabel , linux-kernel@vger.kernel.org, Nishka Dasgupta , Dan Carpenter Subject: Re: [PATCH v2] Staging: rtl8712: Addressed checkpatch.pl issues related to macro parameter wrapping in parentheses. Message-ID: <20200615123639.GC943330@kroah.com> References: <20200614173146.28292-1-rikajff@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200614173146.28292-1-rikajff@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 14, 2020 at 06:31:46PM +0100, Ricardo Ferreira wrote: > Attempting to wet my feet in kernel patch submission by submitting a checkstyle > fix for the rtl8712 driver. > > Signed-off-by: Ricardo Ferreira > --- What changed from v1? Always put that below the --- line, so please fix this up and do a v3. Also, your changelog text is very odd, do you see other commits in the kernel for these files that say things that way? Please try to follow how others do things. Also read the documentation for how to make a good changelog text, that will help out a lot. thanks, greg k-h