Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1641514ybt; Mon, 15 Jun 2020 05:56:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyburr9jagTLhPTbyEmD3o+iAG1XckwFgsJ/PUwjHTPtMQNth2GlR5CONGai12QXcZlMXxm X-Received: by 2002:a17:906:4056:: with SMTP id y22mr24769691ejj.304.1592225766110; Mon, 15 Jun 2020 05:56:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592225766; cv=none; d=google.com; s=arc-20160816; b=MQKJY7wsVK0/WEjOaNEFtOl2s8Z56gqSf2vqQAdJMS3IzztYiIaL3tkxdNfTIhN/fC VWiqi1tsREgZ5qmkta9AgD0l4+lo0OeDfQdJoWrsuoHoyKTbfcuuDB3d9PutdVri2LQY WrGbIADj4My348yiD8ScP+Wzh2lIdwZ1mJrU0U5CCvlm4ot8LxFEMtGXFsTTrn5v9OsU hU1m1R6HrPzPA8BNUbuHtyniC/0eANxjjhMoJlmhYZWD7KKTQU5Jqqw4BXMDFW+EF1iU oEhNltI7+EXHKypoVYd12gVyRaieea1jnX9DT3RgoRz/3UIGAB9fVX2NlGVS3jsgdgNc 9zQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=clFlh/3jgP2RIneaAl1IBs71yVx0d986g/Ul+QGI0pc=; b=bHS8mquV8Jkn6Ph+IxyoavZJb9QNKh0EswrFnsFWu37m81yFZbr6AM6qwvalxnDN2G wPEEDEhYqQ5R2Q6dRflJL1UqsSRHumbihhD23EklqfBmP/4mv/gV6My0vkMqkWh18OpJ djrgFdBTJF5DTOhoHTm78KKINNYQwHtYepI6Vn7l3o/HmZBFabMDKhncTexMetMUsAoG T3CYC6umaWVnqtkltlJnfEXC5GbLaQpV2zoVj47RwsyiI9dSJIJpDDRrsWIbjJOYgSjk xZITcTp6VLJURP1hmYnFJh3czPSOsFPzawylp7bkIL6Itl5fniIl3O3wqzW0n3hn8v1+ iTXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Vz306RLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z3si6294942ejx.584.2020.06.15.05.55.43; Mon, 15 Jun 2020 05:56:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Vz306RLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730081AbgFOMu7 (ORCPT + 99 others); Mon, 15 Jun 2020 08:50:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:32908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729981AbgFOMu6 (ORCPT ); Mon, 15 Jun 2020 08:50:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4889206B7; Mon, 15 Jun 2020 12:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592225458; bh=opXdZXt2DFTPHJA+O55Kbh4HKBceFmOFhEyjhINS4eA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vz306RLiesNwax8KplFcYnagKnClmMl58mSEPOq40mt50jZY+UPNYS9wsGAby/EZI iH5tvl8s9qChdjSfTmDqHPFHBoqgpOGOGbSziPI3KfWS/Kha0gAQS754BoAokyk9eW SPuj2kVwkCIT7twI8wPFXBgMfgkDw9IkWfNhTc38= Date: Mon, 15 Jun 2020 14:50:45 +0200 From: Greg KH To: Tamseel Shams Cc: kgene@kernel.org, krzk@kernel.org, jslaby@suse.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, alim.akhtar@samsung.com Subject: Re: [RFC PATCH] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC Message-ID: <20200615125045.GA946844@kroah.com> References: <20200615122609.71884-1-m.shams@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615122609.71884-1-m.shams@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 05:56:09PM +0530, Tamseel Shams wrote: > In few older Samsung SoCs like s3c2410, s3c2412 > and s3c2440, UART IP is having 2 interrupt lines. > However, in other SoCs like s3c6400, s5pv210, > exynos5433, and exynos4210 UART is having only 1 > interrupt line. Due to this, "platform_get_irq(platdev, 1)" > call in the driver gives the following warning: > "IRQ index 1 not found" on recent platforms. > > This patch re-factors the IRQ resources handling for > each platform and hence fixing the above warnings seen > on some platforms. > > Signed-off-by: Tamseel Shams > --- > drivers/tty/serial/samsung_tty.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) RFC means "I do not trust this so I don't want anyone to merge it", so I'll just delete it from my queue and wait for you to come up with something that you feel confident with :) thanks, greg k-h