Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     wu000273@umn.edu, Herbert Xu <herbert@gondor.apana.org.au>
Cc:     kjlu@umn.edu, Matt Mackall <mpm@selenic.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: hw_random: Fix a reference count leak.
Date:   Mon, 15 Jun 2020 15:18:54 +0200
In-Reply-To: <20200613214128.32665-1-wu000273@umn.edu> (wu's message of
        "Sat, 13 Jun 2020 16:41:28 -0500")
Message-ID: <dleftjr1uglb5t.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20200613214128.32665-1-wu000273@umn.edu>
        <CGME20200615131915eucas1p2b8f3fa0ceb757e36aa888a4476de034f@eucas1p2.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-06-13 sob 16:41>, when wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count if pm_runtime_put_sync is not
> called in error handling paths. Thus replace the jump target
> "err_pm_get" by "err_clock".
>
> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> ---
>  drivers/char/hw_random/exynos-trng.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_rando=
m/exynos-trng.c
> index 8e1fe3f8dd2d..ffa7e0f061f0 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -135,7 +135,7 @@ static int exynos_trng_probe(struct platform_device *=
pdev)
>  	ret =3D pm_runtime_get_sync(&pdev->dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "Could not get runtime PM.\n");
> -		goto err_pm_get;
> +		goto err_clock;
>  	}
>=20=20
>  	trng->clk =3D devm_clk_get(&pdev->dev, "secss");
> @@ -166,8 +166,6 @@ static int exynos_trng_probe(struct platform_device *=
pdev)
>=20=20
>  err_clock:
>  	pm_runtime_put_sync(&pdev->dev);
> -
> -err_pm_get:
>  	pm_runtime_disable(&pdev->dev);
>=20=20
>  	return ret;

I believe this fix has already been submitted

    https://lore.kernel.org/linux-arm-kernel/20200522011659.26727-1-dinghao=
.liu@zju.edu.cn/T/#u

It hasn't been applied though. Anyway, thank you for your work.

Herbert, could you take a look at the Dinghao's patch, please?
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl7ndT4ACgkQsK4enJil
gBD/fgf+PrssB4H9APSVtgC1hd9Nwwi8U9rocQl1m7+V1pb7Vu9MFM4Hx1MRDHRr
mJZ5eW5fOHRVsU2z6ryFP1b7SjzPOjzvP+hItfGjwcbKXtCwwanaGxnHAbLsgYya
PS232AaRE6TShah294Y4LKyRK1b9rlebdrltcznt4ENzSPAadjOq/I1mqHBpz8My
yI45lWlJ7tFOokRtfwEWvUka4T/omtUbH27m7a2yVwGjmF45OAcqnxtqKNFlRPrS
j3+hIMwrNHq68s8o4YpPkj/K3OHFeFxgHLA+AUTvJrW3ZnKaPCstXoUCNMAPZJwV
aoev1fOx6RaRfte97fSLbNIi2m3sFw==
=UOtD
-----END PGP SIGNATURE-----
--=-=-=--