Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1675272ybt; Mon, 15 Jun 2020 06:41:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw19T2qU/7K1eekHa4a354foX7AatxWLpdLFhLwbs8rzWMzUIos1q97mmUzTiz+JsF73Q7Z X-Received: by 2002:a17:906:6b92:: with SMTP id l18mr26303204ejr.145.1592228494380; Mon, 15 Jun 2020 06:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592228494; cv=none; d=google.com; s=arc-20160816; b=amWzv1nzkxHVz3g+cqM5ckyLkPvHrDv6AD7NfJr2RI41sCQS/aK6jR4EqZgXXhNeS0 lkSCFM+EY4Wp4X1xdTS7mNbAsQIqZwsX2KwUbdOg9BKOftEkHfvc7GmqWwyMA5GzTD0h KN5PTKC2oaGoa1+s6IWYw4GbYd+d1AxBo+GjFKvAAH6wT/ZvkAQw2ZScn322HyNPbacf sG96uOJTeYY9D4PxMaZj82tVQ6ybStq/UFedQ4wnCdFHRDRlHGFnl0SVLL76sPUE2Yh9 jaUKT7sdSDyBQdueMRXKWpYyub577dStZlPPuxcuAYS7jcEL8toY6jJot2zz7s4l7N4a KsUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3qgnu+0GrnrqQvzQvAd3xvt44NOkgslNZc7hnvZJ0ds=; b=zElpDdUyjFL1Q/LTsDNF0PuSpgkHB5f3309mprYJ/r/o1iWZYpuyQXjk6X7JRBcGNt gEDy7LiO963xW5Bb7KzHGgxykCIoxJ26N+VFjVD9VkvK1qDyRQ7iQIsqxq8H5xZFyQ/G IsU07+zmEPmWhsGqj1lAXRvUAkcKn49ijY4YPEPoqWOx4JorgrJ3cp6vUJVMExa2nM8R SJF1EfitfGIGdkpkAyrLHw4xc5QC7zcSO+g0idZdwSC8meqt/oX7UV4k2BjAX/pwXVUz QKp1icCqa4LBfjnGkx7JtmOvbcIbr0BSewDRqq0ycySI7nbnN9pmIum1x/S/ffIufYy7 CM7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UaQFo1mj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si9088678ejt.0.2020.06.15.06.41.11; Mon, 15 Jun 2020 06:41:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UaQFo1mj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730484AbgFONjJ (ORCPT + 99 others); Mon, 15 Jun 2020 09:39:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:45464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbgFONjH (ORCPT ); Mon, 15 Jun 2020 09:39:07 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7E5B20739; Mon, 15 Jun 2020 13:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592228347; bh=3qgnu+0GrnrqQvzQvAd3xvt44NOkgslNZc7hnvZJ0ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UaQFo1mjO1ynSgYz/iXeLbPZFVmLmsMORfTDaLAo59EvK2SGMTpYWGtTGpBJAgiYx 5XVY6lBn7uGKdzbq6jizZLVR/t9EWPYZ4x1PZbWNbGNNfty1ph2HrUg3747QwTE+sK g/1RBnsV1QdoNPH/2NVOLxR0LwMgSe6/WlMuVcHk= Date: Mon, 15 Jun 2020 14:39:05 +0100 From: Mark Brown To: Robin Gong Cc: Vinod Koul , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robin.murphy@arm.com" , "matthias.schiffer@ew.tq-group.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200615133905.GV4447@sirena.org.uk> References: <1591880310-1813-1-git-send-email-yibin.gong@nxp.com> <1591880310-1813-2-git-send-email-yibin.gong@nxp.com> <20200611134042.GG4671@sirena.org.uk> <20200612101357.GA5396@sirena.org.uk> <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v7CWsE/Dy737oYst" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --v7CWsE/Dy737oYst Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2020 at 01:35:01PM +0000, Robin Gong wrote: > On 2020/06/15 20:36 Mark Brown wrote:=20 > > If we see an error in transfer_one() it could be from anything, we've n= o idea > > what happened on the bus - the controller may have got part way through= the > > transfer before failing. > Then how about choosing specific error code for such dma not ready case w= here > nothing went out on the bus neither?=20 Yes, that's what I suggested. --v7CWsE/Dy737oYst Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7nefgACgkQJNaLcl1U h9DWzwgAgNLfdSBegzo4C8SrkVYTpfvlAgdjrdeptqUR28cvfXCkLWGWKP746yJu xryCPDQEAA8Yn2LAl8V7oYvPaj+oBAZIzcwv4xcxNZK1h9rLUqmLJkbWkttPHUVx IcbbLwXlRrlx3orkN3wCIqvzRyRnVQ2/5VDV0Ve2tk/s09hbttNZB/XGX+ZjYXnY pM/PW4VOskZZ8SG5UU9roeIPPQOsKbTjFOO9A5PZnc6hGszNIS3GTrFwZ1b3X1Mg ksihianoVYK7jBAPJU/CBNuPj3LOp8EQJzpeGMnnFt4ZQQHssKxA0YbQdETcu7ZS d9yRgl1CHN1yTDEutwavhC7CgG9rsw== =0EvL -----END PGP SIGNATURE----- --v7CWsE/Dy737oYst--