Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1684237ybt; Mon, 15 Jun 2020 06:55:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7L1/v12hrSMgspUIQ071pH37/DX6XrP7iPWbwMbAU2jWfAyFzskkWFrHm75AsBkbCuQfC X-Received: by 2002:a17:906:c9d6:: with SMTP id hk22mr25035583ejb.101.1592229353701; Mon, 15 Jun 2020 06:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592229353; cv=none; d=google.com; s=arc-20160816; b=TrzMWYE8+SIo6qNV3uZjUf8RgGXue5YfbdmKu0oXTJiZNpp9saepQj7D3LT8WkWA8r 93DCFcX18Q+wAq5BU6KSFo5iqEi1v6xwceDA5Mpzwx2QNVWHU2W4aJGVrQeKKVX6n30L OZTd4ri8SFv2q3qkCXdK25SPXZ36ccROKb+bZsld9Q+hd1IglzqiLUz9eF5ew3MyIZlP S91/QQ7LZPRc4uK6nI4G7ODKCRSdWPgVlMUMFS0ew5doo9Xx3713I/R3zY1J5pq7wvwJ /Tq81Ro+oBJt5dui7CUsZ3Iw22dDC3XYPuzLUPlu+ae7PwPLzXefdqWRiW5E/4BDW2Il Nn1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to:reply-to; bh=x/WVmzq+qHfyCrALsMPkYUjRmnGjutKW1Nqpf4Ej1YI=; b=UQTVrkyMxUHKntW1uLiLuO7KzwkQT0hRsDtAAQ59VSzGUH7rjBxLcueHwPJpBsb1Zy jvve2aFiODv65kKbtCGdEwO3T4u7jW1UDUUXjnWvmdKe5mN4kfTlA+ceY2ZaZk1P97DE uBfwbI+KLvtZv7ksNgJo7DtDfgXReMsXCnOJV24ziROOBqMApJCTjvg94PQwlR278oCP 6K0RFlExnlyx0legv3fSUfMjFALLdzcdZvlH51YascCNOKwbfVmJfZUVeOTMuI8ggdS+ 6GrmR5KanPDIOREnLFnG/Ag2v/mxcCu/vAKjrRnUNqAA/bFN+DUksRgUxEU9AwG7mgvH FdAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 7si8182882edj.329.2020.06.15.06.55.30; Mon, 15 Jun 2020 06:55:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730173AbgFONvM (ORCPT + 99 others); Mon, 15 Jun 2020 09:51:12 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:33660 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730147AbgFONvJ (ORCPT ); Mon, 15 Jun 2020 09:51:09 -0400 Received: by mail-lj1-f194.google.com with SMTP id s1so19301326ljo.0 for ; Mon, 15 Jun 2020 06:51:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=x/WVmzq+qHfyCrALsMPkYUjRmnGjutKW1Nqpf4Ej1YI=; b=RRO2pdGAoQEmaa4y8fzUaOeR0NlEJ3bZRSII8DNC0G94rcOci0FONX5TFV9JMScKdD hw5+sJKv47mv10X5GzIQ+Q5SMj/QF/kSwh6xKRNMnQkXKaMb0CRLa70bSjdD1w/dJsfK 5uy9UE10FCdD1B/2vhZPKO9ksh+tgfoRNaK+IitvbWTRJUDFv+PJwKKQnNdA3KqLKXYe +VDhtU05NKX2nAULR2JBlcKVnf24n4f+6yNe/K47hHhXXBCgHIY3PzoIoJCUdyKxPaL8 GtBGgolgXOl+TaIrXjkYdsqK4a86WkQJwTF0hdr6S0rWXsF9fbuqzIbxa38IcWfv6mHh XouQ== X-Gm-Message-State: AOAM532xxU5LLi9GcovRMq6IdbzUMwe0364Tq69g/BWlMTKvj9kNtAzn xkQjJj5C2O5E/kqZC906YDDBURdEjds= X-Received: by 2002:a05:651c:10f:: with SMTP id a15mr12229630ljb.190.1592229067152; Mon, 15 Jun 2020 06:51:07 -0700 (PDT) Received: from [10.68.32.147] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id m15sm4535923lfk.65.2020.06.15.06.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 06:51:06 -0700 (PDT) Reply-To: efremov@linux.com To: Dan Carpenter Cc: Joe Perches , Julia Lawall , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org References: <20200604140805.111613-1-efremov@linux.com> <345c783b-a8cf-9dd1-29c6-d32b9b29053f@linux.com> <20200615120332.GJ4282@kadam> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Subject: Re: [PATCH] coccinelle: api: add kzfree script Message-ID: <99e46d3d-b651-15a4-df94-1b4aa3719954@linux.com> Date: Mon, 15 Jun 2020 16:51:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200615120332.GJ4282@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/20 3:03 PM, Dan Carpenter wrote: > On Sun, Jun 14, 2020 at 10:42:54PM +0300, Denis Efremov wrote: >> On 6/4/20 7:27 PM, Joe Perches wrote: >>> On Thu, 2020-06-04 at 17:08 +0300, Denis Efremov wrote: >>>> Check for memset() with 0 followed by kfree(). >>> >>> Perhaps those uses should be memzero_explicit or kvfree_sensitive. >>> >> >> Is it safe to suggest to use kzfree instead of memzero_explicit && kfree? >> Or it would be better to use kvfree_sensitive in this case. >> >> kzfree uses memset(0) with no barrier_data. > > Yeah. That seems buggy. It should have a barrier. Also I thought I > saw somewhere that Linus doesn't like the name and so that's why we have > the _sensitive() name? > Oh, there are already patches for renaming kzfree to kfree_sensitive. https://lkml.org/lkml/2020/4/13/729 It seems they are not accepted despite multiple acks, through. Thanks, Denis