Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1693531ybt; Mon, 15 Jun 2020 07:07:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyX59pTddtcYrsts/CFaP6kEexl7bpB940mNO9cd1N/le3qO4HXRuU0HQkQWl2wvIKHQYN X-Received: by 2002:a05:6402:1d89:: with SMTP id dk9mr23170130edb.275.1592230062041; Mon, 15 Jun 2020 07:07:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592230062; cv=none; d=google.com; s=arc-20160816; b=QxDSN+eav6MsEbd8/11pCvUqoywx1e+HUwSS+90E+1JL4zWZTMSbvDEccJRbt48CpS 0DsyhkXuF0OZZi+2gxbiBt6w/3YOQh3cjc7Vx46B4bSMnLB4hOSqYHR/HZBTiUDDzb76 I2C5q167P2mx0ptpT1zmgUBL4XF6doKC4YIRHCWg+aLPDnEVeWNwtJDiU5sg+sOYyY5/ PAVT1hTWqq6MAFsAmVXlu/zVyhhCVReYywSNIYVtTDC5liAjzqr9mZB8Qz6KNowpR4N4 iIOjKQfH70AqFHiU77Yc30frka1uhSHemLY6DjTrgv1RJjxpNgwz+GwejZaV8K/AxHly +A7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:autocrypt :to:from:subject:cc:dkim-signature; bh=hk+CSZozLHQGY5Yv+TZDKIvGhmGQvMqdSW4oM+db2wY=; b=Hq0JizGc/w1bizp5/1iB1amEm/oCaPfoLcnQthqKfEw5F3EkD4v7rpyN9n1LzWc1cU b/Sp93vGTDRq3INk4DB/wakZJ/wIgwURDeUhLqZdHkER9jzaRTS9enQQTOUZfvCVti5w cn4MM5hLsd0ZgYk/CPy2kgRIqTAjnsSBYaD3kv8pmQ/nOZw99OaVvPY/hywcn/Bj4S1I bBNiF04nY+KFntDoeVTmf7t3dyal7JXov6gZKQCD7UL0JZnf7NNiv0wQ4OgJZWAihl1t SrJPG5w2yxHJdoxEaS/nHoEVowIGh07mXEArndzyxEUW6HdVcm+NcBuOPBvyZOy7wxeZ lrog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=I8w6ve+Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd22si9043318ejb.754.2020.06.15.07.07.18; Mon, 15 Jun 2020 07:07:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=I8w6ve+Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbgFOOEv (ORCPT + 99 others); Mon, 15 Jun 2020 10:04:51 -0400 Received: from mout.web.de ([212.227.17.12]:44813 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbgFOOEt (ORCPT ); Mon, 15 Jun 2020 10:04:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1592229880; bh=4v21AZdQnfl4I0lRhOIakIYNWUq/Km4A1kjWkH+LG+k=; h=X-UI-Sender-Class:Cc:Subject:From:To:Date; b=I8w6ve+YKYhThZ5ofnfAiHqCU6Iq0GaKT36raCtasNO/C1hsYDcMCg+shCQretSDK 2R4ivxOfmD6Q7PJxZN5wEtYBPSi6Z0aUGucyr38L+j7sSnCB95rrOxEVML66BjUcO6 k/VGonGCrDOX31U126vWYT/MxzRNwupovNjzlGf0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.49.107.236]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M1o86-1ivkAs1QQU-00tnO6; Mon, 15 Jun 2020 16:04:40 +0200 Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: api: add device_attr_show script From: Markus Elfring To: Denis Efremov , Coccinelle , Gilles Muller , Julia Lawall , Masahiro Yamada , Michal Marek , Nicolas Palix Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <1f028ee6-b014-c240-21d8-0c1950334fe6@web.de> Date: Mon, 15 Jun 2020 16:04:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ZHx86tvl9ZN2Q273cNj9qJz+VxDh7ipJR+Ha23Z/58jiwxrAkuX sxDc8DXF1pHdiOrY0LFdU4Vpo65k11kXZvoTipRisB+u7lnegNmrRMfv0C2bUDYrEUUy7HC n1xDtOrB9aTNlkPLuNqg1otetrw8ccFOPcqdbIFs48bL+hn38TSmUQvqhJy3Fj5AYOjES5o D8FVCfiVrIFxi9w/I9lPA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0MtBwmoIY+o=:sedTTOKGnKCR6XboMZ0vhW T2BHiXqCdkej4yq+NYLSQVHjX1XTsTsNDK2IARqkK1hI5lpzfdM/kMqpMH83IfTyDbFc3cjM+ 6WZ7YhNIWvrrik/k2++CcpX89pZTDmgSHjdQLoV3I8QMHjtmQmqYHPGd4WIxiLQEFItX7t368 lOv1QOPblDh8BaVCNVTN6jplY+WBSbBQVjgxWKL8+eosRjUS4hhxwGWbpC8ivbNlBjKw3QfaF ZQGnnz/f8nETWUIzips7ModFvv7+yRL0xcRGmzpU0qVor0ojfbOYVUWoBi9gSxzjoY2nus7ca ne7aPKBS39CTg5X/1l8WK3EAOsfszIlN3CpHkjVPjbw5lurPV4QiIJzq9FeD0cIUHOapV9sSv jrOugx2ycYvxHXoO8LiIwdZouUPiKV0G5MuHjpDraPYzqudX7prYsXkHtrCIg4AaJDhYwT6UO 9xusztz7Xp4DwNnxZGgpm4cyf+wsXibQ3NZKEXvwTkHRIV99LJ/7NrRqy1q9W7fWNkS0GYsRi voyP4b62sHsTCo86AQWZfcsbNVT7CKGx+9yGdGJeqpxBimk3FQeueRYWmhMcI08wCCDhDYG/G MauZCP2tDVt3C0GaXMl0XcMr1G3kPZ3fGtemWvC+ySLitk2BjOGtHDYjI1gyK6FWNedhuNvkj 8Jg7Z5EM0FhvAC5CUmz6yNWg4ZbTAtuYmYHm1pIe+S8rg4pZXpGNXNx3r5lxjhw6mj02+v+aP v/GJ0AUgo5e/gDLzzXzgaTyyrzP8IOAum57wfk0BLKmG41+bgzpqw13FfgoE1AODiubWsFxzC IyrVhNNI+UWOx6sy7qrEtsrunbXKRb09MclwlgQAb+i0hZnwbF9ta9FRSDsrxxEbLKyLfX+rg CfjdNhlIFSQul/8N5a1VR5CUWprtcP6k8Eg9ZqpGBp822ub6qSv09jU32BybtDcDzypfQT1jZ fyzEEGnYvuxaowjcrwKGnFy51vtrepB9IDc6ISmhv1PkPqoR5kh8+DZqg62QbFI0Ai0mnSGuT YMafZGeEN3cBWrCn3yqQ8KTVY7nccAiT6s8/4h4LlGM8oTgbvC2BFgXmK1I6tpEJlt/rsF3RP XadVDJrJdyQLgNw8847sS5+aamRBiCaGxoBVZuWAJdw8dlnoEvdRj5rvYM5VjgGiZG43GEExz yajQKCTE89ozfsxOYmTPssT/y7T4m97guJniW/DAVIWt0p7mx/eWV8IOq/vC4tyJmVtCUAxq7 4RtZj0gWVAhtJjm2e Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +// Confidence: High Would you like to add any suggestion for a possible patch message? =E2=80=A6 > +virtual report > +virtual org > +virtual context > +virtual patch +virtual report, org, context, patch Is such a SmPL code variant more succinct? =E2=80=A6 > +ssize_t show(struct device *dev, struct device_attribute *attr, char *b= uf) > +{ > + <... > +* return snprintf@p(...); > + ...> > +} I suggest to reconsider the selection of the SmPL nest construct. https://github.com/coccinelle/coccinelle/blob/e06b9156dfa02a28cf3cbf0913a1= 0513f3d163ab/docs/manual/cocci_syntax.tex#L783 Can the construct =E2=80=9C<+... =E2=80=A6 ...+>=E2=80=9D become relevant = here? Would you like to consider any further software design consequences around the safe application of the asterisk functionality in rules for the semantic patch language? Regards, Markus