Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1717200ybt; Mon, 15 Jun 2020 07:41:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAaaHqBB/1WRmpuIvdYAZ1HxQAqcHDfavx/o1pCWBxhrbF0kMVncqSfVr/XXPtxkFH8/CK X-Received: by 2002:a17:906:4009:: with SMTP id v9mr25528082ejj.481.1592232091134; Mon, 15 Jun 2020 07:41:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592232091; cv=none; d=google.com; s=arc-20160816; b=HlQdTu6A/T9BlQ/aipHNE4ZH58kVIXC0EQEBjeI4Pm5iE8DiUbE92obtGK1vYX/oIW oKsNRx7yAWgJDvfjaj5RAxKi2Aat2R8qbRW4bd0oIXwtYOQVmzN7GKOM32HLGRt/iIhw DozUq2Xt5QKvwzunvY8u/AdN+D+CR4E1zRhMEMKi1BULq9oSA9p28/7rHTbtfKfm7oDC bBqdlW8JdX4NjRPJz7b7n+P0f3v4HLa9qvlrQ0kpU227V1OMMyfLJiwwnPBPrRY1mFfz 1s9BOh9Bz1WHB6QL/2EtJg9cfOTPskpHC+orTttf91rLVA+kf/dvHTINnFhIpD3GBZC0 gYgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=AlD+LICwiIvLTtYfnuORDdMvLerlM40fltHFm8HguOM=; b=zOiL0Ez02dM3/iW/ROMpS0+xmeaInzQ6Y/GmtgMv1ps07jeKrJSue8X/DPH0D814vH w3AWj7n25c66bpF4YZt5i3yewGA3nutUzJTytvK1vaoUGFxZXE437Rnsvu5ERglt2u1s NC07wQqEl7yNCD9irTNFSctl7ryBCdEwpdLrzcFtfQeYI8plc3OljsBO/s9u/L+TkzM3 PNHNY+/QGwcbgy1N9OBv7YSs79jg9JH4CdMH1FosR5jxBNWSqypq79QNFXBBtfPDpsFq EjtoczNrQUo488FycAoUhFxdtYgoSem40i+wd3rv9uaOnQ/YqgpLDey7Lz46EXf8pe76 +NFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Cz/M8iME"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g6si8338600edr.432.2020.06.15.07.41.09; Mon, 15 Jun 2020 07:41:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Cz/M8iME"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730627AbgFOOjA (ORCPT + 99 others); Mon, 15 Jun 2020 10:39:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729243AbgFOOi7 (ORCPT ); Mon, 15 Jun 2020 10:38:59 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D2DC061A0E for ; Mon, 15 Jun 2020 07:38:59 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id d66so7906243pfd.6 for ; Mon, 15 Jun 2020 07:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AlD+LICwiIvLTtYfnuORDdMvLerlM40fltHFm8HguOM=; b=Cz/M8iMEWh8OWbvja/EPnEx0btECakHXcsdrblbrdDTGLRbPcy6CZOpsFeQVJ2FGZz /6j9sLx92AvAQzPITwU5GaPHOfTiw7bM9q1LRlV9xmoz7QdLa3xA46nJ9UkA7rujWngW 8FkRD/2tP/pqaOjwSDPMui1ktuCk4YtyxHGLTzd44rN8kGown+rFsmhfM8WJ02t2MrUi ZGSCUWKUo9j+XF64O9IZYGrpeeiB1UKvrS8/CoGlDYJWaBTINSCRhVxI/1h/73GlDhGC vWqsrzR5oK7Mu9cxdcK4JxTg0syHXBn4FSedCXbVxu/LIJj1BxSdVXePGm8bOdKSsP56 NE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AlD+LICwiIvLTtYfnuORDdMvLerlM40fltHFm8HguOM=; b=ZW/XDp34b6s8qfM1d3ummJz5b2+SP9V3g7rz2GgWVst2aLS6zQ0ZxXvmZSYv+xK3FR bSwZaa5fD8WXzp5UMZgHBWRxSrbKaIpegWFnyMEdDGrYYe4Cli5cizqWiTNfTwVBbMQn HpASXzE2MK9llE5xm5kLS1YfZpJvxepYV6uDJE/naPNX0U8fPn4QDfomu4f6jmYUWG8g obyGT1dUc1DLoDaWaipWIBHvFBZEkgD8rVAzTI4+gBZ3u2v16AcYHwSExNkglvBpeOnW Ez8bwLEfyOj748nTxmqtOmQY4KfumWfZ9arkCp5WmRo8zC7rw+wOYlvi9VKsVmoHisBd qp+g== X-Gm-Message-State: AOAM533IscmzcHzcVz3lNpB53eU93xvfZQzZ2RMfTrQKKDwJI7Aa7xwN 0S9wwol1zfdyyv6HRDLJ9FC0hw== X-Received: by 2002:aa7:9d02:: with SMTP id k2mr23687864pfp.288.1592231938656; Mon, 15 Jun 2020 07:38:58 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id 4sm3732181pgk.68.2020.06.15.07.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 07:38:58 -0700 (PDT) Subject: Re: [PATCH 1/1] io_uring: fix lazy work init To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jiufei.xue@linux.alibaba.com References: From: Jens Axboe Message-ID: Date: Mon, 15 Jun 2020 08:38:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/20 7:36 AM, Pavel Begunkov wrote: > Don't leave garbage in req.work before punting async on -EAGAIN > in io_iopoll_queue(). > > [ 140.922099] general protection fault, probably for non-canonical > address 0xdead000000000100: 0000 [#1] PREEMPT SMP PTI > ... > [ 140.922105] RIP: 0010:io_worker_handle_work+0x1db/0x480 > ... > [ 140.922114] Call Trace: > [ 140.922118] ? __next_timer_interrupt+0xe0/0xe0 > [ 140.922119] io_wqe_worker+0x2a9/0x360 > [ 140.922121] ? _raw_spin_unlock_irqrestore+0x24/0x40 > [ 140.922124] kthread+0x12c/0x170 > [ 140.922125] ? io_worker_handle_work+0x480/0x480 > [ 140.922126] ? kthread_park+0x90/0x90 > [ 140.922127] ret_from_fork+0x22/0x30 Applied, thanks. -- Jens Axboe