Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751020AbWCWKGU (ORCPT ); Thu, 23 Mar 2006 05:06:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751048AbWCWKGU (ORCPT ); Thu, 23 Mar 2006 05:06:20 -0500 Received: from jaguar.mkp.net ([192.139.46.146]:57023 "EHLO jaguar.mkp.net") by vger.kernel.org with ESMTP id S1751018AbWCWKGT (ORCPT ); Thu, 23 Mar 2006 05:06:19 -0500 To: Kristen Accardi Cc: Alan Stern , linux-kernel@vger.kernel.org Subject: Re: [patch] add private data to notifier_block References: <1143061212.8924.10.camel@whizzy> From: Jes Sorensen Date: 23 Mar 2006 05:06:17 -0500 In-Reply-To: <1143061212.8924.10.camel@whizzy> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 17 >>>>> "Kristen" == Kristen Accardi writes: Kristen> On Wed, 2006-03-22 at 14:04 -0500, Alan Stern wrote: >> I still think this isn't really needed. The same effect can be >> accomplished by embedding a notifier_block struct within a larger >> structure that also contains the data pointer. Kristen> I thought of this, but felt it would make for less easy to Kristen> read code. But, that's just my personal style. I'd have to vote for Alan's side here. Thats why we have the containerof() stuff. It also means you can embed more than just a pointer with the notifier block and it will generate more efficient code when doing so. Cheers, Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/