Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1727840ybt; Mon, 15 Jun 2020 07:58:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6wzus3qZtISSKHOrv4+T/lXwYyU5GlkzIU2Te47HK7yBW66Sv+baMjhLTHwVDODrum1ie X-Received: by 2002:a17:907:217a:: with SMTP id rl26mr25428654ejb.209.1592233088927; Mon, 15 Jun 2020 07:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592233088; cv=none; d=google.com; s=arc-20160816; b=EJkuHgZRn+8t25Gqy5niOjdou+LutQp7cAfFFBv64KGrsy03xgfEay9ww5mKdOeZRd K2Mwq5bs3stejaNLK797lhqLeGHVoW+MDxA87LOzgp+S3dyRbj93QuGilL7jahtI5dVI 8EAdWdQ4YBQTTWAxCcyw/SfBwauKdeRm/J9TQOH3ADK8pBxPoNyGqaIugEPwX+JjIvt+ z8M3XaXm/yD+pzIZnZMyTYg+suNdQywOENF2ZSHSmKuPC2ToR0XLqvsdBR8dqQ0UG1BA QxVxq6+bwCf11rMOGWDxj/vZMNyTXoJYdIBrSw4jbmnQOaK/xjH1Ys4zY2YP5o1J/N8I cL9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2TC//kCSiqr/n1JFxAXwx0DjT4t5nRNJzXNSfvJPnHQ=; b=cIWI0SpMqw0p8+V6b4SH4LF0x7LOoJ/JJjJ6YbXAMdJTvCO60WYcVqPCONsComjd1R 3PQYpqTk0oJW6RqOFumuKWRexLM4+EuqcFbWXptoUTfNftPsqqAIQN/h9nqCXyzMQOdL BW6rkTxz8M21GsXjoXTM7o3kXy45DBPmEOUqiaCEXyZZ4Kx//0hrBh5MXqmdtvhO21AD vgMAWpJ+H1ym6/DMu8et0jAsSa1+ynJQswV8Im7tHvB68YvbU8+1PkQVlBonWWNESrj2 0WvKfkr4FNcDh9E0qdn9gpY8pNGeUlf3Qp9wg75hYDhL6DmI33D+dOVlxxHP1N+RlQLE wG4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WAzQ4fSL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy2si8464365edb.36.2020.06.15.07.57.46; Mon, 15 Jun 2020 07:58:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WAzQ4fSL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730767AbgFOO4A (ORCPT + 99 others); Mon, 15 Jun 2020 10:56:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:43552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730213AbgFOOz7 (ORCPT ); Mon, 15 Jun 2020 10:55:59 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1B7E20644; Mon, 15 Jun 2020 14:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592232958; bh=2TC//kCSiqr/n1JFxAXwx0DjT4t5nRNJzXNSfvJPnHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WAzQ4fSL7Ni+8MhSFeK+hvrEhia4ExOvj7gnafrN8h09OzqA8zOjGsggpxgqezOZb /FiV+/68Cwz+OQkYgCZvTdup8NA67tIxQiZtGhIeChI9QUQ1HW4FBBZ+bwiaqevDRJ hcqc3jkKbV2Vqns7sVYJ1qD2BUt+qAK841dWOONM= Date: Mon, 15 Jun 2020 15:55:56 +0100 From: Mark Brown To: Robin Gong Cc: Vinod Koul , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robin.murphy@arm.com" , "matthias.schiffer@ew.tq-group.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200615145556.GY4447@sirena.org.uk> References: <20200612101357.GA5396@sirena.org.uk> <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lPJ5i9rX1WvdYcWF" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lPJ5i9rX1WvdYcWF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2020 at 02:53:29PM +0000, Robin Gong wrote: > On 2020/06/15 22:36 Mark Brown wrote:=20 > > We could also pass in a flag that could be set separately to the error = code to > > indicate that nothing had happened to the hardware yet. > Do you mean spi-imx.c checking 'ctlr->flags' before return such error cod= e? > Or just like below done in spi.c. No, I mean passing in an additional argument which can provide richer data than trying to smash things into the return value. --lPJ5i9rX1WvdYcWF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7ni/sACgkQJNaLcl1U h9DpXQf9G2jk6fHADMgZvO5cMWF40DK3HTy0XpAr55BZ3EtoJ9SfnWU4hvTmyvn/ 9gWPmaXi84y5Uq1tvrYZXp70urjy0GAgJD6gpSDPq1PPql9PhVdPtOWg0K9KYt1r iGep527JQyKrorlKPIZ1SLN/9qxexF4GMjkyR7Bjx4H9rrSCKyG+TLrNFGQZL0ft Z93yp3K+RJb8TfYwIF50LbTix6pY4mTd6kNG7rd4RLinkGjBWZWnbdwKQkgBeffM qKVL0ySu1Pgd24bOR6aCKQxdKuCAyxj6dy5Hwya7ZgryKH0eVDdS3P0Vx5pqXS1l jXQt7/A7B3EFdjfQTsqDuDAuACaijw== =lGYg -----END PGP SIGNATURE----- --lPJ5i9rX1WvdYcWF--