Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1735247ybt; Mon, 15 Jun 2020 08:07:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0WAFERmrKR27TO6LrFxV488S+8cjrS3SmAIg+hkQbbjmjBbksoFebMYwrllafGBFHKBMn X-Received: by 2002:a17:906:5645:: with SMTP id v5mr14264473ejr.533.1592233641784; Mon, 15 Jun 2020 08:07:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592233641; cv=none; d=google.com; s=arc-20160816; b=OE7Llmj1yBEl7cQ1Ii/1RTaVGP5JTi5vfxr604iySrdKs3QbYk1ydHKi6d5bwI1X1I omPiogI6JVKCpn64rh42ghyikBcxZKMrj/RW4gYWzluwQKO1vvW4zF0TJesHQ5oVncUm t5pKUcnk8Rf3WsP7U9aMKrpmjXZUqrG051Hp8/l/JfOznd5UGUPN+dJI/AmA1kg2mfpQ uZRXq+RJi8ISnBloQhL97KLUCx79zMjHuz5ocVRwG3c9zaf/+nVfovGEIPDT31LqjVdB O4lPS4bTnN7I2H8GJUHZiLGCXjZzFQ1YvfihmEEf/Wn7al5xsME5kJbMAewKo5U/8AG7 zgtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=vbfKhiMK9FyLJ1R4wzHm2mLCW6oCsbN/2Vi0OJTPAQo=; b=M26aEkyaVV+6z+nPZhehhEWYTy5C287pjDW3PZ81RLxANrUGcjNunXDi3xicmYOlbg IxkN2U0YAEpAVoER/tw3MNMkosP66HoQm3FefCbF9rcfgK+Aix7183vI61fOg37eU7k2 k4xVxeeqRtgqn6yCdkqWOwXlvPd/gSAdjP6cReiEce+HMvAXOj0isVRIjhhV4JjxuWNR R1fdQe4+k/byark5Rtj2js7RyHZdwHGOT5R5L37Tq1MW4yQe3m3ow+HHohExXHpA6DpF fBIF/sYgjbMQXJL8oOtN0ouZqn+YlAmi5x/0eZmFx1TFlfwCucs5ZL83RqxKBaGOHBEg CawQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=UV0mod8b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si8505701edr.104.2020.06.15.08.06.59; Mon, 15 Jun 2020 08:07:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=UV0mod8b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730935AbgFOPFA (ORCPT + 99 others); Mon, 15 Jun 2020 11:05:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730213AbgFOPE6 (ORCPT ); Mon, 15 Jun 2020 11:04:58 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA153C061A0E for ; Mon, 15 Jun 2020 08:04:58 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id 10so7922750pfx.8 for ; Mon, 15 Jun 2020 08:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vbfKhiMK9FyLJ1R4wzHm2mLCW6oCsbN/2Vi0OJTPAQo=; b=UV0mod8bg56pi0FyFJpgtMlX23de2Qm5wpkixqrt/9rDVU8HADl5f3aptV1rzGXfOc pdvaO1DPQw/7ZN2yh1ipYAxvd4STNxMN40fG6yYJjYYciSOWbbK2xQh43Sme7Bfh+0dH gH8kOHv7RSrwH7tVO8IdxgjKLzQNji9ociZNigE12wE/ZOjwhHaELO4xGjKlIkrkUYDF LWMMZW1dQT2alUOz/xDDBxSE98NHQ1W4jGIm2ZLc2VCNpTjzzK89m0oSUfByWMXvEaMA 2mPQPJE+ZJTMGqO1PcUvZZZXmRFNbXYJKIo++8x5u6P+7OLhQ+5H86ksYFaBwEQnd8Vp U4bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vbfKhiMK9FyLJ1R4wzHm2mLCW6oCsbN/2Vi0OJTPAQo=; b=CMt3vS8VdAAyy8cO/0J19e3Iq1b2Aej2n0oWIZpSZLhLtWGWC24sBDEU12qMulXVeU VItq1viifPXh8olDbKHXN+r5F+bdraRdgnRFgIMUr6LnM8k00FuNa9ecT8rptRxnZ2eW B/TUa7qxP+NrnsM1B3BCiDlXfqWCgf4wq5k/o3STECjZPugQLaxWUYSbQqyJT+nL55YB M7UhrQAR/yraPj6r2geAaWPKytq+lndvJx5WHz3PTFA2qcGq4hGqKaQzZ9v0JMRSTGIA onwObR76NWagH8Nlkkanzl0qz+x15SaOzYAsOjsEwkz6lp5nrGZYGu5/PxnyzXSmIfcW XlMw== X-Gm-Message-State: AOAM530xuw+zVwN4tzrKNS9F7/ofwj0kwweRYOWq63ZgVRhAb9x0Yd84 LcPCnFsolY4fURaNqJ5aSI/gAw== X-Received: by 2002:a63:5c55:: with SMTP id n21mr20644016pgm.27.1592233498289; Mon, 15 Jun 2020 08:04:58 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id b10sm11376026pfb.110.2020.06.15.08.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 08:04:57 -0700 (PDT) Subject: Re: [PATCH 0/2] don't use pid for request cancellation To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ebiederm@xmission.com References: From: Jens Axboe Message-ID: <9b90fd1d-c60d-523a-b6b5-6c960ae52cc6@kernel.dk> Date: Mon, 15 Jun 2020 09:04:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/20 1:33 AM, Pavel Begunkov wrote: > Cancel requests of an extiting task based on ->task address. As > reported by Eric W. Biederman, using pid for this purpose is not > right. > > note: rebased on top of "cancel all" patches Looks good, and I had the same thought of not grabbing a ref to the task for the cancel case where we don't need to dereference it. -- Jens Axboe