Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: nlrtp3eyU/HDFQKIeApEjtQvDSAlshpBQdUDwyKevWChHyh1vzCstlE28vcHfGo7u04W5DoNki
 M+F0hEHZpj6w==
IronPort-SDR: 6SFypKTBpRlY7Mnr1WCg9THktGjkywNwtBYqVdwfHUCMYJuTX/fawFASI/Q7gbeaDJ7k+7FhcE
 2eYIc6limDzg==
From:   "Brown, Aaron F" <aaron.f.brown@intel.com>
To:     "Chen, Yu C" <yu.c.chen@intel.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Kok, Auke-jan H" <auke-jan.h.kok@intel.com>,
        Jeff Garzik <jeff@garzik.org>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Brown, Len" <len.brown@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
        "Neftin, Sasha" <sasha.neftin@intel.com>,
        "Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
        "Chen, Yu C" <yu.c.chen@intel.com>,
        "Stable@vger.kernel.org" <Stable@vger.kernel.org>
Subject: RE: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device
 wakeup is disabled
Thread-Topic: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device
 wakeup is disabled
Thread-Index: AQHWL5mc0ngXWRQgFUqdbYRE2QINUKjaLL7A
Date:   Mon, 15 Jun 2020 18:51:27 +0000
Message-ID: <SN6PR11MB2896298A90B37CEA0DC5A750BC9C0@SN6PR11MB2896.namprd11.prod.outlook.com>
References: <cover.1590081982.git.yu.c.chen@intel.com>
 <9f7ede2e2e8152704258fc11ba3755ae93f50741.1590081982.git.yu.c.chen@intel.com>
In-Reply-To: <9f7ede2e2e8152704258fc11ba3755ae93f50741.1590081982.git.yu.c.chen@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f487dd3-b252-4d3c-0a7d-08d8115d1c39
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2020 18:51:27.4229
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jPSJTVL3a2YaaB3poOIsnXyLFBA7g/uPfgPUkbVph+WajP/t9XOxP96SViQJq8XJC6u/EkvZzlCQjB8qmaBKeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3504
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Chen Yu <yu.c.chen@intel.com>
> Sent: Thursday, May 21, 2020 10:59 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Kok, Auke-jan H
> <auke-jan.h.kok@intel.com>; Jeff Garzik <jeff@garzik.org>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Brown, Len <len.brown@intel.com>; Rafael J. Wysoc=
ki
> <rjw@rjwysocki.net>; Shevchenko, Andriy <andriy.shevchenko@intel.com>;
> Neftin, Sasha <sasha.neftin@intel.com>; Lifshits, Vitaly
> <vitaly.lifshits@intel.com>; Chen, Yu C <yu.c.chen@intel.com>;
> Stable@vger.kernel.org
> Subject: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device
> wakeup is disabled
>=20
> Currently the system will be woken up via WOL(Wake On Lan) even if the
> device wakeup ability has been disabled via sysfs:
>  cat /sys/devices/pci0000:00/0000:00:1f.6/power/wakeup
>  disabled
>=20
> The system should not be woken up if the user has explicitly
> disabled the wake up ability for this device.
>=20
> This patch clears the WOL ability of this network device if the
> user has disabled the wake up ability in sysfs.
>=20
> Fixes: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver")
> Reported-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: <Stable@vger.kernel.org>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>=20
Tested-by: Aaron Brown <aaron.f.brown@intel.com>