Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1913011ybt; Mon, 15 Jun 2020 12:43:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygQfLCW5BcduALSDxUikshYOmNUHBdrDRXokKVX3cgWHRvj+GpN05dc2Z0Tv9HmoNQT+Zi X-Received: by 2002:a05:6402:c06:: with SMTP id co6mr24590579edb.298.1592250234679; Mon, 15 Jun 2020 12:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592250234; cv=none; d=google.com; s=arc-20160816; b=pYQTxsqxcjXpyX6RIaqFZegH5HkCJxHImQH6MI6ZgAJM1JGbcC+OlC9RVq04ZVMjkz NwFh1nU5Yvvo6kPrYP2tBCKpXxbxoJHN2DJIYPAQqWGrKGgZzI+CPmDwWqET/jaaBuP7 ZJVQuMdxdfpw/bZRNhxTnaZRKogOCaWDfbzMxXJaV50b7bfnc5tCDvRANh1Gxr2n3Q+o 6UGcPCU6pbd4pQKNQxxaWIhXwt5YY988ZVBTvwfuzXkATnxXDLDQUNA4cWJlq+hm1ueT 7UKpKnRmL90ss0G3s8A1TkxYH/SQgweoPGdGfQmh6kUJomTJLiLf/KzAfZeQTbt6cC8O NThw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=4s29RXI4DZmoz7Uu9spIoKDjM10KzT1NJ7eoQ6iGuKQ=; b=eDPUN47FPLlF3xiBFTtwohqzg4FwB2tvu6RDdIrS+s1EcbvBrvGzb7wCarb0msu4yP cjX1f5WyKtAZNg2/04J8DxTNvnxEnRvNZ5HvYKpjYO++kfzIIfuqfHTN4ZDwQbBkG+ya mgNiWzYm1dxS0618Ra5SE0/o+4dWNzJ1lStzjiZGBfjnignHlB2U9gJwyexDDlxhQuU+ y6wQKjwoEjNt8370FJAtNCv1BxOSda6swiqme3SPMyvwwhQGBqKNE7Ox6tVO6NyxucxE ES70SEUl5mg2oIotyGDhs88j4VweiCf/bIIAKfxJTOopjk4+iFN70vL19AN1qJ/v0I6b GtaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b="O0zD/ign"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zo8si9079344ejb.156.2020.06.15.12.43.30; Mon, 15 Jun 2020 12:43:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b="O0zD/ign"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729898AbgFOTlC (ORCPT + 99 others); Mon, 15 Jun 2020 15:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728571AbgFOTlC (ORCPT ); Mon, 15 Jun 2020 15:41:02 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B54C061A0E for ; Mon, 15 Jun 2020 12:41:01 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id p18so12390287eds.7 for ; Mon, 15 Jun 2020 12:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4s29RXI4DZmoz7Uu9spIoKDjM10KzT1NJ7eoQ6iGuKQ=; b=O0zD/ignX49ZyEfuD6nUnsJTM4Z2o6FY8NMNsDmSNfe6aQVWNrOXTRTPjuGCOQ7uCB k9fwQ/N07Of5R++0Wqywf7IkNDOTgpQYrKqFq25Z4tEh9kpSx0iQG8sB0skjvtknQbe8 LAlKIYFmc59bA3kzhgA6+V+U1gaq//XY0YNfP9M1mcKrtpnepdygD4ppBX7FT2nrwDnH SQHjoOUEzTNzr7VSEmdqRr8gky5IcYTdj1QWaJduNkBbFQDElcSFHxEf5PNUM5ITYStm 7DRJEHhlCSLXRKelwGOwYMezexaBwP1VefdC3djrn0BKXNFFcPnyNgUmAm3/YL88FCYy QPOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4s29RXI4DZmoz7Uu9spIoKDjM10KzT1NJ7eoQ6iGuKQ=; b=YGLTLccEvXf1uxSPbt8BX9ao2VLIL/19spN+e1ZrgdTiIveynjcg9bbRJ/HzE8E6lV IAs9bJQi/cWj1Tm5bD8XbFxPIKxQw65LmzMsH73VaM/L1yqUqwFCko8lAhzWNCPYO+yB V8cuXmpu2y+gd6FhWbHlptAAPRrPchIyVMExAZ9X+7j5/3J8IqY1a+2ylYjE8staZKuk ZsMcReKJxagQyuH3Sh4cvIQq+wYjgXTFdwv7xwjSCZsdDWrk0y6aCHITcmubAm4Rm1M3 Ft5RAuyY05tQMQjiLT+Ip9HLrMjUO1cBv2R0WwRKjmnF/9mkaWow1HTY4FPV97XDWd3u JuCQ== X-Gm-Message-State: AOAM530a4MxgwVXZzyScu2Spf9MqKAFBme6RI64xj3xxgO9m8znlpKBi Cj6ruvp2sYlsB0HCcEW6+PUy+hTYAnU7sVM+SuLBJg== X-Received: by 2002:a50:c359:: with SMTP id q25mr26045616edb.123.1592250060573; Mon, 15 Jun 2020 12:41:00 -0700 (PDT) MIME-Version: 1.0 References: <20200615124407.32596-1-vaibhav@linux.ibm.com> <20200615124407.32596-3-vaibhav@linux.ibm.com> <20200615125552.GI14668@zn.tnic> In-Reply-To: <20200615125552.GI14668@zn.tnic> From: Dan Williams Date: Mon, 15 Jun 2020 12:40:49 -0700 Message-ID: Subject: Re: [PATCH v13 2/6] seq_buf: Export seq_buf_printf To: Borislav Petkov Cc: Vaibhav Jain , linuxppc-dev , linux-nvdimm , Linux Kernel Mailing List , "Aneesh Kumar K . V" , Michael Ellerman , "Oliver O'Halloran" , Santosh Sivaraj , Steven Rostedt , Ira Weiny , Piotr Maziarz , Cezary Rojewski , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 5:56 AM Borislav Petkov wrote: > > On Mon, Jun 15, 2020 at 06:14:03PM +0530, Vaibhav Jain wrote: > > 'seq_buf' provides a very useful abstraction for writing to a string > > buffer without needing to worry about it over-flowing. However even > > though the API has been stable for couple of years now its still not > > exported to kernel loadable modules limiting its usage. > > > > Hence this patch proposes update to 'seq_buf.c' to mark > > seq_buf_printf() which is part of the seq_buf API to be exported to > > kernel loadable GPL modules. This symbol will be used in later parts > > of this patch-set to simplify content creation for a sysfs attribute. > > > > Cc: Piotr Maziarz > > Cc: Cezary Rojewski > > Cc: Christoph Hellwig > > Cc: Steven Rostedt > > Cc: Borislav Petkov > > Acked-by: Steven Rostedt (VMware) > > Signed-off-by: Vaibhav Jain > > --- > > Changelog: > > > > v12..v13: > > * None > > > > v11..v12: > > * None > > Can you please resend your patchset once a week like everyone else and > not flood inboxes with it? Hi Boris, I gave Vaibhav some long shot hope that his series could be included in my libnvdimm pull request for -rc1. Save for a last minute clang report that I misread as a gcc warning, I likely would have included. This spin is looking to address the last of the comments I had and something I would consider for -rc2. So, in this case the resends were requested by me and I'll take the grumbles on Vaibhav's behalf.