Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Jun 2020 13:20:31 -0700 (PDT)
Message-Id: <20200615.132031.260816488025362367.davem@davemloft.net>
To:     bruceshenzk@gmail.com
Cc:     jcliburn@gmail.com, chris.snook@gmail.com, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: alx: fix race condition in alx_remove
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200615155029.21002-1-bruceshenzk@gmail.com>
References: <20200614165912.25622-1-bruceshenzk@gmail.com>
        <20200615155029.21002-1-bruceshenzk@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Zekun Shen <bruceshenzk@gmail.com>
Date: Mon, 15 Jun 2020 11:50:29 -0400

> There is a race condition exist during termination. The path is
> alx_stop and then alx_remove. An alx_schedule_link_check could be called
> before alx_stop by interrupt handler and invoke alx_link_check later.
> Alx_stop frees the napis, and alx_remove cancels any pending works.
> If any of the work is scheduled before termination and invoked before
> alx_remove, a null-ptr-deref occurs because both expect alx->napis[i].
> 
> This patch fix the race condition by moving cancel_work_sync functions
> before alx_free_napis inside alx_stop. Because interrupt handler can call
> alx_schedule_link_check again, alx_free_irq is moved before
> cancel_work_sync calls too.
> 
> Signed-off-by: Zekun Shen <bruceshenzk@gmail.com>

Applied, thank you.