Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1945121ybt; Mon, 15 Jun 2020 13:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEi2BAcx6wW37OiRAfhYVAFbTLeBNB4FYr6aQBpZiTRhJmB61NmBtTb0NEMAwiTtMKCIHG X-Received: by 2002:a17:906:c2c6:: with SMTP id ch6mr26658325ejb.36.1592253665102; Mon, 15 Jun 2020 13:41:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592253665; cv=none; d=google.com; s=arc-20160816; b=iukiv1YmzZfO7PbWbbi/sJAqQkXBhprw3/6kjE2GXHlNXqxnk+bsMHLPPOZ1wwODxs W20VSsuayQL4c2AkuAwRqMzQZbh3ZKmRdsFm30XQuVpKxB3Z7gRkeBIRlAysfirKeY/v /rypzEYFZ3cflY6c23vhM5GD+tlX6icXIWFajxg2gByc7IkfZYi8nwxb6jInf/6KpufD JzAr3rXB4bsO7TvN0h43TaZbXU1nlWXU1lozRVJtKwJKoL+aujJ7Eelbds6YT6cUpwiD 6wba+z0KAUfxsK2csbPNZfSedhF+xJ6CjUCDR3RBw+oHHfud1Fr8NA3Ap9WtoFDD6dCP 27OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=aqPEI8hMtDDM5vcocDM4KB5MWrHmSe1hjRY5BPfBM/Q=; b=mncpq0klSETfk1ALFzTVJ/NfjbtAFVTdN0bVB8Xkz2C0adPr8qaUvmy23AcxUJ1mAR iN2+b/GIEvYmaTCfqYEMFaeJbDqoZwLIS14OQSztf3MEWXgEL3BH3hkq2RQ1zY/TFyXs YARdNfUzdBVEyTYjKJeaiWa89x1Cr+pdacX1ughpLKZk/kb4TZpXYOnbX24HtfBzZjSo 25P/h6Z3eiw8mvK0cqeE/NP96C5I+UTx9xUjxGRsjfZLbvt9/r122HthcHR2yndfpgp8 EYWi0XJQBvF+o0O5O4jYGnRg8JKZmPIjoUu+eav9pSkXjlbYUkOteFYjvqnanHMN9HKW cDOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g6si8822566edr.432.2020.06.15.13.40.43; Mon, 15 Jun 2020 13:41:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731547AbgFOUiK (ORCPT + 99 others); Mon, 15 Jun 2020 16:38:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728346AbgFOUiI (ORCPT ); Mon, 15 Jun 2020 16:38:08 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6156C061A0E; Mon, 15 Jun 2020 13:38:06 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 10DED120ED49C; Mon, 15 Jun 2020 13:38:06 -0700 (PDT) Date: Mon, 15 Jun 2020 13:38:05 -0700 (PDT) Message-Id: <20200615.133805.1327699493804622026.davem@davemloft.net> To: pakki001@umn.edu Cc: kjlu@umn.edu, wu000273@umn.edu, jiri@resnulli.us, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rocker: fix incorrect error handling in dma_rings_init From: David Miller In-Reply-To: <20200612202755.57418-1-pakki001@umn.edu> References: <20200612202755.57418-1-pakki001@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jun 2020 13:38:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki Date: Fri, 12 Jun 2020 15:27:55 -0500 > In rocker_dma_rings_init, the goto blocks in case of errors > caused by the functions rocker_dma_cmd_ring_waits_alloc() and > rocker_dma_ring_create() are incorrect. The patch fixes the > order consistent with cleanup in rocker_dma_rings_fini(). > > Signed-off-by: Aditya Pakki Applied, thanks.