Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1947115ybt; Mon, 15 Jun 2020 13:45:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUdsYaxJkymwSaR5qbcByRunbkLMmDs5wCDJiqiWslJWDQcYifuMl1jm9H2vQW+QIvy1Np X-Received: by 2002:a17:906:7acf:: with SMTP id k15mr28158662ejo.410.1592253904495; Mon, 15 Jun 2020 13:45:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592253904; cv=none; d=google.com; s=arc-20160816; b=as8n1jqGmbvFO8lhBjQ4vDaOC4a56TViede/grtwWxj9GSp6+21RYpgH+Fowh0pYBy q2x6Hv5VZoFPxCEttTzaNPskyHUPBZS7OGA8AWd+HnsfKiT7Cl7pSqaFcb6mwfbhoe3u 7h09oFUuwKus2PscOOCd8e4vHdSlTzkhP4eHK4MREObqwQGT38zXhLW0l9v5RqvfM/Kb Uib5dOMHOVw1CRIIeufsVaCyXv17WPOK9gHZtpcfrIXHGtVCzLRm6bf95U+PV9+g31O1 Ss/OmdF7iJ5p5Rao1Fuycr4c94pcME5LU2zJ9bDwnHxxkG1ijKxK5FbzLdtzemqsKcnj 6Itw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=0KWTm7I7BSw4BrzXecDroMX8xqsE4DONbBJmJFRXQjs=; b=MwzhaR2Vg7ZFKkSxOD+dZAOBOpUBLurUP2UXnN9ZHnNa7E5gUsC4ayBH6Wej0xe0cI eM4n9Ho3nwN4APXWb5xbcEUe6ApREvHmYM5Skwt0rApgMHN6xAzlvN0TDIu3sLmLa4nt mSFrhTLjXK5uKAmmtNCv4HE/o4V8zP21aKsf3VQzv75CMX+QotcpkL8yT5RPS7jcPIX+ iiKFdYx+Tb/3K5Jmchombz/5FFejf8f1dxcyGejwlvFNBQZ1hyXJ0uqQdgfmD6s3BaIO CRVLezuRmm+6bKnTuX7YDfMIUVcQoT7FRpHHyCUHWDIve5Bv02zncU8wVypyGcMYbWYb eT7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt20si12540528ejc.24.2020.06.15.13.44.42; Mon, 15 Jun 2020 13:45:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731561AbgFOUmR (ORCPT + 99 others); Mon, 15 Jun 2020 16:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728346AbgFOUmR (ORCPT ); Mon, 15 Jun 2020 16:42:17 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C15C061A0E; Mon, 15 Jun 2020 13:42:17 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E6509120ED49A; Mon, 15 Jun 2020 13:42:16 -0700 (PDT) Date: Mon, 15 Jun 2020 13:42:16 -0700 (PDT) Message-Id: <20200615.134216.1492983787088475104.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, mccamant@cs.umn.edu Subject: Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get_sync fails From: David Miller In-Reply-To: <20200614053801.94112-1-navid.emamdoost@gmail.com> References: <20200614053801.94112-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jun 2020 13:42:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost Date: Sun, 14 Jun 2020 00:38:01 -0500 > in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs, > fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. > > Signed-off-by: Navid Emamdoost This does not apply to the net tree.