Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1952285ybt; Mon, 15 Jun 2020 13:55:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJBKOvKVexZ8H74v0QuaIQT6yxvQc28FlcTaWAHANyG2BY0VXmeDvXZZ+5vZW57RwZu462 X-Received: by 2002:a17:906:8387:: with SMTP id p7mr26500037ejx.323.1592254515259; Mon, 15 Jun 2020 13:55:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592254515; cv=none; d=google.com; s=arc-20160816; b=AR89B7D0uHeAXnej1Ma7eFhBp5Nc3OjdGGNjlX3RhJii3wtWZ/idox2IpyrJKJosC+ RTl4v0GZKYaHvJ+1XBbgt0UadgUxcgknf5hnTa+r3KIuHB+GigTH1zxtvgg/Sn4BnuXw uOQj6Qy9IvZIo+AiI7o/Vc4ndsJ5jghDY1kV5m5AkpJTZ/Eh/++rfK1sRRdDczc5PyQj bDyVUrfU4q5voGuCvVCvk9E7dXPYr6Z6CWvD3AqP2ycIXalkmFot0dOBpp6NtlgEJknf CYbeMVkLjxKsp9pNjbOyqGE0cyKF8/glHrTesaSCVkOmj2vIaoQ/WRfYU3pU410REpfg oY/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rd4Bis913EpujGhElYgLSI0ncb8QZecIrdrVCVnTyvU=; b=L9d9AE7hNhPZshQCCsLyD4JQDtzuvyfHPfhwh72sg/glMzR24DxtNw/TQdiguMDKRs uoLu423h8m9BxML3mYmhxztiSed2M6TxbukW6TgrLoe2Q9tP4kscujSbATpnUOapOIk7 RNbmAyhQTFeV8yivIYbfTjz1NdmFbmi5kzmyyE5nolL+c0MMButK4qhXzylUzTz3/2gQ SoQUdixxSsiX5XRRWMuPlUOmPD+e/NeeLo1ONH4KDGj5Z1cUf4kfAjjABS9RbPYKJuTS 4lJ3eHLgQKzNi45o73FzNiIrGcuXibZRy1ZWS8yvaFwqSKs8ljOQEYOJ6eyDv0oXmeOM J4aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nM0aeA93; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn1si12604458ejc.638.2020.06.15.13.54.53; Mon, 15 Jun 2020 13:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nM0aeA93; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731517AbgFOUxI (ORCPT + 99 others); Mon, 15 Jun 2020 16:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730995AbgFOUxH (ORCPT ); Mon, 15 Jun 2020 16:53:07 -0400 Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECAC5C061A0E for ; Mon, 15 Jun 2020 13:53:06 -0700 (PDT) Received: by mail-vk1-xa43.google.com with SMTP id q69so4269701vkq.10 for ; Mon, 15 Jun 2020 13:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rd4Bis913EpujGhElYgLSI0ncb8QZecIrdrVCVnTyvU=; b=nM0aeA93ECFWHCKDPneEvVWYbTCJNJCR7S3x/XI/ufOnkzmrXx/3IjGE2e6U8L8IgH ey3ihVrxR2tidqY9+CsotwvLuwTjCpwcuUB19G79WA4ZKvcwSVcYdL8vv1G7z8mtFYEG PZv1IGvAul6VpAJ9Obe/HowpGv2nXBSlr6DEKQHHelfPpxSnt++GHOTR60oSpOA1j4mi u8TpyhMlvdRAJo0iLXKZMo6nXJA3dHaYS/iHz7a1bJv5L0idTgkbPKZQ3tB0qyu2h3+a AaIKDsmM4ys66TGHt7yc7LPAKJyxuFzfPa9ifFN/lVdCmIi0UIjnH21JTH5Y/ZHtgaHG K+Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rd4Bis913EpujGhElYgLSI0ncb8QZecIrdrVCVnTyvU=; b=RVuIgKgweHCNv+rnSffsvTZNOtSb7/7i7MD8QegMGUishHuEcWpOYA7BVnwZgqTxyM /zYx6E4mZBl50bjYQtWEBhXoBQ0SNOhdcz4r2+fPhURkdyuXTMcQgv9sOruZB9XTLXfN IF1Y04fm1OEn/hqTeKtG/XGD3O3bhsmcxG4qajoqZvC4+Ln0DJ800DvnnJsXb/5bovsl 4qQavwkSY4gKHCEeflSzuI34Fm46GYqlprwPoYC6jKY22v6esBy7phIQXxeZVHss3peZ KaUC3LuTyIGT9+WMALYrRq/6COI/rzueFRSGlYOSPAHs4Lsnc4clnbjjGbubhkEEwFwk OPLw== X-Gm-Message-State: AOAM531g0E5KbUFFFLB54LtKt+96Ee/jsc6VtvxLLqWZKje0HiND+e4P FrizlEEg/hCpALeQ8+CQM12D54285riWUf9LAg2WuQ== X-Received: by 2002:a1f:a8d0:: with SMTP id r199mr5021498vke.26.1592254386172; Mon, 15 Jun 2020 13:53:06 -0700 (PDT) MIME-Version: 1.0 References: <20200613155738.2249399-1-jim.cromie@gmail.com> <20200613155738.2249399-10-jim.cromie@gmail.com> <20200615132856.GF31238@alley> In-Reply-To: <20200615132856.GF31238@alley> From: jim.cromie@gmail.com Date: Mon, 15 Jun 2020 14:52:40 -0600 Message-ID: Subject: Re: [PATCH v2 09/24] dyndbg: add maybe(str,"") macro to reduce code To: Petr Mladek Cc: Jason Baron , LKML , akpm@linuxfoundation.org, Greg KH , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 7:28 AM Petr Mladek wrote: > > On Sat 2020-06-13 09:57:23, Jim Cromie wrote: > From my POV this makes the code less readable. Open coding is much > more clear than an ambiguous macro name. > > Best Regards, > Petr Im going with Joes approach, which addresses your concerns too thanks