Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2090833ybt; Mon, 15 Jun 2020 18:25:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkD0HrrJIC2j2xSovDT1RGbAw51kS8das5ZsbJFR3/O/3B//2elWKAxfr7YIcO+mEYJLpZ X-Received: by 2002:aa7:c403:: with SMTP id j3mr484866edq.294.1592270755309; Mon, 15 Jun 2020 18:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592270755; cv=none; d=google.com; s=arc-20160816; b=IU/lsw7Fk8fGYzQaYzUDMDpGsOPfCfJC02Os72oaAzudS5Up5rEOI/3Zn370EZCAaa WF0dTVWdR450XdguKO42PfctsYieAVl3E2shKKC07tl8EDG657uxt7cKthPxUgRUjYIT n7p6ffrkOWq+GtcuQHndklFO7aGSSjebsLvx8mBu/c7WRLKyNMm1WTNMwx1IFFiSRJ+u Hilygzc4DMEDkXl7X7M75O7oZ22dwRm7FMDaBXTcKZTt/oBparL/jrBzpzsse452qjLg iJb7gyNwkQGCqe1Qv2hBaERP5d7Zj+Qq6sNUZkRElv0LLhDIA6bUpwPyseNuFMv4rcDh mnAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=4ZJL71U3cI/eiI8rmxuwVYiQFA9Py88hNg9pTArXPqQ=; b=tpp8bVZg8LzhhAXF/XgQ9hyy/kArm/jkbrlyel8x8gdePRzWCSAc8r2DMXTnP6xz3n Ob1LalW5+TJnDMNXcxEFLlF5eARIqlX/JJfnzjGzoeEymStF/maRkm6BNqfuyouHlobB zuJzxeXiShFRbenr4pZEWDZXlb1MmxzE9Z5Ihl1PzWfcWNV20roKtbTJPcbIBGU7EJu5 mUYbpttam3pK3L6kYOOcZ/a/VWLMi25QywjBmkKUS2ClcucPYqM8Rc1jXiH9VnYRVsG9 1okRyWadBf8p2Y7C6gF15Hnrcj2jbYrwWi1pVGutVubR3RinZzwhEnsVsGT+2DB6CzMJ HCwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k14si9246736edq.542.2020.06.15.18.25.32; Mon, 15 Jun 2020 18:25:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726782AbgFPBXo (ORCPT + 99 others); Mon, 15 Jun 2020 21:23:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgFPBXo (ORCPT ); Mon, 15 Jun 2020 21:23:44 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F8A3C061A0E; Mon, 15 Jun 2020 18:23:44 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 125EE123C069B; Mon, 15 Jun 2020 18:23:44 -0700 (PDT) Date: Mon, 15 Jun 2020 18:23:43 -0700 (PDT) Message-Id: <20200615.182343.221546986577273426.davem@davemloft.net> To: mayflowerera@gmail.com Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links From: David Miller In-Reply-To: <20200615154114.13184-1-mayflowerera@gmail.com> References: <20200615154114.13184-1-mayflowerera@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jun 2020 18:23:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Era Mayflower Date: Tue, 16 Jun 2020 00:41:14 +0900 > + if (tb_sa[MACSEC_SA_ATTR_PN]) { validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so you don't need to add this check here.